From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 547B943D78; Fri, 29 Mar 2024 09:26:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE1894014F; Fri, 29 Mar 2024 09:26:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2C30940042 for ; Fri, 29 Mar 2024 09:26:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711700800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6YpDaiN2zGGedNOXDAKeEjax6sOuzq5hieXWehr6tl0=; b=QpBBpXsocELkbLNV9NFX7mmPPTc6GnvY/aJpAjJoGwvqdvozFQCcU5/hWNz+SarrSanNgT 90bJaUlU7c7ebuzJXu7q8hut+6hc58r44iNqVYviLTrrlXQDZBUw3AMHNzLFvAUiMRkVcs rwcq/sqUeDffrCJe5eDCCr3i1aiCI0k= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-JR6o9QusMnSYQQxV1-nwxw-1; Fri, 29 Mar 2024 04:26:37 -0400 X-MC-Unique: JR6o9QusMnSYQQxV1-nwxw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-515d139f285so280630e87.1 for ; Fri, 29 Mar 2024 01:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711700795; x=1712305595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6YpDaiN2zGGedNOXDAKeEjax6sOuzq5hieXWehr6tl0=; b=ZvSbQNAcgpf9pFGfRgZVhoHkIbRJw0oFuxmbi4SlKzwqkQ4cIuOsyrML58GDBfMhg0 8F0VGUBhsBB10tJsqPhIINWFK7oPKUTtCMc43zZMpDyN23cj2U2nMQ/lsksuYkrIXHCF d8gC5xlHi6gsgjsWJgBdb8dfn9Uv8VYoNEg+4bbiW1E9s8/k7lHmRcaOYFi748fZ05zV xajHTd8u/ff3O23f41Xd8Cao0yeIM4rIU10GuuiE9T9EOC0pMbpBoSLKsPd0hna3qCVB NLpowOvE9Mq+2Gz7umRRKdc1oco7QDn+5fLXIJS57F24LU96KpGTXlQ6+qlLzuGjVs8R dNow== X-Gm-Message-State: AOJu0Ywh6KFu7bI5Sg8tkKxShlF3LD2r4oXb1eV/begzDC7B1FaF9gXE aglO7k4h8prWykXQw81Ys0f1K259h1/RiwD+ANryQ/ruSDOnLDocqa49kaInrUj58/o7PHa2QuB PkvCdTwMR+zWb/Xm/i/zBYUbbYwHTpZqzTXCPLGSCcxFGaixSTv3458bleBnX9GmDEjwh+6E6Nh +ytmAbVdjPMhHbnGc= X-Received: by 2002:a19:2d06:0:b0:513:d8e3:fe3d with SMTP id k6-20020a192d06000000b00513d8e3fe3dmr1046850lfj.26.1711700795558; Fri, 29 Mar 2024 01:26:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUsIzK2O6e5sk3cCCfPM4GOUT9EIxeHJ1KfqLvKROJdmWwOFwKgUmy7ikWpob/fwQJCpWfk0yzKUNDx8sSJlI= X-Received: by 2002:a19:2d06:0:b0:513:d8e3:fe3d with SMTP id k6-20020a192d06000000b00513d8e3fe3dmr1046837lfj.26.1711700795241; Fri, 29 Mar 2024 01:26:35 -0700 (PDT) MIME-Version: 1.0 References: <20201123070523.21661-1-murphyx.yang@intel.com> In-Reply-To: <20201123070523.21661-1-murphyx.yang@intel.com> From: David Marchand Date: Fri, 29 Mar 2024 09:26:23 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error To: Bruce Richardson Cc: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com, stevex.yang@intel.com, Murphy Yang , Vladimir Medvedkin , "Mcnamara, John" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Mon, Nov 23, 2020 at 8:08=E2=80=AFAM Murphy Yang wrote: > > If enable hardware outer UDP TX offload checksum, it doesn't take effect > when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware > can calculate the outer tunneling UDP checksum. > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") > > Signed-off-by: Murphy Yang > --- > drivers/net/ice/ice_rxtx.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > index 5fbd68eafc..9769e216bf 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags, > *cd_tunneling |=3D (tx_offload.l2_len >> 1) << > ICE_TXD_CTX_QW0_NATLEN_S; > > - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) && > - (ol_flags & PKT_TX_OUTER_IP_CKSUM) && > + /** > + * Calculate the tunneling UDP checksum. > + * Shall be set only if L4TUNT =3D 01b and EIPT is not zero > + */ > + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && drivers/net/ice/base/ice_lan_tx_rx.h: ICE_TX_CTX_EIPT_NONE =3D= 0x0, So this check above is always true... I suspect the intent was: if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) !=3D ICE_TX_CTX_EIPT_NONE) > (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING)) > *cd_tunneling |=3D ICE_TXD_CTX_QW0_L4T_CS_M; > } > -- > 2.17.1 > --=20 David Marchand