From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 858C0A0093; Tue, 23 Aug 2022 10:41:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 284AA406A2; Tue, 23 Aug 2022 10:41:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CC1E6400D6 for ; Tue, 23 Aug 2022 10:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661244080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=THKbEPXEUoUnItPA9jGsdO5E+VssIyaDMmf8IuVZHP0=; b=AbE8rhJtzieufWdLqtavdYIyxKDreqOzyiSplrYLwwt7mZtLghL/vmo+C5YputlBa84YYZ 7/FA/oCN7jO+CkpCEa1eO9BSd8oV1jI7077SLtX+i/k69/XjCpkOqFKvk1g+l+UVjxp8Du 5h5KRS3lVUAgMpsTnPLTW/nOgfJWeR0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-658-cxF0SDQZO1KgyIvGQV-PFw-1; Tue, 23 Aug 2022 04:41:19 -0400 X-MC-Unique: cxF0SDQZO1KgyIvGQV-PFw-1 Received: by mail-lf1-f72.google.com with SMTP id m6-20020a05651202e600b00492d736eeefso2770205lfq.22 for ; Tue, 23 Aug 2022 01:41:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=THKbEPXEUoUnItPA9jGsdO5E+VssIyaDMmf8IuVZHP0=; b=v6moYB9zKIoRCNMv51ZQr70P+gDseKjBhLNofnkLRz53rsJHVXj3NC09/V/1bMkHwY Fy2CsyMSgh5giUDBK7RnSWKurU2rpIEI/iPpO4VpAexFi1rOikqZdXQQ9mapB3IueqxD HAO8Un54V5sUd+zjRGGzC9AJqwnNgjw7sKwhDIIgL3y7kgGCdCXyL5w6aC5gJvXl2khT Em32hATcSbc5JZ2js4UGQ4z8QLWfU92VrrdJHiR1enE969gxCEcGXrUfz1XFuSpXTT4y gc8HOfvwyQsuo790Avlzbp4d6OVC0XBVSb3vXpvi0rscInqDnz6X9TJkkke1lt/Udy/G +Xgw== X-Gm-Message-State: ACgBeo0RQD1rVkDXVwkptG3cSK3o2PWvIql1L9WA+WAY3md6XzYI79ci UQxR7GTDRqCAZnT0b2nANboa+q78hON6Wytp5SbCeZdYJQ+CL9kn+dtWnhivCYZ5trGMI6cjaRb MUqpBTRiqahwZf/NwNro= X-Received: by 2002:a05:6512:3dab:b0:492:ecee:e5de with SMTP id k43-20020a0565123dab00b00492eceee5demr2227895lfv.484.1661244078080; Tue, 23 Aug 2022 01:41:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR4SxHvbKXyOahBWdc1630T3/SzDZvJhcICC6/jM8EQCtg09IKO7BqjDZw9THh7S2juVwOwIyHMewwCbJH6htcc= X-Received: by 2002:a05:6512:3dab:b0:492:ecee:e5de with SMTP id k43-20020a0565123dab00b00492eceee5demr2227887lfv.484.1661244077790; Tue, 23 Aug 2022 01:41:17 -0700 (PDT) MIME-Version: 1.0 References: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> <20220804190602.1045171-4-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20220804190602.1045171-4-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Tue, 23 Aug 2022 10:41:06 +0200 Message-ID: Subject: Re: [PATCH 03/10] ethdev: remove deprecated defines for RSS configuration To: Andrew Rybchenko Cc: Thomas Monjalon , Ferruh Yigit , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko wrote: > > Remove deprecated ``ETH_RSS_*`` defines used for hash function and RETA > size specification. Use corresponding defines with ``RTE_`` prefix > instead. Nit: we still have some reference in comments in the publicly exposed header: HEAD~7:lib/ethdev/rte_ethdev.h: * The ETH_RSS_L4_CHKSUM works on checksum field of any L4 header. HEAD~7:lib/ethdev/rte_ethdev.h: * It is similar to ETH_RSS_PORT that they don't specify the specific type of > > Signed-off-by: Andrew Rybchenko -- David Marchand