From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99ABEA0586; Wed, 19 Oct 2022 15:46:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E074427F4; Wed, 19 Oct 2022 15:46:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1501C410D1 for ; Wed, 19 Oct 2022 15:46:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666187210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LrjsKcB4W+MC/z8B9lMBMpBM/H5bukaszNv4tRWv188=; b=RoMFnA9OhTbnGId+51eCc+LZLN9vHiVjdDfHwgPc+y7EaR+2n7QxEn9HLC2yfe4nGDgByN P+jjVaRv588JNzQITfb4lxosX/y3EOntydVWo3hJHFDvjnUIT/7uDOV356nEzc822Hxbkf SWgnBPj0rCLbzFJ1aDYyEVXhSK3xAl0= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-154-bnS7sWjKPqS5zOv3oi_4VQ-1; Wed, 19 Oct 2022 09:46:49 -0400 X-MC-Unique: bnS7sWjKPqS5zOv3oi_4VQ-1 Received: by mail-pg1-f200.google.com with SMTP id k64-20020a638443000000b004620970e0dbso9712702pgd.6 for ; Wed, 19 Oct 2022 06:46:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LrjsKcB4W+MC/z8B9lMBMpBM/H5bukaszNv4tRWv188=; b=xmAdpNUr1jpIn5BmSlpylCD1lzPasqxceijoJHxqaKnxf1g2iFNGkgpOaSBS8rDMbd 9jkMMazq3ZNEoadqf8768FX6TjVlRecPoGWEPZfFNDX8XlOJGPUlcXqN3uq7lfpFWXyJ Qg0CTpHZMWZmjPbSx5ZKWVpnpjYjsPHrO1MoJpxU2BW8FyjRHBnXTpa2XL8YGYKw/urp e2pZLFbcG+HicGxNl6BAAHhcy9DBY3EeauCQgdLAXc0pCEeEPk7nnmipjaEIANJeXe2p kEdqzOzjiL/vorK5jIdWVuGY8j8WhMBUoGnA/mIyNuDyhBkhtGWY22lHwKi2ZvkHU9mt tEyw== X-Gm-Message-State: ACrzQf35FEnUpFvkasDDs7y1KocubY4n77ZXZd2Wec4C9NYNMRvfQJc0 rCFNM3kJ8cRIs2wwlX98bVfKqz0QJPsmE4NUZQqP7qf7Qc5WesyS2WuqHYOFvy71nt5d7vAM6mH AdrFjkDRhRam/986Qthw= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr46788085pjb.39.1666187208353; Wed, 19 Oct 2022 06:46:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5SzZoAuWZaZ+bGeCas/kwVZkojBVAQfaUc3B1w1iHC9GsRIw6xX2NQCJ24EgfCMgUIC3zvFdUNokSJdvJTG5k= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr46788047pjb.39.1666187208031; Wed, 19 Oct 2022 06:46:48 -0700 (PDT) MIME-Version: 1.0 References: <20221013074928.3062458-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 19 Oct 2022 15:46:36 +0200 Message-ID: Subject: Re: [PATCH] trace: take live traces via telemetry To: Bruce Richardson , Jerin Jacob Cc: dev@dpdk.org, Sunil Kumar Kori , Ciara Power X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 19, 2022 at 12:53 PM Bruce Richardson wrote: > > On Tue, Oct 18, 2022 at 02:14:37PM +0100, Bruce Richardson wrote: > > On Thu, Oct 13, 2022 at 09:49:28AM +0200, David Marchand wrote: > > > Register telemetry commands to list and configure trace points and later > > > save traces for a running DPDK application. > > > > > > Note: trace point names contain a '.', so the list of valid characters > > > used in telemetry commands and dictionary keys has been extended. > > > > > > > > diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c > > > index 34366ecee3..5b319c18fb 100644 > > > --- a/lib/telemetry/telemetry_data.c > > > +++ b/lib/telemetry/telemetry_data.c > > > @@ -106,6 +106,7 @@ valid_name(const char *name) > > > ['a' ... 'z'] = 1, > > > ['_'] = 1, > > > ['/'] = 1, > > > + ['.'] = 1, > > > }; > > > while (*name != '\0') { > > > if ((size_t)*name >= RTE_DIM(allowed) || allowed[(int)*name] == 0) > > > > I don't see an issue with allowing "." characters in dictionary names, so > > for this part: > > > > Acked-by: Bruce Richardson > > By way of additional minor follow-up: > * I think the addition of "." to the list of allowed characters should be a > separate patch, rather than just added as part of this larger patch. If > doing a separate commit to add boolean type, this could be a change in that > set. > * There are a couple of API doxygen comments for the dictionary functions, > rte_tel_add_dict_*, where the allowed characters in the name are called > out. You probably should add "." to those comments too. Oh indeed, so ok let's go with a separate patch. Previously, I thought the telemetry additions for traces were fine to go with the fixes series. But seeing how it evolved, I'll merge the traces fixes (who got acked) now and respin a separate series for the rest. -- David Marchand