From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43B22431DE; Mon, 23 Oct 2023 09:37:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 212774027E; Mon, 23 Oct 2023 09:37:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EEFD140270 for ; Mon, 23 Oct 2023 09:37:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698046639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TRNsi5aOi/1PMhsmSdx3FJs3ZlEUkLUJ5cPEqa8pA0Q=; b=gQDYF1onQEMuCRwvHsdln8cR04FJAVgvOhWq6UHqVcBSvzTywSyoUL6hXxU4mkNyofTJ/B DA3b/G+yR4Pr5rIcfnIDGpGLA5qPPxuE2i2ITEUJgNsWVfYqbDfZoN4V4W+JrYOF4p6BZP iovW9Yv4CmXHyuQgzDMLfY0oWGEIw+E= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-7hdQ5SraPEyQFZViw4yJoA-1; Mon, 23 Oct 2023 03:37:17 -0400 X-MC-Unique: 7hdQ5SraPEyQFZViw4yJoA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c503b47880so15885131fa.0 for ; Mon, 23 Oct 2023 00:37:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698046635; x=1698651435; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TRNsi5aOi/1PMhsmSdx3FJs3ZlEUkLUJ5cPEqa8pA0Q=; b=BUrOI69IzIJXz2S6lDyJJV/vEVA9Rvv1YJYtS7NCoxDRN+kQ/FNhJWNykagB5Yg6cB vt0dOcSvMrqWUYXnuEGOJF1mE4e8gzI1nmAzbmvt6eoDbpFgmMkaSkZ3aye03Q6RIzaU mOi8+uBcl3gU/MAXmgm7I+SAi062kvcEDG1MCc8NnS9/vwUEHmjvdrYhc2BL8hUM1LFH ldA6jWFn11vWP0ikq3LaMk2fy1k/v9nuQf97/8dtT+DYBJT2/jh7gAYiTymqACvG2iet 1/kOpqCQds8gGBSnKCnakefBR4OJOmK2LAxjQ31yA1FcKEoWG4Dr8BYsxmk79XpSvYdg tw7Q== X-Gm-Message-State: AOJu0YzqDYoi87xqdlw9q1vNZsu1e1T57ukQnFsfkdob9F16UuECMYm1 gj4HeLCD8ypvFVUFG2kOM8dUuLL+UW2mDutIE75ZT/Fx5eRkikWACttllOyG+JPnjrgT6X/K2wM 0Hgb0chACFCqkX1+p4DU= X-Received: by 2002:a05:651c:2115:b0:2c3:e35d:13d with SMTP id a21-20020a05651c211500b002c3e35d013dmr4448036ljq.5.1698046635687; Mon, 23 Oct 2023 00:37:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGX8oqm79jSHJKfOobvXj6HjSBhDbprtbCpFUjYdgFGdsEynJLzKdGb7pdyv26jf0VRTFk+1mKIdvb9FlVs2YM= X-Received: by 2002:a05:651c:2115:b0:2c3:e35d:13d with SMTP id a21-20020a05651c211500b002c3e35d013dmr4448030ljq.5.1698046635336; Mon, 23 Oct 2023 00:37:15 -0700 (PDT) MIME-Version: 1.0 References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230809133553.1396119-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Mon, 23 Oct 2023 09:37:03 +0200 Message-ID: Subject: Re: [PATCH v8 0/3] Split logging functionality out of EAL To: Bruce Richardson , Thomas Monjalon Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 11, 2023 at 2:46=E2=80=AFPM David Marchand wrote: > > On Wed, Aug 9, 2023 at 3:36=E2=80=AFPM Bruce Richardson > wrote: > > > > There is a general desire to reduce the size and scope of EAL. To this > > end, this patchset makes a (very) small step in that direction by takin= g > > the logging functionality out of EAL and putting it into its own librar= y > > that can be built and maintained separately. > > > > As with the first RFC for this, the main obstacle is the "fnmatch" > > function which is needed by both EAL and the new log function when > > building on windows. While the function cannot stay in EAL - or we woul= d > > have a circular dependency, moving it to a new library or just putting > > it in the log library have the disadvantages that it then "leaks" into > > the public namespace without an rte_prefix, which could cause issues. > > Since only a single function is involved, subsequent versions take a > > different approach to v1, and just moves the offending function to be a > > static function in a header file. This allows use by multiple libs > > without conflicting names or making it public. > > > > The other complication, as explained in v1 RFC was that of multiple > > implementations for different OS's. This is solved here in the same > > way as v1, by including the OS in the name and having meson pick the > > correct file for each build. Since only one file is involved, there > > seemed little need for replicating EAL's separate subdirectories > > per-OS. > > Series applied, thanks Bruce for this first step. > > As mentionned during the maintainers weekly call yesterday, this is > only a first "easy" step but, thinking of next steps, more splitting > may not be that easy. > > At least, on the libabigail topic, as we need the ABI check to handle > libraries splits, a new feature has been cooked in (not yet released) > 2.4 libabigail. > https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dcommitdiff;h=3D0b338df= af690993e123b6433201b3a8b8204d662 > Hopefully, we will have a libabigail release available by the time we > start the v24.03 release (and re-enable ABI checks). For the record, libabigail 2.4 got released last Friday. I had already prepared a patch to use this new feature, I can send it when needed. --=20 David Marchand