[PATCH] eal: fix location of per lcore macro documentation

[PATCH] eal: fix location of per lcore macro documentation

[Tyler Retzlaff]

doxygen document generation does traverse RTE_TOOLCHAIN_MSVC conditional
compilation paths so move the documentation for per lcore macros out of
the RTE_TOOLCHAIN_MSVC block.

Fixes: b2f967dcae69 ("eal: implement per lcore variables for MSVC")
Cc: roretzla@linux.microsoft.com

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/include/rte_per_lcore.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/eal/include/rte_per_lcore.h b/lib/eal/include/rte_per_lcore.h
index 2b846f9..0bfc2ff 100644
--- a/lib/eal/include/rte_per_lcore.h
+++ b/lib/eal/include/rte_per_lcore.h
@@ -25,24 +25,24 @@
 #include <pthread.h>
 
 #ifdef RTE_TOOLCHAIN_MSVC
+#define RTE_DEFINE_PER_LCORE(type, name)			\
+	__declspec(thread) typeof(type) per_lcore_##name
+
+#define RTE_DECLARE_PER_LCORE(type, name)			\
+	extern __declspec(thread) typeof(type) per_lcore_##name
+#else
 /**
  * Macro to define a per lcore variable "var" of type "type", don't
  * use keywords like "static" or "volatile" in type, just prefix the
  * whole macro.
  */
 #define RTE_DEFINE_PER_LCORE(type, name)			\
-	__declspec(thread) typeof(type) per_lcore_##name
+	__thread __typeof__(type) per_lcore_##name
 
 /**
  * Macro to declare an extern per lcore variable "var" of type "type"
  */
 #define RTE_DECLARE_PER_LCORE(type, name)			\
-	extern __declspec(thread) typeof(type) per_lcore_##name
-#else
-#define RTE_DEFINE_PER_LCORE(type, name)			\
-	__thread __typeof__(type) per_lcore_##name
-
-#define RTE_DECLARE_PER_LCORE(type, name)			\
 	extern __thread __typeof__(type) per_lcore_##name
 #endif
 
-- 
1.8.3.1

Re: [PATCH] eal: fix location of per lcore macro documentation

[David Marchand]

On Thu, Sep 21, 2023 at 8:14 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> doxygen document generation does traverse RTE_TOOLCHAIN_MSVC conditional
> compilation paths so move the documentation for per lcore macros out of
> the RTE_TOOLCHAIN_MSVC block.
>
> Fixes: b2f967dcae69 ("eal: implement per lcore variables for MSVC")
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks Tyler.


-- 
David Marchand