From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4002A046B for ; Fri, 28 Jun 2019 21:22:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 278411B9B5; Fri, 28 Jun 2019 21:22:31 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 1D1F21B9B1 for ; Fri, 28 Jun 2019 21:22:30 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id 190so4761495vsf.9 for ; Fri, 28 Jun 2019 12:22:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hJ3dvJcVerqMVHxZGuEIcrJGPa3CQ/zaakL/ji+Ejww=; b=LqhQpqb/VQ7Pr2yTgyxIcdxs00xdiP5QIZDA2MNqq+TPJ66tEMKlssLB5so4iFh79n snjqp6ZchDrm2tlpj/xWfh308Pd4YuJuHa7N53SkLRBUtpetjFbRm1Qa5ylVClnt+wLs MsvcrAb/caqK5BU1ly8Wf8lyndilDrxjNZrjLulKT3khqDf3OU/LOmL6FUqfS0ASp1Zu Z8JtrXFy8OTvXk6aaAFvibeHshbU/avBBIwAXV8hR5rJv+6MqHxaPKcwsjQFKnmwBvjr 0/o3Ufb+IxJMWKVIByBEvBdwQfOdxKagiQL91IRHHq7wQjjLVaVtBxfk0w2EUulN5eQu Y+rw== X-Gm-Message-State: APjAAAXuWJZt3pYi/fcX3C8TZJmWPcg7jUGDXgD1T833ZRx3zbDhEXqC G7j/YKOjXzgLl9a67yLLUGb1LAPwmnFgSLiT+IrABQ== X-Google-Smtp-Source: APXvYqz2nHJ5FUPH78nt+Hi3K34iwOjRaP/kxZ2g2Vrb9A1c0gNEHuegqJUVwUG9tSLGoUqdzJ+CpebAfvZtx/phxcA= X-Received: by 2002:a67:688f:: with SMTP id d137mr7322589vsc.198.1561749749589; Fri, 28 Jun 2019 12:22:29 -0700 (PDT) MIME-Version: 1.0 References: <20190628155056.28884-1-adrien.mazarguil@6wind.com> <20190628155056.28884-3-adrien.mazarguil@6wind.com> In-Reply-To: <20190628155056.28884-3-adrien.mazarguil@6wind.com> From: David Marchand Date: Fri, 28 Jun 2019 21:22:18 +0200 Message-ID: To: Adrien Mazarguil Cc: Thomas Monjalon , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 28, 2019 at 5:57 PM Adrien Mazarguil wrote: > Rather than prefixing the return type of function prototypes with > __rte_experimental, move it to a separate line to enhance readability. > > Except for checkpatches.sh, this patch was automatically generated by: > > sed -i \ > -e '/^\([^#].*\)\?__rte_experimental */{' \ > -e 's//\1/; s/ *$//; i\' \ > -e __rte_experimental \ > -e '/^$/d}' \ > $(git grep -l __rte_experimental -- '*.h') > > And applies on top of below commit: > > Fixes: 3b45414830ff ("enforce __rte_experimental at the start of symbol > declarations") > Cc: David Marchand > > Signed-off-by: Adrien Mazarguil > Either way is ok for me. But if we go with yours, we can squash this patch into mine and avoid this "va-et-vient". Thomas, what do you want to do? Adrien patch1 can be caught in my patch8 by re-running the commands from the commitlog. Can you handle it? -- David Marchand