From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9B91A052B; Tue, 28 Jul 2020 14:05:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5F431BE8A; Tue, 28 Jul 2020 14:05:32 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6D6432B9C for ; Tue, 28 Jul 2020 14:05:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595937930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G3shZxSuqOKm6NKkikI/K0/ZOP+zuJk8kDJ4jqO9mf4=; b=gFSzvLkoKlJBbfxYhBdgdBymdxaXQGZDXNF5J/1CDCdL9son4ULpSQoQ88L4dj6gqvN+bX GpQHp5IoItBw9/yMaHB0d+0D737mxgou96WUxiom6QV2o/3HpE7DEHmLDKbKUHcatzff3V fW8UrZTfcT/3Ee9ktsAILQRNQytqdSY= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-DX7zk1xVN5SDMcOe8inO7g-1; Tue, 28 Jul 2020 08:05:29 -0400 X-MC-Unique: DX7zk1xVN5SDMcOe8inO7g-1 Received: by mail-ua1-f71.google.com with SMTP id r18so6125553uah.12 for ; Tue, 28 Jul 2020 05:05:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G3shZxSuqOKm6NKkikI/K0/ZOP+zuJk8kDJ4jqO9mf4=; b=ljchegqmMgTIkls1xhebI50JSP06DFCbFM8HOHUCiM+xfOMHeQtVqU78aUTBPTyl/N 2j9kSMAcLOwkVlOnY7FAdOviod71wGJ1owt1YQLewdjs9AooX8DgVuQBlkSB9rseZGvQ o3DlFRNFkvYPCy0sDc7n9SJoksQKpH9IjTdNAOTT/SV4K21Wnd1iaeCopb060KzagXTU Okg9QWV86likdzUjhriaUUTtxr+4dAb7Pgcz7eiMv7/XF72q3oDY/e4gi4IUSuiyxQsa ZCiPuXcv9rU24MaxtQyvel1VZM+QNRf0hRyItlR6qjlqXK+8DpbVVLk21Qr2YFEC+7x9 xUMw== X-Gm-Message-State: AOAM5337jau9DeR9GDytD13eMTP0V61mb0Nlme4psPn2vDZoQg7LQDfB T1ntVmfffZx9a9Xhelg+D9Xc2iRbGZT/Yl1q6wGrRLobHxbPDoAQ5Y50+aGoq7XydJtkUKShhMg /X8pPg1kX7/72ykh408M= X-Received: by 2002:a67:cb9c:: with SMTP id h28mr19220839vsl.39.1595937928616; Tue, 28 Jul 2020 05:05:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxM85JaQOsxvJksRSXtbRf8xHpDYhu6wvaZvevbJmHBNLFp+ASlgN6lWf3k18efLUFaLQ9fCOSV11+YG5dhhxI= X-Received: by 2002:a67:cb9c:: with SMTP id h28mr19220799vsl.39.1595937928186; Tue, 28 Jul 2020 05:05:28 -0700 (PDT) MIME-Version: 1.0 References: <1595916684-30135-1-git-send-email-xuemingl@mellanox.com> <1595928159-10346-1-git-send-email-xuemingl@mellanox.com> In-Reply-To: <1595928159-10346-1-git-send-email-xuemingl@mellanox.com> From: David Marchand Date: Tue, 28 Jul 2020 14:05:17 +0200 Message-ID: To: Xueming Li Cc: dev , Asaf@dpdk.org, Maxime Coquelin X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [v2] vdpa/mlx5: fix event queue number query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 28, 2020 at 11:23 AM Xueming Li wrote: > > With latest rte api, vdpa example failed on vq setup, the api to get > event queue of specified core failed. > > After > commit 67ae5936c4fc36 ("eal: fix lcore accessors for non-EAL threads"), > code of "vhost-event" thread to get current cpu id returns -1. > This is how you figured this problem, but the first part of the commitlog gives the impression there is a regression in the EAL. I would prefer it is removed (maybe simply when applying?). > On the other hand, internal api devx_query_eqn expects index of event > queue vectors, no need to use cpu id. As the doorbell handling thread is > per device, it's sufficient to use default event queue. > > This patch uses the default id(0) as event queue index. > > Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad Thanks. -- David Marchand