From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09851A0A02; Thu, 14 Jan 2021 13:49:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1D81141223; Thu, 14 Jan 2021 13:49:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 17FD9141213 for ; Thu, 14 Jan 2021 13:49:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610628580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CBIh5BAc0H5/Ggu5I/Jssz/iCzBGLhm59PexJRJt1iU=; b=eX0fBrKfMbvKeDihH8oTDxEYonXH0LGmbm/qmDku4PQhQGyL2Iw92fIFAbYBrcEyoxYfT/ lODqPcJkKpvzhzppp0HTw7N8rhLcRVZ9UnzPzCCXieVRwBpxSqfXunUMfLEmkgMb//sEZY UP00oGOjJdGenhyNXPVyWp5ClBDriDU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-RQ4IDHkQM0eB2L6IFO7Plw-1; Thu, 14 Jan 2021 07:49:39 -0500 X-MC-Unique: RQ4IDHkQM0eB2L6IFO7Plw-1 Received: by mail-vs1-f70.google.com with SMTP id u15so774501vsg.18 for ; Thu, 14 Jan 2021 04:49:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CBIh5BAc0H5/Ggu5I/Jssz/iCzBGLhm59PexJRJt1iU=; b=Cfwu0o0NajsUaDLCuuj5af8SudPbFD0mFNXw1BOHEj/KFNSQIx/Lul4SrcYrzzOwLm 4Sut5/5sVOZG+zT1gu936H8dlRhIOeuznolLSfuZNWVZ58+qiD+ontw4Kxfp8Uvkeog5 jrdzlWMuSceQaE6iIsmwT6mKRFrCW/MkYs/vyIDR+UHNjsySqESJPTuCBjek3vT87a7M o+VDiOIRTnP8JkrN5dFpFgFBfZu4NSifMBNvvMCe0DBA7tt5vve45P8z9u3dfE5ziQTs T7t1+i01GovrOsF6GqUmkRl6m/FyJ7AfAjju1b6/UPuHDxtekfyyxlSJuShH7j4lxU1T CTmw== X-Gm-Message-State: AOAM532GX/GSgjoEY1Rr2DEEuESKLnPervK/6B54ls4fRPjGRWrSxR6C 1cr2yplgi4nAY3GUPtzqXIeo38P8xKEzACkHWMYU2qDF/GU9mgqhu+0NmeMFoXz3WGd/60iGi5L z/MwoRN9sdbRE0FQ21Yo= X-Received: by 2002:a1f:3246:: with SMTP id y67mr6055646vky.9.1610628578665; Thu, 14 Jan 2021 04:49:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJztg9umsc7XGhnmIR+I7hq/Yowm5JAywwqQWodo8yt266e/98UxzpgWt/nhP+QwbdzNjyT7fwfRR6i9tIiFk8E= X-Received: by 2002:a1f:3246:: with SMTP id y67mr6055639vky.9.1610628578496; Thu, 14 Jan 2021 04:49:38 -0800 (PST) MIME-Version: 1.0 References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210114110606.21142-18-bruce.richardson@intel.com> <20210114122839.GB1959@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210114122839.GB1959@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 14 Jan 2021 13:49:27 +0100 Message-ID: To: Bruce Richardson Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 14, 2021 at 1:28 PM Bruce Richardson wrote: > > Can we instead flag those headers from the libraries themselves? > > In addition of the headers current variable, something like a > > internal_headers or private_headers variable? > > > > Yes, we could do that, though we need a suitable name, since they aren't > internal only or private. :-) Maybe just have it literally called Yes. > "skip_chkincs_headers"? Open to more ideas... > People who get reports from this odd tool "chkincs" in the CI on their new shiny header, might find some info more easily if they grep for chkincs. +1. -- David Marchand