From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 270A5A0353; Tue, 19 Nov 2019 22:50:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22F6ACF3; Tue, 19 Nov 2019 22:50:30 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id B92A3235 for ; Tue, 19 Nov 2019 22:50:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574200228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nYGj5f3/nR8uD78rx0Twse6eOkTl3JLFgUmbKq/6IGY=; b=hAX8XBKe8gcf9tPS79Pvu9AdiZQ57Ah99S4cu3s1RU/1YChxgnED97Sb+0RsVYadKSPxkm /ZAlGTIKeaxDWZLG2TeeCvODpBRUc20hB0v9biuS35NYPgSqFDR996agbFZGY/Ecg7T3Hl gogZNfB4KB9a4eT/8IuPmOgVkWOajsg= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-U92qFvcIOKKKwLkGykZMfA-1; Tue, 19 Nov 2019 16:50:24 -0500 Received: by mail-io1-f69.google.com with SMTP id f66so6470048ioa.21 for ; Tue, 19 Nov 2019 13:50:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+sDO28trC29R9zEXYBVVC65jHrNMjaMhtsGgFikkSp0=; b=Q9I4ck3X0ppxFZh0pB2bawjDNh4BhPtb9P/fL6nm75Pr4tdvfRHEXTrlNDshF71eM/ 9BziiNsHjUUoVU2Tcu0hZHXNoNVgKRy7/3EolR55x84h8qnL19EJpuKxz4l06q0seplj oaxTZDy66jOm68FmlvLV1j6M1Kmogv8dM/0yJAf2kw6DnZJeY73R0mxyzQML8gxEJGWh sfQh5qMAtyjELqmSBxZUnFG8zPWDn9ll5RAJdt7PDZ6hJ5L6r1aCdsEj4ebft/QgzUa6 ymO5K4cZy0R3Fh2mHIauf+y9VBYPBZlEatGzN2IrBQsEB7TlG0WHSxQoJrlcQHyY++dk ncXQ== X-Gm-Message-State: APjAAAU0ODecYqy87J2n8k7dV+4snva+M9Wliq1HE7Ajv2Fhw/G5gdVh YgeLcIiHsNxiOJwesSqJYN5T2JywHVUx2bD/nnDaREcXHr82icIzgV58SXrchHBVq+tv3EWgjaF 6YGLu2u7f1iXnaybmL5Y= X-Received: by 2002:a6b:7215:: with SMTP id n21mr17546077ioc.281.1574200224087; Tue, 19 Nov 2019 13:50:24 -0800 (PST) X-Google-Smtp-Source: APXvYqx4jAkBZFzpoL2BZEtQq7nzScqamCW1juTprib3Kk6xaKGY92K40OoVI7IH0CT2Z+zoVSFE4uvbnTA9RhsB2C0= X-Received: by 2002:a6b:7215:: with SMTP id n21mr17546057ioc.281.1574200223790; Tue, 19 Nov 2019 13:50:23 -0800 (PST) MIME-Version: 1.0 References: <0bf6dcd2734c7d97707a70450e6ba508afbaaa9b.1573230233.git.anatoly.burakov@intel.com> In-Reply-To: <0bf6dcd2734c7d97707a70450e6ba508afbaaa9b.1573230233.git.anatoly.burakov@intel.com> From: David Marchand Date: Tue, 19 Nov 2019 22:50:12 +0100 Message-ID: To: Anatoly Burakov , Thomas Monjalon Cc: dev , Hemant Agrawal , Sachin Saxena , Stephen Hemminger , "Mcnamara, John" , "Kinsella, Ray" , Bruce Richardson X-MC-Unique: U92qFvcIOKKKwLkGykZMfA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reduced the Cc: list. On Fri, Nov 8, 2019 at 5:26 PM Anatoly Burakov wrote: > > From: Pawel Modrak > > Merge all vesions in linker version script files to DPDK_20.0. > > This commit was generated by running the following command: > > :~/DPDK$ buildtools/update-abi.sh 20.0 > I inspected the changes. I caught just 3 oddities. The first two were reported in the patches on timer and lpm. The last one is in the dpaa bus driver: > diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa= /rte_bus_dpaa_version.map > index cf428a54dc..e6ca4361e0 100644 > --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map > +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map > -DPDK_18.08 { > - global: > - > - fman_if_get_sg_enable; > - fman_if_set_sg; > - > -} DPDK_18.02; > - > -DPDK_18.11 { > - global: > - > - bman_thread_irq; > - fman_if_get_sg_enable; > - fman_if_set_sg; > - qman_clear_irq; > - > - qman_irqsource_add; > - qman_irqsource_remove; > qman_thread_fd; > qman_thread_irq; > - Here, we had fman_if_get_sg_enable and fman_if_set_sg in 18.08 and 18.11 sections, but no symbols for 18.08 were in the code. I'd say this is fine, as there was no ABI change between 18.08 and 18.11 on them. The rest of the series looks good to me. Thanks Anatoly. --=20 David Marchand