From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0767F45450; Wed, 19 Jun 2024 21:59:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E823D42759; Wed, 19 Jun 2024 21:59:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DF04342707 for ; Wed, 19 Jun 2024 21:59:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718827154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XDS5Jxfyg1pxjKkozuZvuXnHhfrvXKRcy2SY0fAyWcA=; b=gC7XDEoAvGku/Zu92WWFhwsllDCTXSr/YPZgTTwDtF7SgBhgYrq+vAH7uBVrEVcTgkJqSe t2J0Q1lHrwgWgYtdWJT4LHL1gYhFfZ2wqEFsZ0GCzM3DOag7sld5vUPEFixSvVCtQNXC10 zPO51lOEHdmTUBx4cTszMIkKZTO5HEA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-jx8knK75Pr2vFMzDZEExpQ-1; Wed, 19 Jun 2024 15:59:12 -0400 X-MC-Unique: jx8knK75Pr2vFMzDZEExpQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52c983f4285so110270e87.2 for ; Wed, 19 Jun 2024 12:59:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718827151; x=1719431951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XDS5Jxfyg1pxjKkozuZvuXnHhfrvXKRcy2SY0fAyWcA=; b=E4Bw2hfwMscEDk9UoDHEP/VoBPMSjKwy4rDQhKmU4Eg/Zk1iGz4E32A1NnIPs1cRti 0sMT8tdNnBAkyRG0Fplurb0hnKQg4lW4+qHa50Ju1hHaMzhUQzNwRxcmE+E8/D9EDBgL DO5VwZkbT5kcZvG9sXoqIsZ9nsrh0aVaGPvPAjeijI7SK256c8vCqFCPmjy1yPVmFlcK 5rZWXjxUk1ClGsJJi376jXLnEHrVt7iobT2+kvR/3MZEgp4+EfYKgJ7nKTp9lw51L3t6 FYLFgMSw6FxlTFoJbagS0WRsmryUohWMH/fFrvvhFdM4jbqlxz6mPUtNtTovCTGcFi8q 2D4w== X-Forwarded-Encrypted: i=1; AJvYcCWPCq2FE5ZRA87iU/5louYvHCORrDbztyoogGNGJ68Gab/MJVYOmfgBXSZo2Orhf4SfC/psoR3BnJTDpPU= X-Gm-Message-State: AOJu0Yz+dv6sl0aVMJFfI8MsmHKFmXJ3NQVJEJ8ELXxStk7Taw7Jd/yk Q8jI9xO5myAHI2aU/dxHAqGDmmRqdhmZJ39DzWlGkspiHBNUNCx+MOEvXQTsuzZ6nUJZakrjb2w +eBDuKBW6dfCSvBe8VTU7Ism+LCgkttUJTeGOvs2xK3PRzFjPJEcXOtJLTY4IIP1GpDUK38mAfv Q0wJ1ejuAbFIGISEA= X-Received: by 2002:a05:6512:1247:b0:52c:892e:2b26 with SMTP id 2adb3069b0e04-52ccaa56ac0mr2438487e87.2.1718827151379; Wed, 19 Jun 2024 12:59:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFo0Kb/lXmljKbXNE9yaqP4j3VdkAxS9NUpmkR/w++K9L6bAX2TpIohTeiwD76fDEih4JTIBsHYofcGJnt89CU= X-Received: by 2002:a05:6512:1247:b0:52c:892e:2b26 with SMTP id 2adb3069b0e04-52ccaa56ac0mr2438477e87.2.1718827151168; Wed, 19 Jun 2024 12:59:11 -0700 (PDT) MIME-Version: 1.0 References: <20240501052659.231457-1-getelson@nvidia.com> <20240503042715.344550-1-getelson@nvidia.com> In-Reply-To: <20240503042715.344550-1-getelson@nvidia.com> From: David Marchand Date: Wed, 19 Jun 2024 21:58:59 +0200 Message-ID: Subject: Re: [PATCH v3] cmdline: increase input buffer size To: Gregory Etelson Cc: alialnu@nvidia.com, dev@dpdk.org, mkashani@nvidia.com, rasland@nvidia.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 3, 2024 at 6:28=E2=80=AFAM Gregory Etelson wrote: > > DPDK defines cmdline input buffer size to 512 characters. > That buffer size can be too small for long application input. > For example, the following flow template API testpmd command is 444 > bytes long: > ``` > flow queue 0 create 0 template_table 1000 \ > pattern_template 0 actions_template 0 postpone no \ > pattern eth / ipv4 / udp / end \ > actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \ > src_type value src_value 0x31 width 32 / \ > modify_field op set dst_type ipv4_src src_type value \ > src_value 10101010 width 32 / modify_field op add dst_type \ > ipv4_ttl dst_level 0 dst_offset 0 src_type value \ > src_value ff width 8 / count / jump group 100 / end > ``` > > The patch increases cmdline input buffer size to the LINE_MAX value, > which typically is 2048 bytes. > > Signed-off-by: Gregory Etelson > Acked-by: Bruce Richardson > Reviewed-by: Morten Br=C3=B8rup Applied, thanks. --=20 David Marchand