From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 9DF784F94 for ; Thu, 28 Feb 2019 09:32:23 +0100 (CET) Received: by mail-ua1-f67.google.com with SMTP id a42so18104742uad.1 for ; Thu, 28 Feb 2019 00:32:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wSDTxvETdkyVRqcurRD3GVBxABm6otMckhHOuLLVJAI=; b=G3x131tl8XB/8OlcjjQPqWC22LLUZU5cdgnceECJOKWr1SMXCd7fJgwFc9kLN8Le66 9F8GQo568jaMPHToSlekuLHVrcE23GAU2Cn+XHPcHeBUk2JAT/BBfG0oL8WXjIR9sOvd bY9SJyxzAOfxrnoNdgzfce79oeLK07DtzcAYC2I1H+Fn+wR2MFe/IWpt4fMmfOm/3Qlr CQYfXGId2o48Y4wXvEFeVIPcF4oNYNgRn8WKrTPXtNLA7D0K+p7uERRYfIKRsjbVCwN+ 2T/aVeR9t67axC0/ssXaXTCLTgDeKRcNom0y0NXtXT2E2igkJoBeBElrO4VZaApenvwI enVA== X-Gm-Message-State: AHQUAuY1S5XRhTCpnjx7lm6CW44tcZhRROgSNKHpSFyBCMIIh95Sm67+ qvVDKJ05zQQlq5/B2OT3UXH0EKrpqc9GIbK03JVcrA== X-Google-Smtp-Source: AHgI3IabdSyqqMDRXDf+1qcYD0csZ1Kk1JxRMU3mz0YMVbs2Xa/ycTgcKbbSijSma2ibTqMDYIqxYiYYmxs2Ao9fNtA= X-Received: by 2002:a67:c78e:: with SMTP id t14mr4197217vsk.180.1551342742904; Thu, 28 Feb 2019 00:32:22 -0800 (PST) MIME-Version: 1.0 References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com> <1551338000-120348-6-git-send-email-rosen.xu@intel.com> In-Reply-To: <1551338000-120348-6-git-send-email-rosen.xu@intel.com> From: David Marchand Date: Thu, 28 Feb 2019 09:32:12 +0100 Message-ID: To: Rosen Xu Cc: dev@dpdk.org, "Yigit, Ferruh" , tianfei.zhang@intel.com, dan.wei@intel.com, andy.pei@intel.com, Qiming Yang , haiyue.wang@intel.com, santos.chen@intel.com, zhang.zhang@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 05/11] drivers/net/ipn3ke: add IPN3KE PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 08:32:23 -0000 Really quick look at this. On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu wrote: > diff --git a/drivers/net/ipn3ke/Makefile b/drivers/net/ipn3ke/Makefile > new file mode 100644 > index 0000000..03f2145 > --- /dev/null > +++ b/drivers/net/ipn3ke/Makefile > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Intel Corporation > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_pmd_ipn3ke.a > + > +CFLAGS += -DALLOW_EXPERIMENTAL_API > +CFLAGS += -O3 > +#CFLAGS += $(WERROR_FLAGS) > This kind of bypass is likely to be kept as is forever... better fix the issues now. > > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c > b/drivers/net/ipn3ke/ipn3ke_ethdev.c > new file mode 100644 > index 0000000..e691f68 > --- /dev/null > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c > > [snip] > + > +RTE_INIT(ipn3ke_afu_init_log); > +static void > +ipn3ke_afu_init_log(void) > +{ > + ipn3ke_afu_logtype = rte_log_register("driver.afu.ipn3ke"); > + if (ipn3ke_afu_logtype >= 0) > + rte_log_set_level(ipn3ke_afu_logtype, RTE_LOG_NOTICE); > rte_log_register_type_and_pick_level() would be better. diff --git a/drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map > b/drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map > new file mode 100644 > index 0000000..ef35398 > --- /dev/null > +++ b/drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map > @@ -0,0 +1,4 @@ > +DPDK_2.0 { > + > + local: *; > +}; > Ok this driver has been around for a long time, but now, we are in 2019, please fix :-) -- David Marchand