DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: Xiaolong Ye <xiaolong.ye@intel.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	dev <dev@dpdk.org>,  dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/tep_term: fix return value check
Date: Thu, 13 Feb 2020 15:57:03 +0100
Message-ID: <CAJFAV8ymx+Jnv_GvrnRUx3tNa=62XWEd-=3Ru8c8Air=FSRTZg@mail.gmail.com> (raw)
In-Reply-To: <20200210070458.20865-1-xiaoyun.li@intel.com>

On Mon, Feb 10, 2020 at 8:05 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
>
> Added return value check for 'rte_eth_dev_info_get()'.
>
> Coverity issue: 349922
> Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration")

rte_eth_dev_info_get() prototype changed in 19.11.
Before this, it was a void.
So this Fixes: line is wrong.


> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
>  examples/tep_termination/vxlan_setup.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_termination/vxlan_setup.c
> index eca119a72..f8385b690 100644
> --- a/examples/tep_termination/vxlan_setup.c
> +++ b/examples/tep_termination/vxlan_setup.c
> @@ -195,7 +195,9 @@ vxlan_port_init(uint16_t port, struct rte_mempool *mbuf_pool)
>
>         if (tso_segsz != 0) {
>                 struct rte_eth_dev_info dev_info;
> -               rte_eth_dev_info_get(port, &dev_info);
> +               retval = rte_eth_dev_info_get(port, &dev_info);
> +               if (retval != 0)
> +                       return retval;
>                 if ((dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0)
>                         RTE_LOG(WARNING, PORT,
>                                 "hardware TSO offload is not supported\n");

I had a look at this function, dev_info is populated for port earlier
in the function, why do we need to check it again?
https://git.dpdk.org/dpdk/tree/examples/tep_termination/vxlan_setup.c?h=v20.02-rc2#n119


-- 
David Marchand


  parent reply	other threads:[~2020-02-13 14:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  3:07 [dpdk-dev] [PATCH] " Xiaoyun Li
2020-02-10  3:36 ` Ye Xiaolong
2020-02-10  5:04   ` Li, Xiaoyun
2020-02-10  6:51     ` Ye Xiaolong
2020-02-10  7:04 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2020-02-10  7:04   ` Ye Xiaolong
2020-02-13 14:57   ` David Marchand [this message]
2020-02-17  1:49     ` Li, Xiaoyun
2020-02-17  1:41 ` [dpdk-dev] [PATCH v3] examples/tep_term: remove redundant info get Xiaoyun Li
2020-02-20 15:53   ` David Marchand
2020-02-21  1:19     ` Ye Xiaolong
2020-02-21 10:13   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8ymx+Jnv_GvrnRUx3tNa=62XWEd-=3Ru8c8Air=FSRTZg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git