From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4427742C94; Mon, 12 Jun 2023 09:43:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C3C940689; Mon, 12 Jun 2023 09:43:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C94974014F for ; Mon, 12 Jun 2023 09:43:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686555823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jmNfXGbT31jvE6AxGpZVfTL4nrJN/7qC8PW9Aoa9Iyo=; b=CJu/b6yELerExDE7ZOIRfy+Zwqlkma6IIGqKB50hLZ/Vs0NfRmfv5uRScbJ9x5jCFfeLd+ 13r6GAoDebpF3dpOf5TA16DdEvGeKyvpTF8rQW0Oi8xWJHeNh4j9thfTbtud7lF+hf0P/5 iOaLq7WQJxf8DKVrC3HYwr9nRKD2TX8= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-WHMHyJ2uNlWpz0L2gTd6hg-1; Mon, 12 Jun 2023 03:43:36 -0400 X-MC-Unique: WHMHyJ2uNlWpz0L2gTd6hg-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-39ca3e1728fso1437594b6e.2 for ; Mon, 12 Jun 2023 00:43:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686555815; x=1689147815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jmNfXGbT31jvE6AxGpZVfTL4nrJN/7qC8PW9Aoa9Iyo=; b=LrdUk9sgKreZKGeDZkRd9oeoKcvi03onbjvdym1+NEsCO2LRWwn6yWhekdfVtH+7Th V8pXbn2gYKhqESEYu1492uw5EjgA8iYM5yTpTuUc4wfTIdT2gY/+NS6zBZOLwm4YXty6 EceZ39A+wwaNX0ZNENX2uzGS8xvJQvu6bq9/XNI+gRAurCzlqMj+GeLQEyvo5ux81PTW WwTxygduqw9t3l0FL7+AzKnyU0iDoN13+PPZoaShvfF8Il6XLEHEVueD64YOpNoNiTzk S67hpDy6bFJHyQgt6C+wYcMzHfAayjvA1/Ja3S/853Bvz0sgrKr8Rq5aRNr111xF4kD3 yFHg== X-Gm-Message-State: AC+VfDyUdL1RcWnKrl2eTwM5spv9Xh+frTLf3vAX1wIC8XlWO+w6y81S lwBO/KgSKH/eZjuagABWosOnxoF6IMuO2QGeAnsQmdX2BJ/P2O8hitODYMCB1m5Ccwk9KeGdNxO xS9MXO895xaG9ch2LpTs= X-Received: by 2002:a05:6808:23cf:b0:398:450b:a8ab with SMTP id bq15-20020a05680823cf00b00398450ba8abmr4316939oib.45.1686555815268; Mon, 12 Jun 2023 00:43:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6kaWhcHtOBoXGmPBzL2jjlNHy/6jCanALRL5y4aQEtWRzQLujHC/v7dfJWJQWbGNg+x5tPe0s6EkWQYLKjb7c= X-Received: by 2002:a05:6808:23cf:b0:398:450b:a8ab with SMTP id bq15-20020a05680823cf00b00398450ba8abmr4316934oib.45.1686555814990; Mon, 12 Jun 2023 00:43:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Mon, 12 Jun 2023 09:43:23 +0200 Message-ID: Subject: Re: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd To: Tyler Retzlaff , Qiming Yang , Wenjun Wu Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, (I could not assign this bz to you, please register to bugs.dpdk.org) On Mon, Jun 12, 2023 at 9:29=E2=80=AFAM wrote: > > Bug ID 1249 > Summary [dpdk-23.07] ixgbe port stop failed after launch testpmd > Product DPDK > Version 23.07 > Hardware All > OS All > Status UNCONFIRMED > Severity normal > Priority Normal > Component testpmd > Assignee dev@dpdk.org > Reporter linglix.chen@intel.com > Target Milestone --- > > Environment > OS: Ubuntu 22.04.2 LTS/5.15.0-71-generic > DPDK version: 8a2de735318b38ba93a041cb2f209889bde02689 > Compiler: gcc version 11.3.0 > NIC hardware: 82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb > NIC driver: ixgbe-5.18.11 > NIC firmware: 0x000161bf > > Test Setup > > 1. bind 1 port to vfio-pci > ./usertools/dpdk-devbind.py -b vfio-pci 0000:b1:00.0 > > 2. launch testpmd > x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1-2 -n 4 -- -i > > 3.testpmd>port stop 0 > testpmd> show port info all > > Show the output from the previous commands > testpmd>port stop 0 > Stopping ports... > Checking link statuses... > ixgbe_dev_link_update_share(): Other link thread is running now! > Done > testpmd> show port info all > ixgbe_dev_wait_setup_link_complete(): IXGBE link thread not complete too = long > time! > need kill to quit testpmd. > > Expected Result > port stop normal. > > Regression > Is this issue a regression: (Y/N)Y > > Version the regression was introduced: Specify git id if known. > commit e90baf6b82f66c880c7e7f8f77fc534980165808 > Author: Tyler Retzlaff > Date: Tue Jun 6 14:45:45 2023 -0700 > > net/ixgbe: replace legacy atomics with GCC builtin atomics > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > Acked-by: Morten Br=C3=B8rup I suspect this change broke handling of multiple ports by converting a counter atomic to a simple boolean. Can you have a look? Thanks. --=20 David Marchand