From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77080A052A; Wed, 27 Jan 2021 09:23:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7A3E140D0E; Wed, 27 Jan 2021 09:23:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id DE80C140D0A for ; Wed, 27 Jan 2021 09:23:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611735801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AU/Pd0OqiZPJHuB8hLR331b+THwLAgQ3c49SQBdBMOs=; b=Ks9Pm28xeuIXDlzfk+Frh8N6MLtUG5L4+R88hx8tB36hYUWcnqXF/srfwLC2mIYKoJiFAx 4kfhBCg2ogewqdKydbJ2luUx4NCe9Rvh7KrS7LQEb5ml6pL4QO8YXpo7vv5WZ7mxqWAkD2 qjVa3LFS8+LzXfLgUfGTxy/xhUHFSxs= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-yJFlZi3MOsWgJTPgyF-Q4A-1; Wed, 27 Jan 2021 03:23:19 -0500 X-MC-Unique: yJFlZi3MOsWgJTPgyF-Q4A-1 Received: by mail-ua1-f71.google.com with SMTP id o24so378239uap.15 for ; Wed, 27 Jan 2021 00:23:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AU/Pd0OqiZPJHuB8hLR331b+THwLAgQ3c49SQBdBMOs=; b=VbudAr9GYuYTCbKZXaOZ+AL9BWDDF+Z2TXX2JMjJnPkvI5CVQvKM6soGByXNE9LjXV yydr5cT7kWnoic+cQNnsqtFkY/a0dcHpMKnczXpvBLE2uxQGr/QKajRm8qgCGO3dE5ug r3wbRSIz+CkW2KaqIwHVowkFo6KUW7p/uNG9yCU+HrWLDaqykNsB8MJttI+Db3jZEcpM SZPIwiO/u11HMeq4lGOmq46Bw0io5jjuSbrqw+22ElERFPbCeoajSJ39yEfORRj186VH TN+lbzeD6diHz5GivHxzd83hnGXGhOmPiy3LNCR5z/JmjwweTxKu3aZNI59W/P2tFkyU Om1A== X-Gm-Message-State: AOAM530TvyvnWbvb7qwOgQIK1DMJDTmOl8vcOn9sJ1NfpwNdt8oz7l5d wWHChyILpqe4FgTKrAYcnTrdjS+ImzYRZqbadm61UIdBZoC6l2wiqvGuBYsdVJCAaaefJwy8BMP gMNx1G28k+PVgV0nszhY= X-Received: by 2002:a05:6102:21cd:: with SMTP id r13mr7433091vsg.5.1611735798818; Wed, 27 Jan 2021 00:23:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXynyIHpGuyv8+p0vv1Fqj7mxz6XwP2t1b+6LKAM7fw8c1Mw2tMZY5mpmfrS9W2DY6NZsuET8drG0zwpgBppA= X-Received: by 2002:a05:6102:21cd:: with SMTP id r13mr7433087vsg.5.1611735798556; Wed, 27 Jan 2021 00:23:18 -0800 (PST) MIME-Version: 1.0 References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <20210126101639.250481-3-maxime.coquelin@redhat.com> In-Reply-To: <20210126101639.250481-3-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 27 Jan 2021 09:23:07 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin wrote: > > This patch adds driver flag in vdev bus driver so that > vdev drivers can require VA IOVA mode to be used, which > for example the case of Virtio-user PMD. > > The patch implements the .get_iommu_class() callback, that > is called before devices probing to determine the IOVA mode > to be used, and adds a check right before the device is > probed to ensure compatible IOVA mode has been selected. > > It also adds a ABI exception rule to accommodate with an > update on the driver registration API > > Signed-off-by: Maxime Coquelin > Signed-off-by: David Marchand I only suggested some changes. This patch looks good to me. Can you change this Sob as a Acked-by? Thanks Maxime. -- David Marchand