From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by dpdk.org (Postfix) with ESMTP id 745E52BA3 for ; Mon, 4 Mar 2019 10:40:45 +0100 (CET) Received: by mail-ua1-f49.google.com with SMTP id u1so3802709uae.12 for ; Mon, 04 Mar 2019 01:40:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HuOUIS45UZ7ANLrzmiWjYhXH70xhA/c2R8XtHE17YBc=; b=X07gPUVCjdAwXOZlRPvTAAtSKQqDyYfp9UZULBtKR+3GtrxOMzF9+jdiYpZ8SgcoqG wHZMhkYcHMUJ45HomvdS78XqrjzUycEDFvcfbBOywDTt97RffSsr5rZJwC17Z8GjPTsk Pqn2NdoTtjVhP7jWoATLBvEUHNgSv77HjClZ5NRosj2LarO+9zqCU8+U5LzLugeccpsj UA2rb18SxkprjAO3M32KwsBuuYPheXNys/bkxRRkgSBodfgOipu2lbR2EYyB37ZBHv3e jkTK3k9DkncthYXaWL4gZ0e9E777c5+W7UyVcGoAwXB7m6oVp/AmwT+EaQMYfkUX81lt H9hw== X-Gm-Message-State: APjAAAVT3xYoOxgdwOVIt+3cDCsEOWDKZWLjF38eWYslN5iNXSxnkhQy i/WH0sIeyflWZtvnfxl4JSN9sgcQ5RpK1rx9fpG+IA== X-Google-Smtp-Source: APXvYqwN2jQTE9Fynp5h6U56EcBbkAuU53QxbEb7L20QHkB22mqSVkp42qa/4Zg18vKwrOFFOIY/pM4YEwBeYBXH9xw= X-Received: by 2002:a67:ef90:: with SMTP id r16mr9131576vsp.141.1551692444620; Mon, 04 Mar 2019 01:40:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Mon, 4 Mar 2019 10:40:33 +0100 Message-ID: To: Igor Russkikh Cc: "dev@dpdk.org" , Pavel Belous Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 09:40:45 -0000 On Sat, Mar 2, 2019 at 1:10 PM Igor Russkikh wrote: > The patchset mainly fixes some Coverity issues, > couple of minor bugs and overflows. > > It also improves eeprom get/set logic with ability of custom > device address and dump length. > > Igor Russkikh (7): > net/atlantic: Fix negative error codes > net/atlantic: remove unused variable > net/atlantic: check for error codes > net/atlantic: fix link configuration > net/atlantic: eliminate excessive log levels on rx/tx > net/atlantic: fix missing vlan filter offload > net/atlantic: fix xstats to return correct number of requested items > > Pavel Belous (3): > net/atlantic: fix buffer overflow > net/atlantic: use eeprom magic as a device address > net/atlantic: fix eeprom fetching for small and uneven lengths > > drivers/net/atlantic/atl_ethdev.c | 71 ++++++++++--------- > drivers/net/atlantic/atl_rxtx.c | 20 ++---- > drivers/net/atlantic/atl_types.h | 5 +- > drivers/net/atlantic/hw_atl/hw_atl_b0.c | 6 +- > drivers/net/atlantic/hw_atl/hw_atl_utils.c | 9 +-- > drivers/net/atlantic/hw_atl/hw_atl_utils.h | 23 +++--- > .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 59 ++++++++++----- > 7 files changed, 105 insertions(+), 88 deletions(-) > Those patches are missing Fixes: tags and copying stable where appropriate. The commitlogs also need some work. It looks like those patches were neither checked against checkpatch nor check-git-log.sh. Here is what I see (extended the max line length to 100 to avoid all those 80 columns warnings, but this is worth fixing as well). [dmarchan@dmarchan dpdk]$ DPDK_CHECKPATCH_LINE_LENGTH=100 ./devtools/checkpatches.sh ### net/atlantic: Fix negative error codes WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 14 lines checked ### net/atlantic: use eeprom magic as a device address WARNING:LONG_LINE: line over 100 characters #163: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:134: + u32 val = rate_mask | ((BIT(CAPS_LO_SMBUS_READ) | BIT(CAPS_LO_SMBUS_WRITE) | BIT(CAPS_LO_MACSEC)) & reg_val); total: 0 errors, 1 warnings, 0 checks, 194 lines checked ### net/atlantic: fix eeprom fetching for small and uneven lengths WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #46: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:558: + rte_memcpy((u8*)data + len - bytes_remains, &val, bytes_remains); total: 1 errors, 1 warnings, 0 checks, 36 lines checked ### net/atlantic: fix missing vlan filter offload WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 9 lines checked ### net/atlantic: fix xstats to return correct number of requested items WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 16 lines checked 5/10 valid patches [dmarchan@dmarchan dpdk]$ ./devtools/check-git-log.sh Wrong headline uppercase: net/atlantic: Fix negative error codes Wrong headline lowercase: net/atlantic: use eeprom magic as a device address net/atlantic: fix eeprom fetching for small and uneven lengths net/atlantic: eliminate excessive log levels on rx/tx net/atlantic: fix missing vlan filter offload Headline too long: net/atlantic: fix eeprom fetching for small and uneven lengths net/atlantic: fix xstats to return correct number of requested items Missing 'Fixes' tag: net/atlantic: Fix negative error codes net/atlantic: fix buffer overflow net/atlantic: fix eeprom fetching for small and uneven lengths net/atlantic: fix link configuration net/atlantic: fix missing vlan filter offload net/atlantic: fix xstats to return correct number of requested items -- David Marchand