From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9294FA055F; Thu, 20 Oct 2022 13:52:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98CA042D7A; Thu, 20 Oct 2022 13:52:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1023242D77 for ; Thu, 20 Oct 2022 13:52:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666266728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jT0SJK/xiaoKXSMEv5sAqy3hHSGThblALkN/ShYZ9FA=; b=HOSHSCQ8SkjcMzHtPKMt3Fnk5dIxbmjdC8VlHRI1sYqmopQtL1RiV6QTO9DeJQZ5hiot+e II75T+zcOb7NUCToUq9UHLbS+OngakxTGxRjGEJeQ+J1xIRgMjhjkV3vldl05v05G9YgmN CBw2D7u9A8W7iMbDpUmjWw9cpdX90TE= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-46-yVxEJEt2NgWzH1XCDSJgBw-1; Thu, 20 Oct 2022 07:52:07 -0400 X-MC-Unique: yVxEJEt2NgWzH1XCDSJgBw-1 Received: by mail-pf1-f198.google.com with SMTP id v1-20020aa78081000000b005636d8a1947so10938875pff.0 for ; Thu, 20 Oct 2022 04:52:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jT0SJK/xiaoKXSMEv5sAqy3hHSGThblALkN/ShYZ9FA=; b=IEZVe1Kk7kPL+980kI/iGqUBKGABeUztAfphCoJEfr/V+W2NesoMviIdUNl9IdjIdw n6LSN/s77az1mXXIQPPz2moFqoxD+B2AK2ZAdlkcDrNMrLoRRF4rFlFqng327IR1jhQk ozGrFE9lneT2bqlEBrM6+jvjjD8+pk8/z3idZZjhVKmjNKcwxItvkm63TXl9Jx638LXJ c5PAZWNRR4dX8IbsMj5Q3pMPo/qVdm7+sof+24Jg7x3Z9x7AO6PxD+Ju4LhDQ2P4Cazm 6wv2sqKCSUhBx8ND+1TuqWd3nA9sxa0x/o9/kqX5oAYGO/6LP+bDSik8n48WvPUA30np srTg== X-Gm-Message-State: ACrzQf27GZeLoXsk8UamoiV9VR84utDF0Dy/BtbTLL3vvO54qgOPhTsU daz4x5FMC3xyVuHBuhpB7AOQJtl8jwoQ62ehAjus1yEwuxrkIubjN6wFNMgq3e+wSSdkBX8gG6e 5sXko8xGgpn0jMKzjNcg= X-Received: by 2002:a05:6a00:4c84:b0:562:ed08:599a with SMTP id eb4-20020a056a004c8400b00562ed08599amr13757391pfb.64.1666266726577; Thu, 20 Oct 2022 04:52:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6KgTjMCoulNw0BTJCosY/ELOApu5n1SqiblXWU4ppKXoIXggmJlr7845Ec1XvEH6TzemEidiMrIP7tAfFAkPE= X-Received: by 2002:a05:6a00:4c84:b0:562:ed08:599a with SMTP id eb4-20020a056a004c8400b00562ed08599amr13757371pfb.64.1666266726335; Thu, 20 Oct 2022 04:52:06 -0700 (PDT) MIME-Version: 1.0 References: <20220921120359.2201131-1-david.marchand@redhat.com> <20221018132654.3760561-1-david.marchand@redhat.com> In-Reply-To: <20221018132654.3760561-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 20 Oct 2022 13:51:55 +0200 Message-ID: Subject: Re: [PATCH v4 00/11] Trace subsystem fixes and more To: dev@dpdk.org Cc: jerinj@marvell.com, skori@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 18, 2022 at 3:27 PM David Marchand wrote: > > Hello, > > This series addresses a number of issues and limitations I have > identified over time in the trace subsystem. > > The main issue was with dynamically enabling trace points which was not > working if no trace point had been enabled at rte_eal_init() time. > > This is 22.11 material. > > We may start thinking about marking this API stable, but this is another > topic. > > > -- > David Marchand > > Changes since v3: > - added one more change for creating new trace directory on call to > rte_trace_save(), > - added the telemetry commands patch in the series, Adding those two patches in the v3 revision was not a good idea. There is more work needed for them, so those changes for telemetry support will be sent separately in a dedicated series. I applied the fixes (up to patch 9) for which we have acks from maintainers. Thanks for the reviews. -- David Marchand