From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31F8EA0579; Thu, 8 Apr 2021 18:41:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A73F614114C; Thu, 8 Apr 2021 18:41:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1C3CC4068B for ; Thu, 8 Apr 2021 18:41:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617900090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nspLwa2yssqRClisbio0jmru7BEhj1IRLnFUeQG+/qE=; b=W5qM616q4IHy3wYe+H7uPdliOCR1T/O9xtkp+eOTntg0ErQ04V0ErnKSzJEZpn/RbjZVwm plrmcWpqrXs5glbXcMu8ghjK01UHjfZtf4cJ7C9x5qd1zETHjNgBmMjMZmitZyWeFCNSOP m/gZPz5z+5f7Vk+NlnjCg5upMtNP2bE= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-Dyak2klVMTylpeLCWDiUrA-1; Thu, 08 Apr 2021 12:41:26 -0400 X-MC-Unique: Dyak2klVMTylpeLCWDiUrA-1 Received: by mail-vs1-f70.google.com with SMTP id r185so384562vsr.0 for ; Thu, 08 Apr 2021 09:41:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nspLwa2yssqRClisbio0jmru7BEhj1IRLnFUeQG+/qE=; b=GMTKErSge13OAW5nXi4OcQeWZA/debFxL8Hzu2DIKXQddVPvC6rAyv9Knki0S3aKEY kZYgs4xAEeVAFxn9Xwr3x4rjhsbE4kKRpH9mXhpiRgEB7Z3IgS8UZvAQBfFKtUNYZxG4 1AAv0Z8EONkj18fTNoBK7tw9DvQBEeCP+5XlDV8sbPr0S6pwofuVxiW2m3ykifWGCK3N NL+JEFUu+V48JGNkjgIsDMp10E+TXNyWqKDvPI5/wMCpQVLdXrwjqCINvvFxV+K8A2YP 4jHX8qackGeAy8uH58jO+COeARsjAywHmvRnqvTEJBw9yEgHdC4el7gOh+Vjfqu02Auq 2nfw== X-Gm-Message-State: AOAM530jJG2AISb6dUpdl2OfkIxveYK7sz8pw/8Lupaq0MSM6mJ6pRpC BSVsHVmkHvCqDJuxv7/EpW0oQy7lZnA/uNpDev8PBHe9kFIng2WlTuoEnbdvw+ZW6Qf3mDYjEjw BzFGV4a+Q9tVLCNMOAvA= X-Received: by 2002:a05:6102:a84:: with SMTP id n4mr7318803vsg.18.1617900085941; Thu, 08 Apr 2021 09:41:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwgNFvSBXOFJLeKeZHEKOtIHoA2liLqcvD8dtkEXeuYRsTAReBK4M0uogswwQtk1dnRqkmcTBPNE65THxJVeY= X-Received: by 2002:a05:6102:a84:: with SMTP id n4mr7318775vsg.18.1617900085709; Thu, 08 Apr 2021 09:41:25 -0700 (PDT) MIME-Version: 1.0 References: <20210406092545.24465-1-david.marchand@redhat.com> <20210406101838.GA551@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210406101838.GA551@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 8 Apr 2021 18:41:14 +0200 Message-ID: To: dev Cc: Ciara Power , Bruce Richardson , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 6, 2021 at 12:18 PM Bruce Richardson wrote: > > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetry: use log function from pointer") > > > > Signed-off-by: David Marchand > > --- > Acked-by: Bruce Richardson > Applied, thanks. -- David Marchand