From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69DCD45B13; Fri, 11 Oct 2024 17:18:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4648E4028B; Fri, 11 Oct 2024 17:18:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8DFC44025F for <dev@dpdk.org>; Fri, 11 Oct 2024 17:18:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728659900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dlGqW1InJ2WjcBTX5D040UQ/AzaiSpVCyWUJIBmZaW8=; b=WdQCl8wNjEXEGQ5bcoqWy8hfcjI1K2pcPEWs3f2JgU/3ZFe8K5nu7f6kyoGef6gkKO8334 IAMlfJ32TgPMvLqRjfzX0IxSHQcnCH9Q831qcnBF0E4k5h0gJ2wBpbtBg0Obq6cUuANi+e DW3ZG6T7n+Ks+Sx861L8uKmATfUvUHQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-Ot-XSR7ROxS9JMIKWyv22Q-1; Fri, 11 Oct 2024 11:18:18 -0400 X-MC-Unique: Ot-XSR7ROxS9JMIKWyv22Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53995187384so2238352e87.2 for <dev@dpdk.org>; Fri, 11 Oct 2024 08:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728659897; x=1729264697; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlGqW1InJ2WjcBTX5D040UQ/AzaiSpVCyWUJIBmZaW8=; b=GJ75DDRwb4nX4zufAv7v8TrfTFUQLiLVihhuHjwwYRJKFpJCtFh0juIrX/uriXWBns ZaCE5WtjmP9iO2LMV9ym2aUBF0Uw86VcCrWthp9T4ZwGLehuPvuZRJP/JuAT0Vv+XGmv UG5OWsOXOIYmix86t+EqoqhTdVK48ex6t9IXLQakMtvmJB+DPKxVoSkaJiTtmKEiv50C 0r1WYEHlQpZ6409gHUebu4p289kH4j63p1PGLiZtbk9tYrV4jCwUPKyduZb8eoF1h2zT yDBINsM+bkbnwZiQ/MojM9c+l/WZTfsdiQxRUs4SZTVIjiwrpv5B7tA7MT+U6Eh6wUAE QyfQ== X-Forwarded-Encrypted: i=1; AJvYcCUts96JvP3ew+SQ/Ti+GiAT0lwo7JyujeOD7DywokLmNiCukpEumTBNI/pYh+oUowrBBto=@dpdk.org X-Gm-Message-State: AOJu0YyGla8xVyylK6jroymL0nETQJchgUQoOqbEZL21eHzAjCOUXkN9 5DDAziFtF6jGY7WkrjNYfvhOBYIdGs/QIkC7S5W8hRBWjyfeQAYS886vRasKQ0umyuoZ78lcoE6 MQ7/eUmYz+3a08cHkqtpchhBcdDStH5RbTereeVUiJqGD98B+594QgXOAKWfocHKkidA9i90rmy pm1aHgE91+PG650Mo= X-Received: by 2002:ac2:4c43:0:b0:536:7cfb:6998 with SMTP id 2adb3069b0e04-539da4e1f18mr1951194e87.35.1728659897305; Fri, 11 Oct 2024 08:18:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6qkauKPLX1r5Otm/3DmxzltNGigh5FB5wkVolHkYgGzzO89Opyusi+0rxWKnlGMApkJwT5IhPKGcb2bxWlp4= X-Received: by 2002:ac2:4c43:0:b0:536:7cfb:6998 with SMTP id 2adb3069b0e04-539da4e1f18mr1951160e87.35.1728659896845; Fri, 11 Oct 2024 08:18:16 -0700 (PDT) MIME-Version: 1.0 References: <20240920062437.738706-2-mattias.ronnblom@ericsson.com> <20240920104754.739033-1-mattias.ronnblom@ericsson.com> <20240920104754.739033-7-mattias.ronnblom@ericsson.com> <CAJFAV8yAxL2VLeFS2yaq-+8NdFB6PpvT9OGViw1xRazQuJ0nfg@mail.gmail.com> <98CBD80474FA8B44BF855DF32C47DC35E9F7C1@smartserver.smartshare.dk> <CAJFAV8yDnD9UraEi2==KDq4CLRoUeoOy9sKUe-gKi7cCOeG9XA@mail.gmail.com> <98CBD80474FA8B44BF855DF32C47DC35E9F7C3@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F7C3@smartserver.smartshare.dk> From: David Marchand <david.marchand@redhat.com> Date: Fri, 11 Oct 2024 17:18:05 +0200 Message-ID: <CAJFAV8ypSd8n2QTa0rBnyn363b2rX6gO570+H-nc=U=xPjrczg@mail.gmail.com> Subject: Re: [PATCH v12 6/7] eal: add unit tests for atomic bit access functions To: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com> Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, dev@dpdk.org, hofors@lysator.liu.se, Heng Wang <heng.wang@ericsson.com>, Stephen Hemminger <stephen@networkplumber.org>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Jack Bond-Preston <jack.bond-preston@foss.arm.com>, Chengwen Feng <fengchengwen@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Oct 11, 2024 at 5:16=E2=80=AFPM Morten Br=C3=B8rup <mb@smartsharesy= stems.com> wrote: > > > > The Coverity report [1] just gave me an idea: > > > > > > worker_lcore_id =3D rte_get_next_lcore(-1, 1, 0); > > > + TEST_ASSERT(worker_lcore_id < RTE_MAX_LCORE, "Worker thread > > allocation failed"); > > > > > > Or even better: > > > Improve rte_eal_remote_launch() by checking the validity of the > > worker_id parameter. > > > > > > [1]: https://scan4.scan.coverity.com/#/project- > > view/60887/10075?selectedIssue=3D445384 > > > > > > > I have the same fix in my workdir, I was about to send, but if you > > want to do it, go ahead. > > No, I only had the idea, didn't actually work on it. > > Please send your fix. Yes, let's ask the maintainer to do the job. Ok, I'll see later. --=20 David Marchand