DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
	 Aaron Conole <aconole@redhat.com>,
	hannes@stressinduktion.org
Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit
Date: Sat, 26 Oct 2019 16:33:20 +0200	[thread overview]
Message-ID: <CAJFAV8yppn40yEumbA7-WPPgc45m9t8DK4E+kzeFQdQ0U+Cbtw@mail.gmail.com> (raw)
In-Reply-To: <20190903191645.1700-1-pbhagavatula@marvell.com>

On Tue, Sep 3, 2019 at 9:17 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix off by one error in 64bit reciprocal division when divisor is 32bit.

Added log from unit test:

    RTE>>reciprocal_division
    Validating unsigned 32bit division.
    Validating unsigned 64bit division.
    Validating unsigned 64bit division with 32bit divisor.
    Division failed, 16983222950483802557/819 = expected 20736535959076681
    result 20736535959076682
    Validating division by power of 2.
    Test Failed

>
> Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Please continue working on enhancing the functional test so that it
can be part of the standard unit test list.
Thanks.


-- 
David Marchand

  parent reply	other threads:[~2019-10-26 14:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 19:16 pbhagavatula
2019-10-15  8:45 ` David Marchand
2019-10-15  8:56   ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-10-15  9:06     ` David Marchand
2019-10-26 14:33 ` David Marchand [this message]
2019-10-23  8:44 [dpdk-dev] " Pavan Nikhilesh Bhagavatula
2019-10-23 14:06 ` Aaron Conole
2019-10-23 15:06 Pavan Nikhilesh Bhagavatula
2019-10-23 15:16 ` Aaron Conole
2019-10-23 15:35 Pavan Nikhilesh Bhagavatula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8yppn40yEumbA7-WPPgc45m9t8DK4E+kzeFQdQ0U+Cbtw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hannes@stressinduktion.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).