From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1437B42D80; Wed, 28 Jun 2023 14:10:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98CED40151; Wed, 28 Jun 2023 14:10:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8C490400EF for ; Wed, 28 Jun 2023 14:10:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687954216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UM4n9ffKivITsG1KTi/NZHezVB3ZuRKcw7z8nQxhPA0=; b=PYut6QINQtddwAlJ2dPXX+NqX5RYs6DR74pgT8vwdJ6LqCnNCyu0slHuoDh8rG2XvsRCmu JnFbbGib/PSWKP1Hk4ptvegenIPbhTsekHt7Fs7YSOn3tK/6ciuePOUDDgQVHPJHh9Ii/p 0830iwt/aSSav+LP00/rUcEkYWVcLtQ= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-Ig274i0NNie06RAVzKU9yg-1; Wed, 28 Jun 2023 08:10:14 -0400 X-MC-Unique: Ig274i0NNie06RAVzKU9yg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-262e7132c74so1930784a91.0 for ; Wed, 28 Jun 2023 05:10:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687954213; x=1690546213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UM4n9ffKivITsG1KTi/NZHezVB3ZuRKcw7z8nQxhPA0=; b=AwX6mqVx5u8+NgA+ShBEB4SpNT3YIHdb/C/7OiDe5wtVt5r6ApoXTD9sOr6/YKuDhi 5ygXL04SLmhSOkohhIvnHK64yuXEWBGL6cW+hyLbg4uS09lulCBq2ozHr8W3XCCTKQXo EONtabGdpBLc2RYlCPyMRoXybH/kpV1FulMKHu/hcNDzEPdEriEeF790Mwfb+qc+XoWt 4z2hDinbOEIStq7naQo3kyw9tq/DL7F3oSPTvPVp8y/ENuC4Lsznt2hoWctKxh4XXW2Q I+9QFJtpZZSxKSFmlbz35QCAAQLfFnxcTHNHfI7MpCfkZcme7zG8s9ioXscD5NquJuLv KKzg== X-Gm-Message-State: AC+VfDxB+Zcq3HjrNow+c2nCn7vQ/J9uGORXKM/Z/lRd+bJYSLXI5ku0 wzsjFXNhsZ/GefJn1bjSqg21B7pgCJvsnWPfOipy9kdzfofrRPflOecEYy5dAhC73EyFQr88AC+ XYhppZxpKovT0cnYCdik= X-Received: by 2002:a17:90a:f09:b0:263:1213:df3b with SMTP id 9-20020a17090a0f0900b002631213df3bmr3841908pjy.11.1687954213638; Wed, 28 Jun 2023 05:10:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7H1iFcLJyzsAUvOVu1M/DYTx6vWpzOidWfPxwEIhCpHdW+s9O40KDCVFOSDY/VCYyVL9NqbkmcXskZ7dCt01g= X-Received: by 2002:a17:90a:f09:b0:263:1213:df3b with SMTP id 9-20020a17090a0f0900b002631213df3bmr3841888pjy.11.1687954213370; Wed, 28 Jun 2023 05:10:13 -0700 (PDT) MIME-Version: 1.0 References: <20211117112847.7362-6-david.marchand@redhat.com> <20230621170058.2740340-1-david.marchand@redhat.com> <20230621170058.2740340-4-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87A0A@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D87A0B@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87A0B@smartserver.smartshare.dk> From: David Marchand Date: Wed, 28 Jun 2023 14:10:02 +0200 Message-ID: Subject: Re: [PATCH v4 3/4] build: select deprecated libraries To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr, Aaron Conole , Michael Santana X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 23, 2023 at 1:33=E2=80=AFPM Morten Br=C3=B8rup wrote: > > > > > - I don't have a usage for this, but if we go with separating > > > > > deprecated and "normal" optional libs filtering, should I introdu= ce a > > > > > disable_deprecated_libs too? > > > > > > > > > > > > > That would give us *way* to many options. I think for the sake of > > simplicity > > > > we probably are as well to just go with what you are proposing in t= his > > set. > > > > Since we only have two deprecated libraries - and hopefully never m= any > > more - > > > > the benefit of the list for that setting is probably minimal. I'm k= een to > > > > avoid too much complexity if we can manage it. > > > > > > I strongly agree with Bruce about avoiding too many options. Here's a= n idea: > > > > > > How about just having the disable/enable_libs options, and by default= omit > > the deprecated libs. > > > > > > Then, the deprecated libs can be enabled by using the enable_libs opt= ion. > > > > > > > That was the original suggestion and implementation. The trouble is tha= t > > if you specify, for example, -Denable_libs=3Dkni, you have just disable= d > > every other optional library in DPDK, since the enable_libs option swit= ches > > DPDK to "allowlist"-only mode. > > OK. Hmmm.... Perhaps we can accept that, using this argument: > > If you are in a situation where you are using some deprecated libs, you p= robably also know exactly which other optional libs you are using. So you m= ust specify the full list on enable_libs. > > I won't object if anyone disagrees with this idea. I'm only trying to kee= p it simple. :-) - Mixing deprecated and "normal" libraries in a single generic option means that people (who are selecting some optional libraries only atm) could miss when an optional library is deprecated (in the future). On the other hand, if we go with a specialised option for deprecated libs, users will have to explicitly ask for keeping them. I think it is also clearer from a user pov. So I would stick with a separate handling of normal and deprecated libs. - Adding a disable_deprecated_libs option does not make much sense for only two libraries. - For v23.07, I'll announce a change in behavior in the build system wrt deprecated libraries. I'll respin on top of Bruce idea (implementing enable_deprecated_libs as a list) for now. And we can conclude on how to best expose/configure this by v23.11. --=20 David Marchand