From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84BE7A057B; Mon, 30 Mar 2020 16:22:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 206C42C15; Mon, 30 Mar 2020 16:22:34 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id DBB4BFFA for ; Mon, 30 Mar 2020 16:22:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585578152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=STSFtbPh9rNHOyw8GoxmMHgndmsf/E3pA6K7cnFXb0I=; b=TbrczqXkSs5HH5/4CXvHs5ZaFurG8d2n0vR0T8FFTLBrXuYNc0ReAfIhavw/2SYas0iV15 hN4e3sFbs/VffGVze31VHnuAKSnlV/qWKLCR5RHVWvcqlJ1jQ7T2b+OTRvyO8426okPwal yPsOszBp1cXXdtbrfCewFeWDePF0Fsc= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-KYUqZAv3M2uX_vfe_R_Qwg-1; Mon, 30 Mar 2020 10:22:28 -0400 X-MC-Unique: KYUqZAv3M2uX_vfe_R_Qwg-1 Received: by mail-vs1-f71.google.com with SMTP id q26so4169195vsr.6 for ; Mon, 30 Mar 2020 07:22:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x122z9tTjE85FJSNRwI1mJCIc/bsi96G3P1ZrW7+TrA=; b=XVmGHcne1YY5vdlmE03pdUQfaXtVOUmsiebrKyVWap5A9MzYA4fYxAgTtHUI4NS3u+ KrJrZXriRZhba09s+xt1XIk/YCvGegNpEw4Fx7j0yQrYVI57I0kPXtTNQOQQHRs/LgkW y4NyT6rxLHL/YadlWxGBupPh1MecYSGXWqBUJG3lKZzlaFbnQRbdC7RiPf6IDTK7VIf5 8FMESeB39GCBwdz2bANCc3SxfNoQU9CS/UZpWpj/LcBqTCivPbfecP5nD8BiEvA8XY+B PLHZ7m7NqYsUiwwzmCLwp+10YtI36AF7PiIUZExysOtdQAw+uTHB2i0S6+yWFMLuBWkd alcg== X-Gm-Message-State: AGi0PuaVs86m1LdYS3HpsAau5EHQYGOxBYkwST5MnqGddRDp3pa4l6JV POOZVOoBgAxR0egrrqH1/HfmCGRYuvOqz5Ojo8PFJfAE/PaBs9QQgiTb9eHt1Ia9qPOrtalWrTc MSmJlWN3zMr/pYitF8jo= X-Received: by 2002:a1f:5f53:: with SMTP id t80mr7906499vkb.39.1585578148276; Mon, 30 Mar 2020 07:22:28 -0700 (PDT) X-Google-Smtp-Source: APiQypITiokf4HLpUzX+S8fm+eAlMGQGuaTzI9coif/JIpoZs6444Hj3o9kxMaurClK2qRA6fw0cwfDWPXv+NY9PbTc= X-Received: by 2002:a1f:5f53:: with SMTP id t80mr7906469vkb.39.1585578147907; Mon, 30 Mar 2020 07:22:27 -0700 (PDT) MIME-Version: 1.0 References: <20200320001220.150235-1-thomas@monjalon.net> <20200327011540.954014-1-thomas@monjalon.net> In-Reply-To: <20200327011540.954014-1-thomas@monjalon.net> From: David Marchand Date: Mon, 30 Mar 2020 16:22:16 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Stephen Hemminger , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 0/8] eal: reorganize directories layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 27, 2020 at 2:16 AM Thomas Monjalon wrote= : > > Some clean-up is done in EAL sub-directories. > The goal is to make organization easier to understand, > and to prepare moving some files from common to Unix-only place. > > Since the kernel modules are moved to kernel/ directory, > there is no need anymore for the sub-directory eal/ in > linux/, freebsd/ and windows/. > > The EAL API (with doxygen documentation) is moved from > common/include/ to include/, which makes more clear that > it is the global API for all environments and architectures. > Note that the arch-specific and OS-specific include files are not > in this global include directory, but include/generic/ should > cover the doxygen documentation for them. > > The arch-specific directories arm, ppc_64 and x86 in common/arch/ > and in common/include/arch are moved at the same level as the > OS-specific directories, adding an include/ sub-directory. > It makes more clear that EAL is covering a matrix combining OS and arch. > Note that ppc_64 is renamed to ppc. > > These moves offer the opportunity to simplify the make and meson files. > > > This change was proposed to the Technical Board in advance: > http://mails.dpdk.org/archives/dev/2020-January/156732.html I caught an issue on patch 6 that breaks headers installation with meson (caught this by compiling examples against an installed dpdk). This issue is fixed by patch 7. So it is only a matter of fixing compilation when bisecting. I proposed a fix in reply to patch 6, which I intend to squash in when appl= ying. I did not validate all patches individually with make, as I get build errors on missing headers with parallel compilation quite easily. But those errors are transient afaiu: with a clean build directory no probl= em. For the series: Acked-by: David Marchand --=20 David Marchand