From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC3E5A00C3; Fri, 7 Oct 2022 17:49:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E00C042B9C; Fri, 7 Oct 2022 17:49:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0615340DDC for ; Fri, 7 Oct 2022 17:49:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665157785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qYo+oDVDOBAbZzy/IXUZ2aPeLlYS2RprmUMcorylGxU=; b=L/z3SeAS3ouRJSLtdV/loN65w/F6dVTq16PlvFUeLVu2P/X9YtC22wuaMRyI+EVcdb09IS TP85x9mq0UbAG92CJ0o2tu2vygW+cgjdRDhGJAjFRL2VMDNK2ikLulx504OuAHl2lbrr3z fhi1hs9poA+c/fto6aqNa4AHWbtIm4w= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-37-PzFPcEaSPEK_IMVnEsTLfw-1; Fri, 07 Oct 2022 11:49:44 -0400 X-MC-Unique: PzFPcEaSPEK_IMVnEsTLfw-1 Received: by mail-pf1-f199.google.com with SMTP id br14-20020a056a00440e00b00548434985cdso3039304pfb.8 for ; Fri, 07 Oct 2022 08:49:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qYo+oDVDOBAbZzy/IXUZ2aPeLlYS2RprmUMcorylGxU=; b=1v9OTfBBND0/pBHSruJSCtbOK8c6SbRPCgVd/UbVgqK3br0lBE5OFhqOCGF9QdZM7z DFgyhgpS73iChC0Q7WoL4njzkrt5N1261YCnKNWo/XSpZDj2gT497/arsZuYGnGHMumj 1epEz+Gm4ORDIzN1CORAfaz2rqb0emFEyXIR2furBtKQksBXOrRQaU5K9A+aF5WE5EcY U8v2MOtTgwfYTL4QOYLZGReo7fg1XkBQ1ADglkGWu+5z9zgtMlpJs0FcVPrDN6940K9v rw06mCe5sE2CznFE0ePLd7B8jwNEl4gaWFSPjIAflhefosysTgnuk3zu8OQq6KLTbUJM 7m4g== X-Gm-Message-State: ACrzQf3EKgzGKfORtRqQLX1ve8vG9+lQ/8B7eeX09vQNfeNbkTcB2YHm +tMGfMVx1OdJBNuIY/WL9cI0BQ4viRGvboy28KH8oRKM23l/Gd2vMnywT9H+MbBgkQLyboHzeT5 UhOBg4Wc8VzhLqv25/p4= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr17412950pjb.39.1665157783274; Fri, 07 Oct 2022 08:49:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Vn30v5+pGtUUlg406gJmvkGbcIq5coBEUTfLTOT7jDsd0/adVUwpSmwZMAQEzV1EAcgwWaQpNDpOtiZSsq/c= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr17412936pjb.39.1665157782960; Fri, 07 Oct 2022 08:49:42 -0700 (PDT) MIME-Version: 1.0 References: <20220912170747.3128065-1-bruce.richardson@intel.com> <20220912170747.3128065-2-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Fri, 7 Oct 2022 17:49:31 +0200 Message-ID: Subject: Re: [PATCH 1/1] build: increase minimum meson version to 0.53 To: Bruce Richardson Cc: Thomas Monjalon , dev@dpdk.org, Lincoln Lavoie , techboard@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 7, 2022 at 5:34 PM Bruce Richardson wrote: > > On Fri, Oct 07, 2022 at 05:26:05PM +0200, David Marchand wrote: > > On Fri, Oct 7, 2022 at 4:11 PM Bruce Richardson > > wrote: > > > > - We have an issue with mingw cross compilation. > > > > https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186 > > > > > > > > + meson build --werror --cross-file config/x86/cross-mingw > > > > -Dexamples=helloworld -Dplatform=generic --default-library=static > > > > --buildtype=debugoptimized -Dcheck_includes=true > > > > The Meson build system > > > > Version: 0.53.0 > > > > Source dir: /home/runner/work/dpdk/dpdk > > > > Build dir: /home/runner/work/dpdk/dpdk/build > > > > Build type: cross build > > > > Program cat found: YES (/usr/bin/cat) > > > > Project name: DPDK > > > > Project version: 22.11.0-rc0 > > > > C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu > > > > 9.4.0-1ubuntu1~20.04.1) 9.4.0") > > > > C linker for the build machine: gcc GNU ld.bfd 2.34 > > > > > > > > meson.build:4:0: ERROR: Unable to determine dynamic linker > > > > > > > > > > > > - I reproduced locally, it looks like meson is trying to pass some > > > > -fuse-ld option that is not understood. > > > > 4577 write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command > > > > line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n", > > > > 101) = 101 > > > > > > > > > > > > - Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I > > > > pushed a branch in GHA to get a status for other targets. > > > > https://github.com/david-marchand/dpdk/actions/runs/3205007946 > > > > > > > So minimum should be 0.53.1 rather than 0.53 then? > > > > > > > - That's what my test shows. > > Fyi, 0.53.2 works too. > > > As latest point release of 0.53 that is probably better choice. > > > > > - With 0.53, it seems the meaning of the ld variable (in meson config > > file) changed. > > I am unclear though if our current configs still make sense. > > > Do you want more time to examine this, or shall I respin this patch with > 0.53.2 as minimum version? https://github.com/mesonbuild/meson/issues/6442 https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782 I understand that the ld variable meaning has been restored, so nothing to change for us. Please respin to 0.53.2, with a note about this issue for posterity. Thanks. -- David Marchand