Re: [dpdk-dev] [PATCH v3] test/eal: add ut cases for in-memory and single-file-segment

[David Marchand <david.marchand@redhat.com>]

On Thu, Jun 27, 2019 at 3:09 PM Pallantla Poornima <
pallantlax.poornima@intel.com> wrote:

> Added unit test case for eal command line 'in-memory' option
> which will cover below functions.
> get_seg_memfd()
> test_memfd_create()
> pagesz_flags()
>
> Added unit test case for eal command line 'single-file-segments' option
> which will cover resize_hugefile().
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> v3: Removed -c , -n options as suggested
> v2: Removed snprintf as suggested
> ---
>  app/test/test_eal_flags.c | 66 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index 9112c96d0..0d5eef727 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -1010,6 +1010,24 @@ test_file_prefix(void)
>         const char *argv4[] = {prgname, "-c", "1", "-n", "2", "-m",
>                         DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 };
>
> +       /* primary process with inmemory mode */
> +       const char * const argv5[] = {prgname, "-m",
> +               DEFAULT_MEM_SIZE, "--in-memory" };
> +
> +       /* primary process with memtest1 and inmemory mode */
> +       const char * const argv6[] = {prgname, "-m",
> +               DEFAULT_MEM_SIZE, "--in-memory",
> +               "--file-prefix=" memtest1 };
> +
> +       /* primary process with parent file-prefix and inmemory mode */
> +       const char * const argv7[] = {prgname, "-m",
> +               DEFAULT_MEM_SIZE, "--in-memory", "--file-prefix", prefix };
> +
> +       /* primary process with memtest1 and single-file-segments mode */
> +       const char * const argv8[] = {prgname, "-m",
> +               DEFAULT_MEM_SIZE, "--single-file-segments",
> +               "--file-prefix=" memtest1 };
> +
>         /* check if files for current prefix are present */
>         if (process_hugefiles(prefix, HUGEPAGE_CHECK_EXISTS) != 1) {
>                 printf("Error - hugepage files for %s were not
> created!\n", prefix);
> @@ -1130,6 +1148,54 @@ test_file_prefix(void)
>                 return -1;
>         }
>
> +       /* this process will run in in-memory mode, so it should not leave
> any
> +        * hugepage files behind.
> +        */
> +
> +       /* test case to check eal-options with --in-memory mode */
> +       if (launch_proc(argv5) != 0) {
> +               printf("Error - failed to run with in-memory mode\n");
> +               return -1;
> +       }
> +
> +       /*test case to check eal-options with --in-memory mode with
>

missing space.

+        * custom file-prefix.
> +        */
> +       if (launch_proc(argv6) != 0) {
> +               printf("Error - failed to run with in-memory mode\n");
> +               return -1;
> +       }
> +
> +       /* check if hugefiles for memtest1 are present */
> +       if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
> +               printf("Error - hugepage files for %s were created and not
> deleted!\n",
> +                               memtest1);
> +               return -1;
> +       }
> +
> +       /* test case to check eal-options with --in-memory mode with
> +        * parent file-prefix.
> +        */
> +       if (launch_proc(argv7) != 0) {
> +               printf("Error - failed to run with --file-prefix=%s\n",
> prefix);
> +               return -1;
> +       }
> +
> +       /* this process will run in single file mode, so it should not
> leave any
> +        * hugepage files behind.
> +        */
> +       if (launch_proc(argv8) != 0) {
> +               printf("Error - failed to run with single-file-segments
> mode\n");
> +               return -1;
> +       }
> +
> +       /* check if hugefiles for memtest1 are present */
> +       if (process_hugefiles(memtest1, HUGEPAGE_CHECK_EXISTS) != 0) {
> +               printf("Error - hugepage files for %s were not deleted!\n",
> +                               memtest1);
> +               return -1;
> +       }
> +
>         return 0;
>  }
>
> --
> 2.17.2
>
>
There are a couple of inconsistencies between inmemory, in-memory,
--in-memory.
Could you make this consistent?
Then you can add my review tag.

Thanks.

-- 
David Marchand