From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 819CFA00C2; Mon, 26 Sep 2022 11:20:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76CF04113F; Mon, 26 Sep 2022 11:20:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6C35C4069B for ; Mon, 26 Sep 2022 11:20:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664184025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4RasXjIgsfhHrmcVrHRBrllO/plfgkMooAItqZP9pVg=; b=JSq53uWJRmyqYPxekLABVxuNJ2nVyEzGI3HXC8m06Hc2mHQ/syQ5Q2j/85ptJxSF3Jv1tm 6NEd7nxTDOrmMJwcIT7K7Vp814ehP2TLQ1l4s1/YFbAEW4+dUK1+ZKrZYFcxqt/6XbRobJ Uc0O+9qhcuBhKVGr1fFTDSCozskyEV4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-495-Zl7Kw-CNMiiczYtRDjBTuw-1; Mon, 26 Sep 2022 05:20:24 -0400 X-MC-Unique: Zl7Kw-CNMiiczYtRDjBTuw-1 Received: by mail-ed1-f69.google.com with SMTP id t13-20020a056402524d00b00452c6289448so4961643edd.17 for ; Mon, 26 Sep 2022 02:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=4RasXjIgsfhHrmcVrHRBrllO/plfgkMooAItqZP9pVg=; b=gXLbZ6oqMpm8IhGFfkBNUFLIuvOpOtleq92jAElBSO3zqDpX6894KJiwPFHcAFBhSk hR0UKQNeWMaJjEhjmTfAJxIl23AhQqF1ZSYauLfowAsxB1zddo5cSkZ0k3D9fFBZ9kip 5YSlNwojaGsChiDC3KS2hq6hY/2svJuLTljjevXsqhOmc0LVySR+diATjiwGOyfbGEJ1 f2/umeBytQ2jydH2VeYVAd6ZRQaiSj90x1Tf1b0d4uAkiJ0xbg1330vMNUHPEsMvRkVF 9syBIvAevEPdbF8n2diyUHBgCCzwwpIfueYpzM3DWlXSIcUH0iPhu5FBD11y71BqZhwW 1KYA== X-Gm-Message-State: ACrzQf0frVHFqnRcl/jL8//2M47wAHPdsy44+cquQZPIliiU9z2KvZtI hbx4nJG5BN3FDn+kE3kbJyFOI1ze20hFH24hRBvuslHOBcZESYJhxk9ZxI8tCYiTGoESuCgWp4O v1PpRomXdDy2Db/7bkOA= X-Received: by 2002:a05:6402:185:b0:457:1489:d5fc with SMTP id r5-20020a056402018500b004571489d5fcmr8587668edv.168.1664184023425; Mon, 26 Sep 2022 02:20:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5P28nWuq/LPpZ+7+ygnp/p9F9NfosJfR58ymCjxsMuhL8v9NnLV8BzwUiCIgD4b3fYJd9CVJJLxB4X5R7QjtA= X-Received: by 2002:a05:6402:185:b0:457:1489:d5fc with SMTP id r5-20020a056402018500b004571489d5fcmr8587657edv.168.1664184023227; Mon, 26 Sep 2022 02:20:23 -0700 (PDT) MIME-Version: 1.0 References: <20220728094103.137862-1-fidaullah.noonari@emumba.com> <20220728210327.7077be93@sovereign> In-Reply-To: <20220728210327.7077be93@sovereign> From: David Marchand Date: Mon, 26 Sep 2022 11:20:11 +0200 Message-ID: Subject: Re: [PATCH v2] eal: change alloc_sz calculation which may cause unnecessarily allocation To: Fidaullah Noonari Cc: dev@dpdk.org, Dmitry Kozlyuk , "Burakov, Anatoly" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 8:03 PM Dmitry Kozlyuk wrote: > > 2022-07-28 14:41 (UTC+0500), Fidaullah Noonari: > > The amount of memory to allocate from the system for heap expansion > > was calculated in a way that may yield one page more than needed. > > This could hit the allocation limit from the system or EAL. > > The allocation would fail despite enough memory being available. > > > > In response to mail: > > http://inbox.dpdk.org/dev/CAEYuUWCnRZNwxiOHEeTHw0Gy9aFJRLZtvAG9g=smuUvUEMcFXg@mail.gmail.com/ Cc: stable@dpdk.org > > > > Signed-off-by: Fidaullah Noonari > Acked-by: Dmitry Kozlyuk I added a note about the reproducer (for testers) and applied. Thanks! -- David Marchand