From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6470A32A3 for ; Fri, 25 Oct 2019 14:53:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CC451C034; Fri, 25 Oct 2019 14:53:58 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 8550D1C02C for ; Fri, 25 Oct 2019 14:53:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572008036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WSolQkMOz00iXeT9khW4bcWYbvZ5B0hWDrNXvfsw5t4=; b=UmEQ1E4TA/holwV/u6wSxM+DPa3u1pgNFo4UBzhkPccTwdk+iZWXNA+1NDm8SsmVVGIGKI 4w3opWxKuk35u18DrSpjWPgJ8NWwRPAJ+JEK/V/EgCfm+QqmexImoAuLEWqcv1HN3yauOI 0p2joOZZk/efxPaPvdwDHFeFQVvVjrY= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-stWkFuSyMsmNSSClnYppSw-1; Fri, 25 Oct 2019 08:53:54 -0400 Received: by mail-vk1-f199.google.com with SMTP id u64so749217vke.18 for ; Fri, 25 Oct 2019 05:53:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WSolQkMOz00iXeT9khW4bcWYbvZ5B0hWDrNXvfsw5t4=; b=gp/T0xwKSGG4gJ79Hq9+2CXJ4zghqBh9+3MHUpY/zraezi/2QbUi1JO2Hwy8M2w/2U YPwhkD1L+FqpW0jS/1O/BwOnh06Cn0HoIOFMz0O+xvNvLxlmRK429bCJln6oMRSC0ozx /vvrEF9MYbCIlI8GSTa2AcQLbWFZi7SX81z4rlsXu1XNuac+f9xM3RHY+HjT8Ba2DJ05 ZWKapGBGVsp/GQnXUBnVWp6FwpsmR3ASioMHw02Jed3gF+ILiCr9tPecuRNjpvNFmUd5 knNJqH3RlfJVf3DQJSRZP4XkS7DXXbnpHjwkqHkqTmkFgpa5IAQAlHhnSOlQzfXvjZr0 5Ctw== X-Gm-Message-State: APjAAAXxva0MIHw0hW9Y722gabhBmQWyWdHpYNoCRyHtKD5Biv8jrM5C hdx8wg3d1zDGzNRG6ZUbuZIByJl5gNVrYaMVS2UcyvX1U42N/FgyZwLOL908tm5Ao6lMHtd2vPf mOIvEsbraMwvYnsSrTIM= X-Received: by 2002:ab0:304e:: with SMTP id x14mr1519855ual.41.1572008033936; Fri, 25 Oct 2019 05:53:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwt3lLaq3XtvJE1W5rilEGUeuuWO7Aca5PN01+qmvz2w00hvTgYS5P98zwDcmGLBCGdEEtrWsdRCXsr4WGI480= X-Received: by 2002:ab0:304e:: with SMTP id x14mr1519847ual.41.1572008033609; Fri, 25 Oct 2019 05:53:53 -0700 (PDT) MIME-Version: 1.0 References: <20190905145315.19395-1-ferruh.yigit@intel.com> In-Reply-To: <20190905145315.19395-1-ferruh.yigit@intel.com> From: David Marchand Date: Fri, 25 Oct 2019 14:53:42 +0200 Message-ID: To: Ferruh Yigit Cc: dev X-MC-Unique: stWkFuSyMsmNSSClnYppSw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 00/10] fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 5, 2019 at 4:53 PM Ferruh Yigit wrote: > > Issue has been detected by '-fno-common' gcc flag. By default compiler > still can figure out that multiple definition are the same variable and > use same storage for all definitions but this is implementation specific > behaviour and better to fix it. > > Many of the cases below it is nice to have to use 'extern' keyword but > there are some defects in 'virtio, ''dpaa2_sec' & 'test' that multiple > components share same global variable unintentionally. > > Ferruh Yigit (10): > bus/fslmc: fix global variable multiple definitions > net/igb: fix global variable multiple definitions > crypto/null: fix global variable multiple definitions > crypto/octeontx: fix global variable multiple definitions Dropped this patch, in favor of: 98c7b9c97e32 ("crypto/octeontx: fix global log variable definition") > crypto/dpaa2_sec: fix global variable multiple definitions Hit a build issue (sent a separate mail), dropped this patch. > crypto/virtio: fix global variable multiple definitions > compress/octeontx: fix global variable multiple definitions > app/testpmd: fix global variable multiple definitions > app/test-pipeline: fix global variable multiple definitions And as discussed, dropped this patch on test-pipeline as well. > test: fix global variable multiple definitions My tests on master are ok, so going for it. Applied, thanks. -- David Marchand