From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3C7E1A034F;
Thu, 25 Feb 2021 10:11:25 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 67B1F160747;
Thu, 25 Feb 2021 10:11:24 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 7135640692
for <dev@dpdk.org>; Thu, 25 Feb 2021 10:11:23 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1614244282;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=sxSiQJnzRiZKVo/BsJ4v2oFuqcDihMctuMJNwRkiR7U=;
b=Q0stbXKrNy4Y+GktewyDkoYSlwmpQCLA2tL6WrOvQmxyUm7ElCGYGnavt7Py/bDiB6LXQw
JH94p8YUrW+tQRihSU4km/XcnumZGM0Wq2PaWEjcksvVOrh1QQWQfTEmHStnFKNF+y7OR4
XntMfv+gAgx9CU/2zv8kT1KjqJe3lh4=
Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com
[209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-74-yt-rzQC1Ptmtzrl-1IYmaQ-1; Thu, 25 Feb 2021 04:11:18 -0500
X-MC-Unique: yt-rzQC1Ptmtzrl-1IYmaQ-1
Received: by mail-vs1-f69.google.com with SMTP id p27so460875vsj.0
for <dev@dpdk.org>; Thu, 25 Feb 2021 01:11:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc:content-transfer-encoding;
bh=sxSiQJnzRiZKVo/BsJ4v2oFuqcDihMctuMJNwRkiR7U=;
b=aZ3fRi6/etS6AUbrqVidSCq5HZrv/LJ3vHq4PyUokv6czmI2kdEugYIAdIubGujxRY
AQ1fd5tsei4fctEYsP8gBf2vIJsiibQJahX2xlkOZ9CdFrBsMpw/s1Od3KhfLxzvsUJ5
Itjncp9SCDBV/vFPQJdgCCp0G1sfILZ/KAl9Wp5iDe3TWGJ/cw6DLs5lVlLC9rTiadmR
SaTfUIKq+9sy09PG3cPT9KKp/Y8xyXwfDiwAY7kvMOvcidSsxwtTFFofvUK0EYyn5/cX
DD/p3Z4pgI02OKFBrUsR0VpZDL/29dmJatkoJY/3jWWG1rI2EDJMjiFQLh5y37SsU655
iQqg==
X-Gm-Message-State: AOAM531WtBhaoEw/4eP8ulaoq1wF1XkCk6mcfQYnzo8f8GnnrSBrAqBO
iVzsAiqt3uWMl78n8SFbNDtHjdr/vT0acxTyyyBkl2pLYLBDkOLRNMkE20QuIlxwwZMZ3xV1ocS
UtMfdj533mSBKGM+2KKM=
X-Received: by 2002:ab0:3c8b:: with SMTP id a11mr1044301uax.87.1614244276935;
Thu, 25 Feb 2021 01:11:16 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxChWGQUGhcyeKzGPBeOtY2RbpnicxL48+lWLugVUqduO1O9+v4x1BQa5roE9N3VH9c/GG2Ykkz9MdmavzwYAI=
X-Received: by 2002:ab0:3c8b:: with SMTP id a11mr1044288uax.87.1614244276737;
Thu, 25 Feb 2021 01:11:16 -0800 (PST)
MIME-Version: 1.0
References: <20210121172201.22582-1-david.hunt@intel.com>
<20210224145434.3108928-1-ferruh.yigit@intel.com>
In-Reply-To: <20210224145434.3108928-1-ferruh.yigit@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 25 Feb 2021 10:11:05 +0100
Message-ID: <CAJFAV8ysDiVrHK_ev56OvVGA=3ErkCOimTQeBdmbnKZ28dD1Lg@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Hunt <david.hunt@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>, Aaron Conole <aconole@redhat.com>,
=?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] power: remove duplicated symbols from map
file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hello Ferruh,
On Wed, Feb 24, 2021 at 3:55 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote=
:
>
> This is also causing build error, like:
> https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104
>
> Also '@internal' marker removed from doxygen comment, since public API
> should not be internal.
>
> Fixes: 4d3892dcd77b ("power: make channel message functions public")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Aaron Conole <aconole@redhat.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: David Marchand <david.marchand@redhat.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech>
> ---
> lib/librte_power/rte_power_guest_channel.h | 4 ----
> lib/librte_power/version.map | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_powe=
r/rte_power_guest_channel.h
> index ed4fbfdcd38a..7586e9491f11 100644
> --- a/lib/librte_power/rte_power_guest_channel.h
> +++ b/lib/librte_power/rte_power_guest_channel.h
> @@ -119,8 +119,6 @@ struct rte_power_channel_packet_caps_list {
> };
>
> /**
> - * @internal
> - *
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice.
> *
> @@ -141,8 +139,6 @@ int rte_power_guest_channel_send_msg(struct rte_power=
_channel_packet *pkt,
> unsigned int lcore_id);
>
> /**
> - * @internal
> - *
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice.
> *
> diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map
> index 3ba9390241d2..bce5110dd5b4 100644
> --- a/lib/librte_power/version.map
> +++ b/lib/librte_power/version.map
> @@ -12,7 +12,6 @@ DPDK_21 {
> rte_power_get_capabilities;
> rte_power_get_env;
> rte_power_get_freq;
> - rte_power_guest_channel_send_msg;
This symbol was marked stable so far.
Did I miss something?
I would just remove the experimental tagging for this symbol which is
incorrect in v21.02.
Something like:
diff --git a/lib/librte_power/rte_power_guest_channel.h
b/lib/librte_power/rte_power_guest_channel.h
index ed4fbfdcd3..b5de1bd243 100644
--- a/lib/librte_power/rte_power_guest_channel.h
+++ b/lib/librte_power/rte_power_guest_channel.h
@@ -119,11 +119,6 @@ struct rte_power_channel_packet_caps_list {
};
/**
- * @internal
- *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
* Send a message contained in pkt over the Virtio-Serial to the host endp=
oint.
*
* @param pkt
@@ -136,13 +131,10 @@ struct rte_power_channel_packet_caps_list {
* - 0 on success.
* - Negative on error.
*/
-__rte_experimental
int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt,
unsigned int lcore_id);
/**
- * @internal
- *
* @warning
* @b EXPERIMENTAL: this API may change without prior notice.
*
diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map
index 3ba9390241..b004e3e4a9 100644
--- a/lib/librte_power/version.map
+++ b/lib/librte_power/version.map
@@ -38,6 +38,4 @@ EXPERIMENTAL {
# added in 21.02
rte_power_ethdev_pmgmt_queue_disable;
rte_power_ethdev_pmgmt_queue_enable;
- rte_power_guest_channel_receive_msg;
- rte_power_guest_channel_send_msg;
};
Sidenote, we can probably catch these duplicates during build.
For duplicate entries with the same version, this is easy.
I'll see if I can catch the other case too.
--
David Marchand