From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 144ECA00C2; Thu, 6 Oct 2022 10:33:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01B9842BB3; Thu, 6 Oct 2022 10:33:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E09542B98 for ; Thu, 6 Oct 2022 10:33:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665045190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bVJhCT5e2ok+UPspNXSWVtJpbaCUrlR2ziHwVc/4FQg=; b=O0GbPXHVV/eqr60EYqpLiJ37zyraZGJi6MAzBTZwSBuxMZFkYqAiOK5VS2tO6aeBRQoMny zWJ+yRBIYnOZByLN2/l9IoDiAdbHL4hFiZjYiU5wYKZy0bfRra1+YUhb2Do3DQRW8XUbF1 8ksSjly6izwEsiIoIbO7vr+jNQ77w+g= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-301-qBHrnP2fOR6NeXnRnBu26A-1; Thu, 06 Oct 2022 04:33:09 -0400 X-MC-Unique: qBHrnP2fOR6NeXnRnBu26A-1 Received: by mail-pg1-f197.google.com with SMTP id y62-20020a638a41000000b0044a5d5be5b8so790619pgd.13 for ; Thu, 06 Oct 2022 01:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=bVJhCT5e2ok+UPspNXSWVtJpbaCUrlR2ziHwVc/4FQg=; b=NI3Czb1F0ocouBvw9J8G5BUXXYv53xrof+vKNtGsyjA0QrmsWm2W+Zvh90s2RCM/YH wtS7bkQmuakwK3gmFw3jQWfyjw/VF1A6NHm9BTDlPgOtHkDlW0UL+jP+GRGZSQJa6c1p 4OB0HOr9BgqFXoT/ezM6BnAUQUx3JBUyFX1I967jhtkWG4haoyNofYZJHbJLJmFsS3rF DMfifKNId/kQneGtBMYj1TOCtvHiYzUM1WQP0qTacaz6Y2hF8MrOZpaotB8+d9PglCbe INnBfb1R5Do5mkxmLrsOEC/HMne9Vr7lmf8a/TK5IohaqXUgU8g7RhtAwqx2XwHF/vM4 LMdw== X-Gm-Message-State: ACrzQf31xca+I8s6r5m70i3JZxo+TfUbYZdyZogDnMf0F3ycor7q7pqI JnEisQSklTMWbBwl3xy3CUbL2wfSzFsMA9DJXTCFUQQooAIhjh1ibELDnbIjNvaCCTTrBaJOcGX wiy7ERZoumrZiXkEqF68= X-Received: by 2002:a63:2307:0:b0:458:4d0b:a21f with SMTP id j7-20020a632307000000b004584d0ba21fmr3529949pgj.120.1665045188096; Thu, 06 Oct 2022 01:33:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5tAZ3QIDlTX250OtJP0tST6HuOhPPtp0s4rkUPuE3A+I95cKZdg5diL6VV6UY2ZfmHROSHEq0lsTly8a69HgI= X-Received: by 2002:a63:2307:0:b0:458:4d0b:a21f with SMTP id j7-20020a632307000000b004584d0ba21fmr3529932pgj.120.1665045187885; Thu, 06 Oct 2022 01:33:07 -0700 (PDT) MIME-Version: 1.0 References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1664989651-29303-1-git-send-email-roretzla@linux.microsoft.com> <1664989651-29303-5-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1664989651-29303-5-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 6 Oct 2022 10:32:56 +0200 Message-ID: Subject: Re: [PATCH v5 4/6] test/threads: add tests for thread lifetime API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff wrote: > > Test basic functionality and demonstrate use of following thread > lifetime api. > > * rte_thread_create > * rte_thread_detach And, to some extent, rte_thread_equal. > * rte_thread_join > > Signed-off-by: Narcisa Vasile > Signed-off-by: Tyler Retzlaff > --- > app/test/test_threads.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 52 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_threads.c b/app/test/test_threads.c > index b9d8b4e..1077373 100644 > --- a/app/test/test_threads.c > +++ b/app/test/test_threads.c > @@ -14,7 +14,7 @@ > > static uint32_t thread_id_ready; > > -static void * > +static uint32_t > thread_main(void *arg) Stopping at this patch, I still see a build failure. This prototype change makes it uncompatible with remaining calls to pthread_create. This is fixed in patch 6 which I intend to squash here (and adding the check on arg != NULL that is in patch 5). Deal? -- David Marchand