From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5057042C5C; Thu, 8 Jun 2023 10:08:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 422BF4113F; Thu, 8 Jun 2023 10:08:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 91C1140042 for ; Thu, 8 Jun 2023 10:08:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686211720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SEV2WFTARjT/7gwa9y0v28nlnIVKwaIdYhwotMJ3tF4=; b=Ma7P7oYAwRyjarNHq7BlA328zzLYAmJgjuQHHJyrb2XbmLb/H3FvP78QdLVvxGNHkhB0hC NqQiQ1FgU0vXpiw5SpXUuFoJUpSBioGuIDsECsZRUeowzxLGicW6T7+sybx4GC/cMcmObk VlarTXiOqJfFJ/FZ09u1YkWXg6AXls0= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-WZ6k88wrN3y-llnfiTOjKw-1; Thu, 08 Jun 2023 04:08:37 -0400 X-MC-Unique: WZ6k88wrN3y-llnfiTOjKw-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2569298a074so374751a91.1 for ; Thu, 08 Jun 2023 01:08:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686211716; x=1688803716; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SEV2WFTARjT/7gwa9y0v28nlnIVKwaIdYhwotMJ3tF4=; b=L0LzDt4Lna0WFNXzyv4jzid6fxpxWKWdY2WO1HdztdtG5GO4+sJt7UZTTaszcfGZdG yP+AhZowvECKT+kiAZBWQZVSbeUihHQ3+7k1emsnhiUscPDrspB5XB90LsXggczNy/8P sz66e/FmbMbNM0ExBw5y3oDZ6a2a6Mu8CYg24L7ryW/dpzR0eNPk++xHKzeCMUaljdqj r7b/FOWs/7oBp7dfaCCQlFiF4U4L6u+/5K7AWCQYoycc7xMWg1nAbCQpNhSBry77N3Kg weut55dPKKUKap5e2c820BbMnrMo33srEYhSmSn53pLJooJbJMdYfxOI45MP4daV62Pd wKow== X-Gm-Message-State: AC+VfDyWKhzxqQboj9UocAsSZlYiR/g2t95W+Wg3utd7SYncnmH7DlJi GJ1L1FCRyhjlCBRljbyK+OSTxYY8WKqP5dd8emtWzbu/hjItIbN30cMGx35yN0ys9XhvbiNJjpb 075BsCR+WiNhDKZ+4peg= X-Received: by 2002:a17:90a:aa85:b0:259:4199:29d8 with SMTP id l5-20020a17090aaa8500b00259419929d8mr7189824pjq.15.1686211716051; Thu, 08 Jun 2023 01:08:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5OMHM56lhokLl8AH0nrIt1BtrzDmLloAnbnTvICiZiktF/Dpz22zsQHgovFIbUYrBLY0Vhd3uH9BncxVjqn7k= X-Received: by 2002:a17:90a:aa85:b0:259:4199:29d8 with SMTP id l5-20020a17090aaa8500b00259419929d8mr7189811pjq.15.1686211715818; Thu, 08 Jun 2023 01:08:35 -0700 (PDT) MIME-Version: 1.0 References: <20230531065506.63021-1-wangzhihong.wzh@bytedance.com> <20230608072553.72421-1-wangzhihong.wzh@bytedance.com> In-Reply-To: <20230608072553.72421-1-wangzhihong.wzh@bytedance.com> From: David Marchand Date: Thu, 8 Jun 2023 10:08:24 +0200 Message-ID: Subject: Re: [PATCH v2] eal/linux: register mp hotplug callback after memory init To: Zhihong Wang Cc: dev@dpdk.org, anatoly.burakov@intel.com, qi.z.zhang@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 8, 2023 at 9:26=E2=80=AFAM Zhihong Wang wrote: > > Secondary would crash if it tries to handle mp requests before memory > init, since globals such as eth_dev_shared_data_lock are not accessible > to it at this moment. > > Signed-off-by: Zhihong Wang > Acked-by: Anatoly Burakov Forgot to mention that we need a Fixes: tag. I added it and applied, thanks. --=20 David Marchand