From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 099EC45AAF; Fri, 4 Oct 2024 16:01:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4E77410FC; Fri, 4 Oct 2024 16:01:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1DDB040E34 for ; Fri, 4 Oct 2024 16:01:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728050488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHLvZhEgR0Hu73rkOdh86/sXmiqEGJ2zGxaJlCgVwy4=; b=WmygP0h2AO1BENdEgMjh7FaYih88H+uQ1HfkxYn7NyPyCgsnhn6QbZM+ai/p/Rbaj8n/6y u1COlLchNWpJ2gWt8z9kxbtcBA03HJHcvh2T+SuhIFqexGLmg16bzVDTIIvpNDPiFkptx+ HoRIVYWgpYUxuZBqaj3ZSDM/uWKeR/A= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-z7wGVr6-M4e4R_Wu70bFNg-1; Fri, 04 Oct 2024 10:01:27 -0400 X-MC-Unique: z7wGVr6-M4e4R_Wu70bFNg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-53994f50133so2123047e87.1 for ; Fri, 04 Oct 2024 07:01:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728050486; x=1728655286; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mHLvZhEgR0Hu73rkOdh86/sXmiqEGJ2zGxaJlCgVwy4=; b=YtwxGOof28an6POFxZbDyBXHYtGr7UhanWzRjs1iPKM+AQ+ig/SRbl3heO8eQaK7Ug YMEKOUPJaK7MTwICfqkXrVWkLno2FfYGhFuXXUmvg+2Jy9bA08xqPuqCEB1sVgAYBTq6 S53I/So0a9NigC1cblZ5D0oH++SHb3JSKV4NVnpGsGBhHqhEenBL4kmOEC2Ew41aKE1Y +OJ14FGA8yd8X+NnCTkQwuh3x/Au0faXfOYhw68ZBwCOFANoMGxwpv2UjaEKK3Yn8M38 T5HQmVq0OEquDCBtRpeYM4eWiFSMXG8uS5t1iXdp8M2x3v67cJVVC7GRgPv31vquuxIA nk/w== X-Gm-Message-State: AOJu0Yy+e+8G6FCogV8KB5hr6XorWVD6nw2RaHPHkT4RQZYWmrcYQmHe FmJm9xcdU0wQzanNP6MxowGuCPJebEWqbVEdvdniJS2CjoKwMzy/RHGRxxwRjbKEdRHcTo4Yazl SR9uOxwKJnZsBcMtYs48asSFita2WiW+t1X1L2B3x7a6Q/L4ATWPcArvfSQaYwgrsALEV6bMNit xtiGMEw47WWE8d9xM= X-Received: by 2002:a05:6512:3b8e:b0:537:a855:7d6f with SMTP id 2adb3069b0e04-539ab891f52mr1977034e87.34.1728050485595; Fri, 04 Oct 2024 07:01:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtHTH8P/uS3p1d2OOO66LJW9JPKV7YS11jiHIo/YiaL/IIUULoH/cUG6VIoZYMySLIRDsIq+Q1ar/7N6Hzhxk= X-Received: by 2002:a05:6512:3b8e:b0:537:a855:7d6f with SMTP id 2adb3069b0e04-539ab891f52mr1976996e87.34.1728050485071; Fri, 04 Oct 2024 07:01:25 -0700 (PDT) MIME-Version: 1.0 References: <20240930121525.3452847-1-hemant.agrawal@nxp.com> <20241001110325.4173762-1-hemant.agrawal@nxp.com> <20241001110325.4173762-7-hemant.agrawal@nxp.com> In-Reply-To: <20241001110325.4173762-7-hemant.agrawal@nxp.com> From: David Marchand Date: Fri, 4 Oct 2024 16:01:14 +0200 Message-ID: Subject: Re: [PATCH v5 06/18] net/dpaa: support Tx confirmation to enable PTP To: Hemant Agrawal Cc: dev@dpdk.org, ferruh.yigit@amd.com, Vanshika Shukla X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 1:04=E2=80=AFPM Hemant Agrawal wrote: > diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethde= v.c > index 90b34e42f2..bba305cfb1 100644 > --- a/drivers/net/dpaa/dpaa_ethdev.c > +++ b/drivers/net/dpaa/dpaa_ethdev.c [snip] > @@ -2079,6 +2129,14 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) > goto free_rx; > } > > + dpaa_intf->tx_conf_queues =3D rte_zmalloc(NULL, sizeof(struct qma= n_fq) * > + MAX_DPAA_CORES, MAX_CACHELINE); > + if (!dpaa_intf->tx_conf_queues) { > + DPAA_PMD_ERR("Failed to alloc mem for TX conf queues\n"); No need for \n. Please send a fix against next-net. > + ret =3D -ENOMEM; > + goto free_rx; > + } > + --=20 David Marchand