[PATCH 0/2] GitHub Actions configuration fixes

DPDK patches and discussions
 help / color / mirror / Atom feed

* [PATCH 0/2] GitHub Actions configuration fixes
@ 2022-10-12 16:29 David Marchand
  2022-10-12 16:29 ` [PATCH 1/2] ci: bump versions of actions in GHA David Marchand
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: David Marchand @ 2022-10-12 16:29 UTC (permalink / raw)
  To: dev

GitHub Actions started to deprecated some part of the workflow syntax
and dependencies of some core actions.

This series (mostly) fix those warnings.
For reviewers/testers, this is still moving: I got new warnings while
I was testing the first patch...


-- 
David Marchand

David Marchand (2):
  ci: bump versions of actions in GHA
  ci: update to new API for step outputs in GHA

 .github/workflows/build.yml | 41 +++++++++++++++----------------------
 1 file changed, 17 insertions(+), 24 deletions(-)

-- 
2.37.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ci: bump versions of actions in GHA
  2022-10-12 16:29 [PATCH 0/2] GitHub Actions configuration fixes David Marchand
@ 2022-10-12 16:29 ` David Marchand
  2022-10-12 16:29 ` [PATCH 2/2] ci: update to new API for step outputs " David Marchand
  2022-11-14 10:44 ` [PATCH 0/2] GitHub Actions configuration fixes David Marchand
  2 siblings, 0 replies; 7+ messages in thread
From: David Marchand @ 2022-10-12 16:29 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

GitHub started deprecating GHA actions based on Node 12 [1].
For now, only warnings are raised, but we might as well switch to v3
versions of the common actions, now.

1: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index bf17d2b278..187fdef306 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -82,7 +82,7 @@ jobs:
 
     steps:
     - name: Checkout sources
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Generate cache keys
       id: get_ref_keys
       run: |
@@ -93,7 +93,7 @@ jobs:
         echo -n '::set-output name=abi::'
         echo 'abi-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-${{ env.LIBABIGAIL_VERSION }}-${{ env.REF_GIT_TAG }}'
     - name: Retrieve ccache cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/.ccache
         key: ${{ steps.get_ref_keys.outputs.ccache }}-${{ github.ref }}
@@ -101,13 +101,13 @@ jobs:
           ${{ steps.get_ref_keys.outputs.ccache }}-refs/heads/main
     - name: Retrieve libabigail cache
       id: libabigail-cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       if: env.ABI_CHECKS == 'true'
       with:
         path: libabigail
         key: ${{ steps.get_ref_keys.outputs.libabigail }}
     - name: Retrieve ABI reference cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       if: env.ABI_CHECKS == 'true'
       with:
         path: reference
@@ -154,7 +154,7 @@ jobs:
       run: .ci/linux-build.sh
     - name: Upload logs on failure
       if: failure()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: meson-logs-${{ join(matrix.config.*, '-') }}
         path: |
@@ -181,7 +181,7 @@ jobs:
         echo 'image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d)
     - name: Retrieve image cache
       id: image_cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/.image
         key: ${{ steps.get_keys.outputs.image }}
@@ -235,7 +235,7 @@ jobs:
 
     steps:
     - name: Checkout sources
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Generate various keys
       id: get_keys
       run: |
@@ -247,7 +247,7 @@ jobs:
         echo 'meson-logs-${{ join(matrix.config.*, '-') }}' | tr -d ':'
     - name: Retrieve image cache
       id: image_cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/.image
         key: ${{ steps.get_keys.outputs.image }}
@@ -257,7 +257,7 @@ jobs:
         echo 'Image ${{ matrix.config.image }} is not cached.'
         false
     - name: Retrieve ccache cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/.ccache
         key: ${{ steps.get_keys.outputs.ccache }}-${{ github.ref }}
@@ -294,7 +294,7 @@ jobs:
       run: docker kill dpdk
     - name: Upload logs on failure
       if: failure()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: ${{ steps.get_keys.outputs.logs }}
         path: |
-- 
2.37.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ci: update to new API for step outputs in GHA
  2022-10-12 16:29 [PATCH 0/2] GitHub Actions configuration fixes David Marchand
  2022-10-12 16:29 ` [PATCH 1/2] ci: bump versions of actions in GHA David Marchand
@ 2022-10-12 16:29 ` David Marchand
  2022-10-12 16:53   ` David Marchand
  2022-11-14 10:44 ` [PATCH 0/2] GitHub Actions configuration fixes David Marchand
  2 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2022-10-12 16:29 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

GitHub actions deprecated use of set-output, replaced with
GITHUB_OUTPUT.

Note: we still have some warnings, as of today, because of
actions/cache@v3 which did not migrate yet.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 187fdef306..b32758ff6f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -86,12 +86,9 @@ jobs:
     - name: Generate cache keys
       id: get_ref_keys
       run: |
-        echo -n '::set-output name=ccache::'
-        echo 'ccache-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-'$(date -u +%Y-w%W)
-        echo -n '::set-output name=libabigail::'
-        echo 'libabigail-${{ matrix.config.os }}'
-        echo -n '::set-output name=abi::'
-        echo 'abi-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-${{ env.LIBABIGAIL_VERSION }}-${{ env.REF_GIT_TAG }}'
+        echo 'ccache=ccache-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-'$(date -u +%Y-w%W) >> $GITHUB_OUTPUT
+        echo 'libabigail=libabigail-${{ matrix.config.os }}' >> $GITHUB_OUTPUT
+        echo 'abi=abi-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-${{ env.LIBABIGAIL_VERSION }}-${{ env.REF_GIT_TAG }}' >> $GITHUB_OUTPUT
     - name: Retrieve ccache cache
       uses: actions/cache@v3
       with:
@@ -177,8 +174,7 @@ jobs:
     - name: Generate various keys
       id: get_keys
       run: |
-        echo -n '::set-output name=image::'
-        echo 'image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d)
+        echo 'image=image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d) >> $GITHUB_OUTPUT
     - name: Retrieve image cache
       id: image_cache
       uses: actions/cache@v3
@@ -239,12 +235,9 @@ jobs:
     - name: Generate various keys
       id: get_keys
       run: |
-        echo -n '::set-output name=ccache::'
-        echo 'ccache-${{ matrix.config.image }}-${{ matrix.config.compiler }}-'$(date -u +%Y-w%W)
-        echo -n '::set-output name=image::'
-        echo 'image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d)
-        echo -n '::set-output name=logs::'
-        echo 'meson-logs-${{ join(matrix.config.*, '-') }}' | tr -d ':'
+        echo 'ccache=ccache-${{ matrix.config.image }}-${{ matrix.config.compiler }}-'$(date -u +%Y-w%W) >> $GITHUB_OUTPUT
+        echo 'image=image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d) >> $GITHUB_OUTPUT
+        echo 'logs=meson-logs-${{ join(matrix.config.*, '-') }}' | tr -d ':' >> $GITHUB_OUTPUT
     - name: Retrieve image cache
       id: image_cache
       uses: actions/cache@v3
-- 
2.37.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ci: update to new API for step outputs in GHA
  2022-10-12 16:29 ` [PATCH 2/2] ci: update to new API for step outputs " David Marchand
@ 2022-10-12 16:53   ` David Marchand
  2022-10-17 14:01     ` David Marchand
  0 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2022-10-12 16:53 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

On Wed, Oct 12, 2022 at 6:30 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> GitHub actions deprecated use of set-output, replaced with
> GITHUB_OUTPUT.
>
> Note: we still have some warnings, as of today, because of
> actions/cache@v3 which did not migrate yet.

For the record, the changes in actions/cache@v3 are pushed in its main
branch, but are not released yet.
https://github.com/actions/cache/commit/b9c8bfe4426d


-- 
David Marchand


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ci: update to new API for step outputs in GHA
  2022-10-12 16:53   ` David Marchand
@ 2022-10-17 14:01     ` David Marchand
  0 siblings, 0 replies; 7+ messages in thread
From: David Marchand @ 2022-10-17 14:01 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

On Wed, Oct 12, 2022 at 6:53 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Oct 12, 2022 at 6:30 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > GitHub actions deprecated use of set-output, replaced with
> > GITHUB_OUTPUT.

It is worth mentionning the deprecation announce:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

> >
> > Note: we still have some warnings, as of today, because of
> > actions/cache@v3 which did not migrate yet.
>
> For the record, the changes in actions/cache@v3 are pushed in its main
> branch, but are not released yet.
> https://github.com/actions/cache/commit/b9c8bfe4426d

The fixes have been released under v3.0.11.

So with this series applied, there is no warning remaining, for now.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] GitHub Actions configuration fixes
  2022-10-12 16:29 [PATCH 0/2] GitHub Actions configuration fixes David Marchand
  2022-10-12 16:29 ` [PATCH 1/2] ci: bump versions of actions in GHA David Marchand
  2022-10-12 16:29 ` [PATCH 2/2] ci: update to new API for step outputs " David Marchand
@ 2022-11-14 10:44 ` David Marchand
  2022-11-14 20:53   ` David Marchand
  2 siblings, 1 reply; 7+ messages in thread
From: David Marchand @ 2022-11-14 10:44 UTC (permalink / raw)
  To: dev, Aaron Conole; +Cc: Michael Santana

On Wed, Oct 12, 2022 at 6:30 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> GitHub Actions started to deprecated some part of the workflow syntax
> and dependencies of some core actions.
>
> This series (mostly) fix those warnings.
> For reviewers/testers, this is still moving: I got new warnings while
> I was testing the first patch...

In the end, the series is good to go as is.

Unless someone objects quickly, I'll apply the two patches, and mark
them as stable material (since we don't know when GHA will make those
warnings into errors..).


-- 
David Marchand


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] GitHub Actions configuration fixes
  2022-11-14 10:44 ` [PATCH 0/2] GitHub Actions configuration fixes David Marchand
@ 2022-11-14 20:53   ` David Marchand
  0 siblings, 0 replies; 7+ messages in thread
From: David Marchand @ 2022-11-14 20:53 UTC (permalink / raw)
  To: dev, Aaron Conole; +Cc: Michael Santana

On Mon, Nov 14, 2022 at 11:44 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Oct 12, 2022 at 6:30 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > GitHub Actions started to deprecated some part of the workflow syntax
> > and dependencies of some core actions.
> >
> > This series (mostly) fix those warnings.
> > For reviewers/testers, this is still moving: I got new warnings while
> > I was testing the first patch...
>
> In the end, the series is good to go as is.

Series applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-11-14 20:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 16:29 [PATCH 0/2] GitHub Actions configuration fixes David Marchand
2022-10-12 16:29 ` [PATCH 1/2] ci: bump versions of actions in GHA David Marchand
2022-10-12 16:29 ` [PATCH 2/2] ci: update to new API for step outputs " David Marchand
2022-10-12 16:53   ` David Marchand
2022-10-17 14:01     ` David Marchand
2022-11-14 10:44 ` [PATCH 0/2] GitHub Actions configuration fixes David Marchand
2022-11-14 20:53   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).