From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com
 [209.85.221.171]) by dpdk.org (Postfix) with ESMTP id 3F62C137C
 for <dev@dpdk.org>; Wed, 28 Nov 2018 14:07:38 +0100 (CET)
Received: by mail-vk1-f171.google.com with SMTP id w72so5882459vkd.5
 for <dev@dpdk.org>; Wed, 28 Nov 2018 05:07:38 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4QC8cBs/EqO34KElyO799pGdMNXo3nHXe+J4p/wK2VM=;
 b=IIRfBFdLAd/GN2G33WBtmL6PVFmpNtbunBmfEWcL1wZ5dQbzjj/lQnOlk/ZHUAXoNI
 CPzKRfRnlmFmDrYaEUAoZX3Gke1LECqwlv4PRsehdZw4FCVmkUGt0Wn0c2coNP/Dt6f7
 pF5hdzk+v2h2VssPPwyNeucG/lBxp/+UzwvCMiTd21SBYcUuOfIA391JBlmjGynqMHuZ
 2LovNuNQO2CekBEFIM+ajkcRWJ+AeyxFhhshbGIGUreLHEmNe/5BjA0G+J1yt637l8gE
 /HVQt6c38NT1nEdtjCPrJ3IbQayUjwOoxsTyc3OqUSJ8k0/tFjSim0SwARb0ZrQoS7SX
 V56g==
X-Gm-Message-State: AA+aEWbxdKOIbMVcFHHlaYW6dqe6uYgE0ZO6s9j5q9smiT5Pmpt9C3wl
 CwZjUMMiTWkz0Wulk+dUw5W/GpVfrftjX8bbEePboA==
X-Google-Smtp-Source: AFSGD/Wr8TsNA3gnzdTdRZbjnuwG2llOL91g3ORc+0QHQf3Y1KMnlxddf2c0hVUcpxBvgzbJXT7/gFmbguGHfjIrKtc=
X-Received: by 2002:a1f:9c81:: with SMTP id f123mr14394615vke.85.1543410457356; 
 Wed, 28 Nov 2018 05:07:37 -0800 (PST)
MIME-Version: 1.0
References: <1543400933-1723-1-git-send-email-david.marchand@redhat.com>
 <20181128123432.GC32491@hmswarspite.think-freely.org>
In-Reply-To: <20181128123432.GC32491@hmswarspite.think-freely.org>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 28 Nov 2018 14:07:25 +0100
Message-ID: <CAJFAV8ytQ2+8OyoE9BJHob-q9sqZZf1sWExNzs0+G4gaL7Kn=g@mail.gmail.com>
To: nhorman@tuxdriver.com
Cc: dev@dpdk.org, thomas@monjalon.net, echaudro@redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 1/2] devtools: report the incorrect section
	when complaining
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 13:07:38 -0000

On Wed, Nov 28, 2018 at 1:35 PM Neil Horman <nhorman@tuxdriver.com> wrote:

> On Wed, Nov 28, 2018 at 11:28:52AM +0100, David Marchand wrote:
> > It does not hurt reporting the incriminated section.
> >
> > Before:
> > ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in a
> > section other than the EXPERIMENTAL section of the version map
> >
> > After:
> > ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in
> > +EXPERIMENTAL section other than the EXPERIMENTAL section of the
> > version map
> >
> nit: Its a bit odd in the changelog to have an example in which the
> incorect
> section being reported matches the expected section.  I.e. its confusing
> to read
> "... is added in +EXPERIMENTAL section other than the EXPERIMENTAL
> section".
> Might be better to change the language of the report below and the example
> to be
> something like:
>
> ERROR: symbol <SYMBOL> is added in the <VERSION> section, but is expected
> to be
> added in the EXPERIMENTAL section
>
> ACK to the notion of reporting the offending section though.  Thats a good
> idea.
>

Ok, updated for v2.

-- 
David Marchand