From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A1F1A0032; Tue, 16 Nov 2021 16:13:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E0604114D; Tue, 16 Nov 2021 16:13:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6089540141 for ; Tue, 16 Nov 2021 16:13:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637075625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y+hF3XAz7+d28BbQ8v6lSYSLxzVatGvk0GPVpySVhNU=; b=IPGmSUr+rLC9zfI6aeT8exjW4a/2hANRzzvYqzoRb0CLLH93w23zIDsnnNrxXYtZ6Nv0Jl /MQDaKTDiAVXT0ftGj3yerUeRF4ZpkgV+orsk0rxLwMorS31lw+9iRpftW5UdBwtcKHPTt s8eXGnaQ7ub/2egl/D69sppNPESJatI= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-5PazsGJ1P3OqSgdwzHe4aQ-1; Tue, 16 Nov 2021 10:13:44 -0500 X-MC-Unique: 5PazsGJ1P3OqSgdwzHe4aQ-1 Received: by mail-lj1-f198.google.com with SMTP id u28-20020a2ea17c000000b0021126b5cca2so4476145ljl.19 for ; Tue, 16 Nov 2021 07:13:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y+hF3XAz7+d28BbQ8v6lSYSLxzVatGvk0GPVpySVhNU=; b=NMyKIL4uz3aKxrU8+Hvv6CRjtFmat6USqmo87sbyV17Mw9kSpUEkYoKXqiAZPZCoZW dHbmgFL0ByDDNQFkzeevNYnhTkMt7Yfzwqynz+2EMkRiEKin1gNg03ZDsB/ZESTL/ZWS Nx8MsVtm7Qdrtdu4ykAeP1S7ZtXatj8wYx5PSOTDRcU4yFv63R52UjjufBdVUc7+PHBP 4N5PXbEn3HiP5X9lImm1gPA/wIJ8ULwzlpFOEhs99953Gtu7/en80hFzFRu9G6+SnuMU 0yJnt9xHWJ7sVKUW2n00+gZTZ2zHqcHL7KvpndL+1aGDFc03kAvHnQXPy2vQXb49rW9X w1GA== X-Gm-Message-State: AOAM532GZMimQ/mMjhKFwLERH7WwmOperNb63DDnsR7X59/kXjtsLgfz Ne5TapFBnXqDi6AeXOPjtGzq+YH0kODgAJ6qSSYENlxMFxOJPK9xMvfrUdRE4HfvsYBcHPaj1TS qTQXIkANezkAjCjGGa6c= X-Received: by 2002:ac2:42c6:: with SMTP id n6mr7132544lfl.553.1637075623143; Tue, 16 Nov 2021 07:13:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwV2qrfoHl1EgahEpcGAL3CEwztpRGl4u/YbzMPQyrZ+YEIqkAzFWeY6KF+Oov/to+wy+Il46wuXO2u1ZZuhqE= X-Received: by 2002:ac2:42c6:: with SMTP id n6mr7132525lfl.553.1637075622979; Tue, 16 Nov 2021 07:13:42 -0800 (PST) MIME-Version: 1.0 References: <20211103024103.2420-1-joyce.kong@arm.com> <20211112063703.16459-1-joyce.kong@arm.com> In-Reply-To: <20211112063703.16459-1-joyce.kong@arm.com> From: David Marchand Date: Tue, 16 Nov 2021 16:13:32 +0100 Message-ID: Subject: Re: [PATCH v3] examples/flow_filtering: fix wrong comment To: Joyce Kong Cc: Ori Kam , Conor Fogarty , Conor Walsh , John McNamara , dev , nd , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 12, 2021 at 7:37 AM Joyce Kong wrote: > > The 'IPv4' in the comment is to mark the code > snippet, while it made some confusion. Then > removing 'IPv4' description will be clearer. > > Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") > Cc: stable@dpdk.org I removed the backport request: it's not fixing a problem, just enhancing readability of a comment. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > Reviewed-by: Conor Walsh Applied, thanks. -- David Marchand