From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com
 [209.85.217.49]) by dpdk.org (Postfix) with ESMTP id 3AB961BDCF
 for <dev@dpdk.org>; Fri, 21 Dec 2018 10:28:39 +0100 (CET)
Received: by mail-vs1-f49.google.com with SMTP id p74so2852199vsc.0
 for <dev@dpdk.org>; Fri, 21 Dec 2018 01:28:39 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ctyq4zfruhAHy8VxRJ08q6Ul+huGs7dJPcA0Yp7Ad5s=;
 b=b7meRIU5i57QwAMP+qLk/w8kc7i2Guc/bvcf5ySyVYfJxz+rsA0n2UyILMqNd4RLAt
 Uh3Z51YW88Wrx9o8Hm5NH1aO+Y7ZoUVeAI7bOkVZ4xgSQ64qhDWkhS9BltdHNsx4McV3
 JyIBZiUcxt5AT0UxFBowM1cJX3TcZ3czUgazcnR7r73UWHXVopPSRQn9A+ftnCHni3lz
 gw9l/5Y0MmdsCG8t4ykjgnsbdPWPma72wHshjHJawXxD9U9TXpKuBLwuxTobWrrdYX4T
 uKtWcco69RhxTwPxezNu9X1wde8CGTP8RyVcx4onGT8nUqoqiuYfjiBFIfYaMVt3zb7F
 YfTQ==
X-Gm-Message-State: AJcUukcthOAUobT+rQJmByYdVTPJ5KFlFg6+yniCdU+PpugHtl/8qSCn
 +ph+huCzvDxZI8MyEYSAiXH6bgDQkI/qJouAnqERYw==
X-Google-Smtp-Source: AFSGD/VCN0jBdOWaG2fg/syymfltbRyh2GwrVRo5Hy3pQ2gqdVTwxLVT0siSmicYoo3f8WOGAY3nhALRpNl4KjxdOno=
X-Received: by 2002:a67:c48a:: with SMTP id d10mr736043vsk.105.1545384518575; 
 Fri, 21 Dec 2018 01:28:38 -0800 (PST)
MIME-Version: 1.0
References: <1545300049-7463-1-git-send-email-hari.kumarx.vemula@intel.com>
 <CAJFAV8xW9vjYjDX07pO8hK=vmG16wKYB9YjZHL7-xBegWkMaSA@mail.gmail.com>
 <36ca3933-842c-8e74-ab36-c3f6809beaaa@intel.com>
In-Reply-To: <36ca3933-842c-8e74-ab36-c3f6809beaaa@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 21 Dec 2018 10:28:27 +0100
Message-ID: <CAJFAV8yt_m=G=paKxCrAU3HkCScY4fRm1oigqn=cgw-2q-4kKQ@mail.gmail.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, 
 Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] eal: fix core number validation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 09:28:39 -0000

On Fri, Dec 21, 2018 at 10:19 AM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:

> On 21-Dec-18 8:27 AM, David Marchand wrote:
> > Since you have identified a potential crash, can you give an example of
> > such a crash ?
> > Besides, we have tests that check arguments, so an update of the test
> would
> > be nice.
>
> I believe these lcore numbers are used to index the lcore list later,
> which would cause out-of-bounds access, which may or may not cause a
> crash, depending on how lucky you get.
>

Sure, that and the fact that my testpmd was doing nothing with them :-).
Anyway, the unit tests missed this case, so we need an update.

And the more I look at those string parsing, the more I think that the
service cores parsing has the same issue (copy/paste yay ;-)).


-- 
David Marchand