From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5D3541D9B; Tue, 28 Feb 2023 09:27:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45D714113C; Tue, 28 Feb 2023 09:27:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4CA30410D4 for ; Tue, 28 Feb 2023 09:27:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677572849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=siliynYDc9Sw9l2GuI1vGR+HuwRSjzBxEXQIS+D630U=; b=cTTzGAgLHYu42ksKR/hZxkVohkJPImyWGOe5L3njfG9EfhdqQQaIiX3XRoz2rMTC8ZPQdM sMsvU62WPg4TzxiJgx4d3m45R1GZFfFCTz+AxtEn6WpUjfPWccxeGurk7e3IjdTCE19DFk Lmga0nfIDw9Qe3Q45vlGZXi2wY4cmkw= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-126-P8DUiFzJOl62ojGE4-0bTw-1; Tue, 28 Feb 2023 03:27:28 -0500 X-MC-Unique: P8DUiFzJOl62ojGE4-0bTw-1 Received: by mail-pl1-f197.google.com with SMTP id z2-20020a170903018200b0019cfc0a566eso4020342plg.15 for ; Tue, 28 Feb 2023 00:27:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=siliynYDc9Sw9l2GuI1vGR+HuwRSjzBxEXQIS+D630U=; b=NT9mQvmUNQB8RjoGozciGZsmU7s0UQrGdopn3e3Y8wZ0BvkHx50e5XcTN8adjpcNIr d5OVv43NOdATwPmPOgJ0c9o4UaKCpYAELJsa9shl/vdm/+NP6amYX53kyGHfDGC/h6EK YGZ9n0W6vgPOpQfaHQJTvde0Ix0drrTJHaHa2nsnFq7ObU3CGECC59Rr2oiN1Yh7odCH Pj1cW143RTVWgRFcT6JGkZi2+eyVAWAUHhSX1yY0dAdfsO8V8+mBVH+g5gHoHeHfi+rB k0JWefAjMq9oj4o9jIhOYKpH+efyph0hHJ6Va8DcywC83GJOgkvHmWYUGejP9T0Ysc/H M17A== X-Gm-Message-State: AO0yUKWDe5C3ucqtXsfJB3DJ333r4yS9Tuwdktb6oLuVgbOdhHb9ZvF5 1SEjSkdNF3/Cyn4xEeZY4oqNBn8gwsY7mssh9lY8rHWvcsskgWH1v47fL/yxzzfO2JENFZLjH1X 9zS4RQ+C97ThYJ2zJUEk= X-Received: by 2002:a17:90a:fae:b0:237:64dc:5acd with SMTP id 43-20020a17090a0fae00b0023764dc5acdmr839658pjz.7.1677572847098; Tue, 28 Feb 2023 00:27:27 -0800 (PST) X-Google-Smtp-Source: AK7set9tcmiGXpTZNDp2788nJRiby9uw8fWwMB3mHZCaYaYDscEim9/Rtkn5ga0+GJ2T/D4kTnz8cNoYO1ynvZSSUQE= X-Received: by 2002:a17:90a:fae:b0:237:64dc:5acd with SMTP id 43-20020a17090a0fae00b0023764dc5acdmr839647pjz.7.1677572846705; Tue, 28 Feb 2023 00:27:26 -0800 (PST) MIME-Version: 1.0 References: <20230227105927.3643421-1-david.marchand@redhat.com> <8946c21c-dbdf-8bbb-5c94-28b9527d9a22@redhat.com> In-Reply-To: <8946c21c-dbdf-8bbb-5c94-28b9527d9a22@redhat.com> From: David Marchand Date: Tue, 28 Feb 2023 09:27:15 +0100 Message-ID: Subject: Re: [PATCH] vhost: fix OOB access for invalid vid To: Maxime Coquelin Cc: dev@dpdk.org, stable@dpdk.org, Chenbo Xia X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 27, 2023 at 5:19 PM Maxime Coquelin wrote: > On 2/27/23 11:59, David Marchand wrote: > > The net/vhost pmd currently provides a -1 vid when disabling interrupt > > after a virtio port got disconnected. > > > > This can be caught when running with ASan. > > > > First, start dpdk-l3fwd-power in interrupt mode with a net/vhost port. > > > > $ ./build-clang/examples/dpdk-l3fwd-power -l0,1 --in-memory \ > > -a 0000:00:00.0 \ > > --vdev net_vhost0,iface=plop.sock,client=1\ > > -- \ > > -p 0x1 \ > > --interrupt-only \ > > --config '(0,0,1)' \ > > --parse-ptype 0 > > > > Then start testpmd with virtio-user. > > > > $ ./build-clang/app/dpdk-testpmd -l0,2 --single-file-segment --in-memory \ > > -a 0000:00:00.0 \ > > --vdev net_virtio_user0,path=plop.sock,server=1 \ > > -- \ > > -i > > > > Finally stop testpmd. > > ASan then splats in dpdk-l3fwd-power: > > > > ================================================================= > > ==3641005==ERROR: AddressSanitizer: global-buffer-overflow on address > > 0x000005ed0778 at pc 0x000001270f81 bp 0x7fddbd2eee20 > > sp 0x7fddbd2eee18 > > READ of size 8 at 0x000005ed0778 thread T2 > > #0 0x1270f80 in get_device .../lib/vhost/vhost.h:801:27 > > #1 0x1270f80 in rte_vhost_get_vhost_vring .../lib/vhost/vhost.c:951:8 > > #2 0x3ac95cb in eth_rxq_intr_disable > > .../drivers/net/vhost/rte_eth_vhost.c:647:8 > > #3 0x170e0bf in rte_eth_dev_rx_intr_disable > > .../lib/ethdev/rte_ethdev.c:5443:25 > > #4 0xf72ba7 in turn_on_off_intr .../examples/l3fwd-power/main.c:881:4 > > #5 0xf71045 in main_intr_loop .../examples/l3fwd-power/main.c:1061:6 > > #6 0x17f9292 in eal_thread_loop > > .../lib/eal/common/eal_common_thread.c:210:9 > > #7 0x18373f5 in eal_worker_thread_loop .../lib/eal/linux/eal.c:915:2 > > #8 0x7fddc16ae12c in start_thread (/lib64/libc.so.6+0x8b12c) > > (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) > > #9 0x7fddc172fbbf in __GI___clone3 (/lib64/libc.so.6+0x10cbbf) > > (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) > > > > 0x000005ed0778 is located 8 bytes to the left of global variable > > 'vhost_devices' defined in '.../lib/vhost/vhost.c:24' > > (0x5ed0780) of size 8192 > > 0x000005ed0778 is located 20 bytes to the right of global variable > > 'vhost_config_log_level' defined in '.../lib/vhost/vhost.c:2174' > > (0x5ed0760) of size 4 > > SUMMARY: AddressSanitizer: global-buffer-overflow > > .../lib/vhost/vhost.h:801:27 in get_device > > Shadow bytes around the buggy address: > > 0x000080bd2090: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 > > 0x000080bd20a0: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 > > 0x000080bd20b0: f9 f9 f9 f9 00 f9 f9 f9 00 f9 f9 f9 00 f9 f9 f9 > > 0x000080bd20c0: 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 04 f9 f9 f9 > > 0x000080bd20d0: 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 > > =>0x000080bd20e0: 00 f9 f9 f9 f9 f9 f9 f9 04 f9 f9 f9 04 f9 f9[f9] > > 0x000080bd20f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x000080bd2100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x000080bd2110: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x000080bd2120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x000080bd2130: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > Shadow byte legend (one shadow byte represents 8 application bytes): > > Addressable: 00 > > Partially addressable: 01 02 03 04 05 06 07 > > Heap left redzone: fa > > Freed heap region: fd > > Stack left redzone: f1 > > Stack mid redzone: f2 > > Stack right redzone: f3 > > Stack after return: f5 > > Stack use after scope: f8 > > Global redzone: f9 > > Global init order: f6 > > Poisoned by user: f7 > > Container overflow: fc > > Array cookie: ac > > Intra object redzone: bb > > ASan internal: fe > > Left alloca redzone: ca > > Right alloca redzone: cb > > Thread T2 created by T0 here: > > #0 0xe98996 in __interceptor_pthread_create > > (.examples/dpdk-l3fwd-power+0xe98996) > > (BuildId: d0b984a3b0287b9e0f301b73426fa921aeecca3a) > > #1 0x1836767 in eal_worker_thread_create .../lib/eal/linux/eal.c:952:6 > > #2 0x1834b83 in rte_eal_init .../lib/eal/linux/eal.c:1257:9 > > #3 0xf68902 in main .../examples/l3fwd-power/main.c:2496:8 > > #4 0x7fddc164a50f in __libc_start_call_main (/lib64/libc.so.6+0x2750f) > > (BuildId: 81daba31ee66dbd63efdc4252a872949d874d136) > > > > ==3641005==ABORTING > > > > More generally, any application passing an incorrect vid would trigger > > such an OOB access. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > Note: even after this patch, reconnecting the virtio-user port with > > dpdk-l3fwd-power in interrupt mode still seems broken, as the net/vhost > > pmd keeps complaining about an issue with rx interrupt fds. > > > > --- > > lib/vhost/vhost.h | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h > > index 5750f0c005..d9e97280fa 100644 > > --- a/lib/vhost/vhost.h > > +++ b/lib/vhost/vhost.h > > @@ -798,7 +798,10 @@ hva_to_gpa(struct virtio_net *dev, uint64_t vva, uint64_t len) > > static __rte_always_inline struct virtio_net * > > get_device(int vid) > > { > > - struct virtio_net *dev = vhost_devices[vid]; > > + struct virtio_net *dev = NULL; > > + > > + if (vid >= 0 && vid < RTE_MAX_VHOST_DEVICE) > > Maybe use likely() to help the compiler? I see no difference in x86 generated code with gcc 12 but I don't mind adding it (or you can add it while applying ? :-)). > > > + dev = vhost_devices[vid]; > > > > if (unlikely(!dev)) { > > VHOST_LOG_CONFIG("device", ERR, "(%d) device not found.\n", vid); -- David Marchand