From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABA52426B5; Wed, 4 Oct 2023 08:03:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8186540289; Wed, 4 Oct 2023 08:03:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 897D04027A for ; Wed, 4 Oct 2023 08:03:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696399425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/K51JxWwxYtHhBLnC34Iv8RVzGFzWXOBm/F3PS9Kyk=; b=cKiPVoctvPg3EW3rBVpIuhCXhIkG5NB2J3omtTvHX+TUT0msLvMnRuMVziHoHcqSKvyEQB kplGin66LPlIaCC5A5wljMd1cogiqjoXvx6uACdnTKdeq0uZqjSnZG0CMDLaZOtQEcZl45 rnT+QkHqoo+6ZtFcJnrMBa52gGGRGwo= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-11ISjKcVPmSJVbZFBvcNbg-1; Wed, 04 Oct 2023 02:03:43 -0400 X-MC-Unique: 11ISjKcVPmSJVbZFBvcNbg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50433324cf3so1586997e87.3 for ; Tue, 03 Oct 2023 23:03:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696399422; x=1697004222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e/K51JxWwxYtHhBLnC34Iv8RVzGFzWXOBm/F3PS9Kyk=; b=ex8lb8hcDz9NwqnC3Wq4JIEjQ3PPdAMmNR3P9HZHdTevAAudqaMsq2qxwii/KgHIfE AXkXZ87Fm1dLCtnBkupkin9X14JAWAsluPq90DDw8eXwnBER8F5QdJT5gpPGfTDQdJYN zxOTeNkw4Id8Ok6IbMm5Snud/OBzdnE2HcF02VQ5YR21FuOADqDOTagJY2Agx/JX5Nqs 8Yh92AQBPR2vAQ3Mbc1K90zrB6c4CU8Fhj94LIsWyqu/mqW5ME38b6VD6l15r3IglKM4 ns1wWqKUkZKd4upGlvOrFPMlXJNk2CZz8k77Y0eNsc50QjeAWQ8bNNR4iChTscW6r3dD t2Ug== X-Gm-Message-State: AOJu0YxYYOiVW7pUKRk3LMvlt2+n3xfnd5IZtlcFd+zGiV0OFRaJa6KT b2rl3dTXk3RoWQMKhPcK/J1rDubr5Xo3LX1kdDHL7UB7V262i3lW06IpqOV/qUkUPNuyoRzR7UJ L2MZbViALEQTn01XtfPg= X-Received: by 2002:a05:6512:20cd:b0:505:7276:8a5f with SMTP id u13-20020a05651220cd00b0050572768a5fmr892725lfr.2.1696399422226; Tue, 03 Oct 2023 23:03:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2NPZ3DT+1jS2dUTUI2ey6QkEGY2foRHP5zDc41GHQ3RHAEnGEvWouvNKzfqSs7khju9Sm9igAz4nMQxJxkpc= X-Received: by 2002:a05:6512:20cd:b0:505:7276:8a5f with SMTP id u13-20020a05651220cd00b0050572768a5fmr892696lfr.2.1696399421848; Tue, 03 Oct 2023 23:03:41 -0700 (PDT) MIME-Version: 1.0 References: <20231003183956.1270510-1-jerinj@marvell.com> In-Reply-To: <20231003183956.1270510-1-jerinj@marvell.com> From: David Marchand Date: Wed, 4 Oct 2023 08:03:30 +0200 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix direct rte symbol usage To: jerinj@marvell.com Cc: dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Long Li , Tyler Retzlaff , Konstantin Ananyev , Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Liron Himi , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Jerin, On Tue, Oct 3, 2023 at 8:40=E2=80=AFPM wrote: > > From: Jerin Jacob > > The common code is shared between different driver environments, > introduce missing plt_ abstractions of missing rte_ symbols and > use plt symbols to avoid changing roc_* files. > > Also update the thread name for outbound soft expiry thread > in a7ba40b2b1bf7. > > Fixes: 3d4e27fd7ff0 ("use abstracted bit count functions") > Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads") > Fixes: c88d3638c7fc ("common/cnxk: support REE") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob - Could we add something in checkpatch for this driver? I was aware of this s/rte_/plt_/ peculiarity but still missed it... - If you want this backported in LTS, I suggest splitting the fix against c88d3638c7fc ("common/cnxk: support REE") and the rest than only affects current release. - One comment: > diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/= roc_nix_inl_dev.c > index 6aa191410b..614d0858e5 100644 > --- a/drivers/common/cnxk/roc_nix_inl_dev.c > +++ b/drivers/common/cnxk/roc_nix_inl_dev.c > @@ -826,7 +826,7 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *in= l_dev) > soft_exp_consumer_cnt =3D 0; > soft_exp_poll_thread_exit =3D false; > rc =3D plt_thread_create_control(&inl_dev->soft_exp_poll_thread, > - "outb-poll", nix_inl_outb_poll_thread, inl_dev); > + "outb-soft-exp-poll", nix_inl_outb_poll_thread, i= nl_dev); Such a thread name is too long. This is reverting Thomas change. Is this intentional? --=20 David Marchand