From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9E62A0562; Tue, 23 Mar 2021 12:53:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EEED4069E; Tue, 23 Mar 2021 12:53:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id CD23140689 for ; Tue, 23 Mar 2021 12:53:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616500381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c52OGQEOIMmIRo37JkAjUXjJgvGctdb3zKXbIlgxr2w=; b=VYd5KQ0DP758K5UjnO9Xd9iuy3Y6KRMFw0/Z8IsYeEWHZWzwGuo8lYRct/DNSRPraXgjl8 UU7gJD5qqSFwQe4bpLm7seiXh4A6pkMo3OsNxQbjkKWbfUghl5eHr7fFLX0sYDxUj85hZi dDdMkEvZoy5V21o58/7X7vXdE6VmdNw= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-6bb_p_YqOBiElCQodgPd4g-1; Tue, 23 Mar 2021 07:53:00 -0400 X-MC-Unique: 6bb_p_YqOBiElCQodgPd4g-1 Received: by mail-vk1-f197.google.com with SMTP id s69so427196vkd.20 for ; Tue, 23 Mar 2021 04:53:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c52OGQEOIMmIRo37JkAjUXjJgvGctdb3zKXbIlgxr2w=; b=s87RGcRLaU5swybRpnyoY4xq+voHEyOoPY9cNX3SmDnu6U2JMZcdX5KnIVv89mcwVf 51dkzRPGi62AFzejopO7kwajYbggiVTDeHdKEomhdkpQnf/kpal0JoD/NSUdflYodtcb FzgzC/L3VCaIV2Rbx5D9H7uh84jgJOL4ceTIVwOWMjlTgXzyf3jVL4WKMG2CHssh5sYi M2Kvg2UFaQzwwNlY/YsTK9EwldQoktESnONXQAouBSqWouNfxCX54YLOuXu1XyxMlDa7 c+jmKnQkJufxRIGD99iKgPiFva+EMZ09DzXDAW5Rg9c1tSC8CvSw1C5zm0JCcn0jKDhE gZpA== X-Gm-Message-State: AOAM530PjN1WNX1Kk1BqMNwipUNzFtIJkfcJhpPYaK+AlVtdzqF0bTO9 7GV65WLBtK7mO4rfAyFAlq0dQ032OrtEPKLsHvFGMv0TFaMVL3KSD1yoG2dMXPs7HFZRzg6selG oXQg/653WVMdocf/ua9Y= X-Received: by 2002:a9f:3591:: with SMTP id t17mr2819429uad.41.1616500379707; Tue, 23 Mar 2021 04:52:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGn9ucVBXBJVzv35WIuotWNLLlLQP5hX5yplKBXZF7ShJIntmp1EyGfQBr4F/tH6IvZp8B7zluZw689VzGpfE= X-Received: by 2002:a9f:3591:: with SMTP id t17mr2819422uad.41.1616500379512; Tue, 23 Mar 2021 04:52:59 -0700 (PDT) MIME-Version: 1.0 References: <20210204073420.2421-1-ibtisam.tariq@emumba.com> In-Reply-To: <20210204073420.2421-1-ibtisam.tariq@emumba.com> From: David Marchand Date: Tue, 23 Mar 2021 12:52:48 +0100 Message-ID: To: Ibtisam Tariq Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and consistency in > all examples. > > Bugzilla ID: 238 > Cc: marko.kovacevic@intel.com > > Reported-by: David Marchand > Signed-off-by: Ibtisam Tariq Series applied, thanks for the cleanup Ibtisam. As I mentioned before, there are still some unaligned examples (flow_classify, ip_reassembly, kni, l2fwd-crypto, l3fwd-power, multi_process/symmetric_mp, vpda, vmdq, vmdq_dcb), so I'll leave the bz open. -- David Marchand