From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FA2242672; Fri, 29 Sep 2023 17:00:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35359402AD; Fri, 29 Sep 2023 17:00:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A6464026E for ; Fri, 29 Sep 2023 17:00:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695999649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kkszme7IzlS07vkPni/ToEzZ7t1oPELoZxpIvtj/H2A=; b=DC/G5F3EBtu2eWDTelvdt4mE8w0JCYEaC2B+WP3mga6ecZhSkyWMH61/ELgx/OFDIWbjwo sxJ2I8sWMKUBNQrP4zn2658CuwEkJ7b7g/tGyHydeZav1Jwki3bGnPwre+wAQipOp7FYqe 79WkHeRMqtkjBMzZspwMdl0FOM3NID0= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-hcPD4wOBOZ-T7zE5jNMQJg-1; Fri, 29 Sep 2023 11:00:47 -0400 X-MC-Unique: hcPD4wOBOZ-T7zE5jNMQJg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5042eca54a4so20969958e87.2 for ; Fri, 29 Sep 2023 08:00:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695999646; x=1696604446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kkszme7IzlS07vkPni/ToEzZ7t1oPELoZxpIvtj/H2A=; b=srCc2CZSXzf1212EqjnuYkUdOjs31Hl+YELrFJpqyf61wrdabjrArTsP60Yd4vZtGq ETjtmb5aVD0qxrKzS6oH4R7uruJfPzijcMIbW+LB47PHi5ZWp+GTqqgueDy97hCXV5Xb MFeejMiq6o0MEFdcNLXet8dmEyGubeeHJXS5GhVGwKZLCBMFwD/JRseozOQa2PRDXj1f 9zK7FQfaCE8XVdt3UDsOmrDJ7P55MLRnbFop/pPOmC+AzfB0pYyravHrBLnSySXxXz4t P3rb2HTYVhvbQC8mH6vPynQwPl4oYdFSQPvdFuWpOfqPHfi6cRtgmGbBMcrTqk2h3whp unwA== X-Gm-Message-State: AOJu0YxAdAnqBWcQnXXOTzMW+a52m2a3hDikyaWzoOap5r3ySFL5s5Zo BJZsreeTEjx+vKJoSZTA60xVF2biQf+5jetBnOJIvXjkSBKJdW3LUj3u9lwqXySLoUNwVqbqEc+ otKgXkEw+wRTCYwVyUj8= X-Received: by 2002:a05:6512:3451:b0:500:8f65:c624 with SMTP id j17-20020a056512345100b005008f65c624mr3390472lfr.53.1695999646067; Fri, 29 Sep 2023 08:00:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGW7TFbSujsLYyRYySCOo0sWo0zdYTjdPjuDPQUq+9f9yeuyy5ErvSZh3wbzAiEr4NzIzVXUf0jOeJFV3b87zo= X-Received: by 2002:a05:6512:3451:b0:500:8f65:c624 with SMTP id j17-20020a056512345100b005008f65c624mr3390454lfr.53.1695999645716; Fri, 29 Sep 2023 08:00:45 -0700 (PDT) MIME-Version: 1.0 References: <20230803162512.41396-1-levendsayar@gmail.com> In-Reply-To: <20230803162512.41396-1-levendsayar@gmail.com> From: David Marchand Date: Fri, 29 Sep 2023 17:00:34 +0200 Message-ID: Subject: Re: [PATCH] gpu/cuda: fix getenv related build error To: eagostini@nvidia.com Cc: dev@dpdk.org, Levend Sayar , Aaron Conole , romein@astron.nl X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 3, 2023 at 6:25=E2=80=AFPM Levend Sayar = wrote: > > If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. > This causes gdrcopy.c build to give an error; > because compiler can not find signature of getenv. > stdlib.h is included for the definition of getenv function. > There was a bug report for this issue: Bugzilla ID: 1133 > Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters"= ) It is probably worth backporting: Cc: stable@dpdk.org > > Signed-off-by: Levend Sayar Elena, this is a quick one, review please. --=20 David Marchand