From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1661FA0547; Tue, 15 Nov 2022 10:53:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9B5D40DFD; Tue, 15 Nov 2022 10:53:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 96B2840150 for ; Tue, 15 Nov 2022 10:53:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668505993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FABa2wrKUd03X+r6fzISlaFgMPEPQowuD8STE6US1Zg=; b=bfs2eSLU35vxgA8C9fxTWJalJV/LN3h74hNCVj8JCD6g3iykip1pMxxLeg5zfeh1yPNYKo G5Xx4Ueqt13XvNAcOgrQVS8XAtS7ZYtyi8JspGtjXGGVpQSvHPyYpcxzS4qK+sHNLPokFq feibE6npkBqLNQnE6aFBQ/T7XGZsubY= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-315-cRGCgq4hNwKbkHFILHb-dA-1; Tue, 15 Nov 2022 04:53:11 -0500 X-MC-Unique: cRGCgq4hNwKbkHFILHb-dA-1 Received: by mail-pl1-f198.google.com with SMTP id n12-20020a170902e54c00b00188515e81a6so11109744plf.23 for ; Tue, 15 Nov 2022 01:53:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FABa2wrKUd03X+r6fzISlaFgMPEPQowuD8STE6US1Zg=; b=uCUz0Ndso72Aixsr2TJOcRA2jaFX0SPbm53DFwifdKljBaGsFJ+tNAXtHwSG/Ev/k4 mynpesKoQ4URLJVOXbYudZJg2GRi2jTTza2xMW80V/3NceQi8RCLFWoGynVlOkuzagde IicVWWC4G1/Sb2/zEs1yoHi3GXPwE/E5ArAXgikicJh+ki0SMxRZgLXhnae8Pkp9oOJ+ g2HY3v1S1TWK1e7pXDnfxGkZQNg4pNaR4zEDpBHGJPM5w1wlcuUw9s7+BTGeLT7TQzmT UGWpZC/JFHTMnZU5irgXk08geXzhvbcjF3QcdTCZfrKNN+qWDZXreTuVavx6h+Jjl/HD wP3g== X-Gm-Message-State: ANoB5pkimXxP2B9PPwPqaeajpZ/340xcT1XJSY73BaJxFpdCYwwm9Gyy +Im5Owwwz965CohhuhidvdI9noccZSNAPac9Brd+er4MtKIBsaWZuXkBaDmEmloNjIi45yNN8Am x8ZZztpzkkoBh43/IbBM= X-Received: by 2002:a17:903:2d2:b0:188:4f86:e4d5 with SMTP id s18-20020a17090302d200b001884f86e4d5mr3372706plk.16.1668505990725; Tue, 15 Nov 2022 01:53:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf4J7U4ghu7dvV49vUmWM1t73UpnXd3DQsBGhUaTJZQBXsTmtCFmOWKbzntRZiXHNjO2IhPkcDKnLKTmUEDqF/8= X-Received: by 2002:a17:903:2d2:b0:188:4f86:e4d5 with SMTP id s18-20020a17090302d200b001884f86e4d5mr3372691plk.16.1668505990471; Tue, 15 Nov 2022 01:53:10 -0800 (PST) MIME-Version: 1.0 References: <20220722091236.15469-1-liudongdong3@huawei.com> <20221011111843.3311-1-liudongdong3@huawei.com> In-Reply-To: <20221011111843.3311-1-liudongdong3@huawei.com> From: David Marchand Date: Tue, 15 Nov 2022 10:52:59 +0100 Message-ID: Subject: Re: [PATCH v10 0/8] app/procinfo: add some extended features To: Dongdong Liu , reshma.pattan@intel.com Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu wrote: > > This patchset is to add some extended features for dpdk-proc-info. > > Thanks to Reshma and Stephen help to review the patchset. > > v9->v10: > - Fix some comments for Rx/Tx descriptor dump. > > v8->v9: > - Fixed some checkpatch warnings. > > v7(v4)->v8: > - Add Acked-by: Reshma Pattan for PATCH 4,6. > - Add Rx/Tx descriptor dump. > - Adjust procinfo doc guide. > > v3->v4: > - Add Acked-by: Reshma Pattan for PATCH 1,2,3,5,7. > - Rename show-module-info to show-module-eeprom to make more clear. > > v2->v3: Fix some comments from Stephen. > - Use --version option for DPDK version. > - Add --firmware-version option to show firmware. > - Use errors on stderr, not stdout. > - Delete some unnecessary code. > > v1->v2: Fix some comments from Reshma. > > Dongdong Liu (4): > app/procinfo: add firmware version dump > app/procinfo: fix some wrong doxygen syntax > app/procinfo: support descriptor dump > doc: add some extended features in procinfo guide > > Jie Hai (1): > app/procinfo: add dump of Rx/Tx burst mode > > Min Hu (Connor) (3): > app/procinfo: add dpdk version dump > app/procinfo: add RSS RETA dump > app/procinfo: add module eeprom info dump > > app/proc-info/main.c | 324 ++++++++++++++++++++++++++++++--- > doc/guides/tools/proc_info.rst | 36 +++- > 2 files changed, 336 insertions(+), 24 deletions(-) The last patch was a mix of various changes in the documentation. Please make sure to update the documentation as part of the code changes, in the future. And separate fixes with proper Fixes: tag from other changes. Series applied, thanks. -- David Marchand