From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4E56A04B5; Tue, 27 Oct 2020 13:24:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E386B2BE1; Tue, 27 Oct 2020 13:24:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 760412BDB for ; Tue, 27 Oct 2020 13:24:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603801474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FAyuHvc4wPi4vBWpnsWBZdAyre6lgcE3qzPU9rhJ6Y8=; b=VbVuGi5FeEoA/7yPqzhR31w5BFaMGI6NZav9g3x3WZNFEESsZYZZbCQ6V/GQDEz/H4Hy6L 2/VhWbCI49uWxEaoGUoUbUDiRegjY3y/5CgDK4NY7rxvqBMFmgSEWj4MBAHHJhImPYDPYy qlgn57qwdSVZwdqG4QUj6Oifmkhz1Gg= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-iITTC_DbNTWWiBDkesnlig-1; Tue, 27 Oct 2020 08:24:33 -0400 X-MC-Unique: iITTC_DbNTWWiBDkesnlig-1 Received: by mail-vk1-f198.google.com with SMTP id t78so534041vkb.2 for ; Tue, 27 Oct 2020 05:24:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FAyuHvc4wPi4vBWpnsWBZdAyre6lgcE3qzPU9rhJ6Y8=; b=HQS07Rdn3qutGoGykgFWhnFGHP4dwBVlDkAqM8ETWswpIhcycXF4yR/QCMWBMfXK69 ovhBmt8cMGneBLe+p4E5aR5lKSj4vUwBXtLxEGk+Pe/32480AiHnCee0AzBkgQSddOBZ jAajFmQaYDEvS5Sku2vlP5/ZkEWcZh5pJX64haQYqE9XBobK8ugJ10mSxD1yzqGK5ZoP 0p2c+yuyfL7ExnFjzYCFLa/6ZwthdFrrM46O4svgXo67z2aoyiG2zgeChQw9CpSO3qQg hjQLuARlwOgkEFylZ0xG5CU0VxA1zBxL7iJlDeJ4dRoUqR1eBDnR9dFCjm1UjWCTTUNK 2fbg== X-Gm-Message-State: AOAM531LRftk/3YI3grmCwfX2VYTJO67qvRDtR+n/UsBU7/C2pK9TqnG lhCff8lPM7LeIGihU91KQdo6pPuXe51AZAvMXWi9nSS1mvPPcjqOqwShGM91wEeZ1KQPz6K4q1k 61zQiwjJvkkiiZeBX4F4= X-Received: by 2002:ab0:4983:: with SMTP id e3mr917683uad.41.1603801472678; Tue, 27 Oct 2020 05:24:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFrhnY758MtRNhywo4cpLBzAiVD5g8bbNzmw7Uqh0eM9K9tHGg7xxUGNciuy17HMdP5BSZPKfWQG1KUtHfuWA= X-Received: by 2002:ab0:4983:: with SMTP id e3mr917675uad.41.1603801472443; Tue, 27 Oct 2020 05:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20201022080810.22153-1-david.marchand@redhat.com> In-Reply-To: <20201022080810.22153-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 27 Oct 2020 13:24:21 +0100 Message-ID: To: dev Cc: Harry van Haaren Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] service: separate dump and reset code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 22, 2020 at 10:08 AM David Marchand wrote: > > No functional change intended. > > service_dump_calls_per_lcore() was always called with a 0 reset flag. > service_dump_one() was called with either a 0 reset flag or a NULL > FILE pointer. > > We can split the code for readability sake. > > Note: there is no path to resetting calls_per_service[], this is left as > is. > > Signed-off-by: David Marchand Acked-by: Harry van Haaren Applied. -- David Marchand