From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60941425D7; Mon, 18 Sep 2023 16:42:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECAE54025D; Mon, 18 Sep 2023 16:42:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C2D564025C for ; Mon, 18 Sep 2023 16:42:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695048145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9mdAHhcBGn7j1W5i0igjFqbr3CUdxCDvr7ASUDEPSH8=; b=ZyMsVJicHOqbXfdS6PS1eEcR4iSR3qjmSQoWwThrv+Vv4f4kKvYe3jlOkKfkefqWG6kixB 1I0YrAeWzER4h/QCQS1JSLq4dmkFnxP/t+E219DC2L9tHyPSG/4Ecsw1pXTb4Cowduhxkq HAIdYU4jWdB/Ml3jY8y8tMGZ6M0Q+Pc= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-zDoNgrZJM2a-IvLelkgMqg-1; Mon, 18 Sep 2023 10:42:23 -0400 X-MC-Unique: zDoNgrZJM2a-IvLelkgMqg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2b710c5677eso53806751fa.0 for ; Mon, 18 Sep 2023 07:42:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695048142; x=1695652942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9mdAHhcBGn7j1W5i0igjFqbr3CUdxCDvr7ASUDEPSH8=; b=aD0gpNFhVB1BKFiLcBCdl5r0oZUmXr9FH2B+wwn477HOpuHiQF79LSah1afyo9DYG/ VxDZ5iwA3KWRy8NZV/DyikbiTYOtlqcG/hO/oc6tdiJkwwTsHQxpVFDDYoOLKlsGTvCB zUEnBm0sYYZzbzFxSpsAxixqTjlGeeUtC8sNBJZvfR7IYgqFE7ceVetWQVYwq0d62YGu aPz/NgOZ4iAO9oxlUWqas/7Y8Q9lS44WbpYIXn6YMV8EQvcRlsBImqHTBlQYZdDAdZem 6s16v7LHBXHdEgpYHh/c0iEaNHbvOwG9/dLGQsML5BayEy19I5o6qUoBbnuTn3c8eGNN yp5Q== X-Gm-Message-State: AOJu0YxvIUK1ttVvd8iWzNgMPggkdEyw0LovNx2iZFdMPYyk8yQC+rKt zb/cVfQR5so3o+O+xvyQcytNbkVgaZR8v0b//5PgEWSiqanOdwmxpSVBdiZcLRCED1t08PS/rzd QGhNr4g95jvADimHsVk8= X-Received: by 2002:a2e:a41c:0:b0:2bf:7dc5:884d with SMTP id p28-20020a2ea41c000000b002bf7dc5884dmr7649297ljn.21.1695048142483; Mon, 18 Sep 2023 07:42:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFW0ihluIWYcCH9/HSiCLDHfVhbIHAMCx5E0bkx2Rx8Kjf7Lj9TKcYGP/1d4jO2Cc/ZtzeUYga0V2d++L8fquo= X-Received: by 2002:a2e:a41c:0:b0:2bf:7dc5:884d with SMTP id p28-20020a2ea41c000000b002bf7dc5884dmr7649278ljn.21.1695048142209; Mon, 18 Sep 2023 07:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20220922070426.788643-1-kevinx.liu@intel.com> <20220927071522.3656059-1-kevinx.liu@intel.com> In-Reply-To: <20220927071522.3656059-1-kevinx.liu@intel.com> From: David Marchand Date: Mon, 18 Sep 2023 16:42:10 +0200 Message-ID: Subject: Re: [PATCH v2 0/2] check illegal packets To: Kevin Liu , qi.z.zhang@intel.com Cc: dev@dpdk.org, qiming.yang@intel.com, stevex.yang@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com, Mike Pattrick , Kevin Traynor X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 27, 2022 at 9:24=E2=80=AFAM Kevin Liu wr= ote: > > Check whether the data packet is illegal of ice and iavf driver. > > v2: > Change the scheme, check the data_len and update commit log. > > Kevin Liu (2): > net/iavf: check illegal packets > net/ice: check illegal packets > > drivers/net/iavf/iavf_rxtx.c | 9 +++++++++ > drivers/net/iavf/iavf_rxtx.h | 2 ++ > drivers/net/ice/ice_rxtx.c | 11 +++++++++++ > drivers/net/ice/ice_rxtx.h | 2 ++ > 4 files changed, 24 insertions(+) This series looks wrong to me. - What happens if the application requests TSO to the nic? - Checking data_len of a mbuf means only checking the size of the first segment, so if any limitation applies to the packet size, it should by checking pkt_len. I will probably send reverts for the two patches. --=20 David Marchand