From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DABEA034C; Thu, 28 Apr 2022 14:18:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA8CA42819; Thu, 28 Apr 2022 14:18:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7728440E50 for ; Thu, 28 Apr 2022 14:18:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651148331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ar5Tw8wO7iDdlSITTJAGTtwPnvBfc83qaXvSn0tpCCI=; b=TmZk1exJa8TkkzY5I5Fuqy09mjAeX5bgzOQAZfYx5USmdux8Inf430R/aLEfHWmH9+M1hG LiQZ5SJulqkLpSVemMDtonqVQk/Z9nqeJQCpxfsz5Hlqx60DjNVmeKgBpEabq67uWwbW7Y R9mCYnVRbdklByso26KIKz0RrtzjvPQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-498-3io0WZ2EM2yl7McERsLf8w-1; Thu, 28 Apr 2022 08:18:49 -0400 X-MC-Unique: 3io0WZ2EM2yl7McERsLf8w-1 Received: by mail-lf1-f70.google.com with SMTP id h12-20020a05651211cc00b00471af04ec12so1956080lfr.15 for ; Thu, 28 Apr 2022 05:18:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ar5Tw8wO7iDdlSITTJAGTtwPnvBfc83qaXvSn0tpCCI=; b=PN1Wih//JTuGjB7GMoeqJqnUjTDYlnJDHqS6Z2NhjPiM9QzihSioap+cpA2nDVdT+d mpsqwYOabpd46zqh9/u0AK0rB6X5zQBMV5UEzKX4YdnGFBv/Rr3bFTxcRa8MkDJow8sx SfkQ7R0OIbCOuWt6p9ZspKtomeHNBsOY5A2bu1ekflNKdGzlPgEjzHADWvYWUa3a9kF1 +60GvkPNf/xEPnCul9qwiTTcnAfB7qyFSoA0y91vURe6ckwL2QmC4QI/CN2UkQaWY0LD Ff2X1AP2RANciuW1QHqHw2eTv2AU1STmww9rWh9t18tbZAUsy8dpa/PRGLnJ/JlCRQmT nXHw== X-Gm-Message-State: AOAM530JE8MetvN3TBhsY4e9NNqSf2Q6qrvr7zxkPqeS68o7PxJKnTp/ OU8SCqFLEOFl4GVFczHVwrwN5ZAmGOPS9XCBJhHp/RP+6PZD868A+nKxKedPIX1DcGibjjOe99d jWoxMJEFnq2Pp3agMRFg= X-Received: by 2002:a2e:9d90:0:b0:24f:224:8dfa with SMTP id c16-20020a2e9d90000000b0024f02248dfamr18191277ljj.46.1651148328180; Thu, 28 Apr 2022 05:18:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7r3xOMTZdFSJQRQTp39/pwD48J+1xrlcgIiIL4gkRvWdViSuMXlSqG/TomrAqNCfVfwTvhSx3WQpEAUcmw0g= X-Received: by 2002:a2e:9d90:0:b0:24f:224:8dfa with SMTP id c16-20020a2e9d90000000b0024f02248dfamr18191264ljj.46.1651148327957; Thu, 28 Apr 2022 05:18:47 -0700 (PDT) MIME-Version: 1.0 References: <20220407144411.5520-1-laitianli@tom.com> In-Reply-To: <20220407144411.5520-1-laitianli@tom.com> From: David Marchand Date: Thu, 28 Apr 2022 14:18:36 +0200 Message-ID: Subject: Re: [PATCH] interrupts: add uio type to support multiple interrupt vector To: Tianli Lai Cc: dev , Harman Kalra Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 7, 2022 at 8:45 AM Tianli Lai wrote: > > vmxnet3 device use MSI-X interrupt type. > vmxnet3 driver configure the hardware to generate MSI-X interrupts > would fail when call rte_intr_cap_multiple function return zero. Iiuc, the issue is that you are using vmxnet3 devices bound to igb_uio. Out of curiosity, why not use vfio-pci? > > Signed-off-by: Tianli Lai > --- > lib/eal/linux/eal_interrupts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c > index d52ec8eb4c..4b4dffa20c 100644 > --- a/lib/eal/linux/eal_interrupts.c > +++ b/lib/eal/linux/eal_interrupts.c > @@ -1596,6 +1596,9 @@ rte_intr_cap_multiple(struct rte_intr_handle *intr_handle) > if (rte_intr_type_get(intr_handle) == RTE_INTR_HANDLE_VDEV) > return 1; > > + if (rte_intr_type_get(intr_handle) == RTE_INTR_HANDLE_UIO) > + return 1; > + Doing this will let drivers think there are multiple fds, ok. Though (I am not entirely sure) with this patch only, are not all vectors pointing to a single fd. For example, did you test Rx interrupts? with more than 1 rxq? -- David Marchand