From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 44DFA1B1CE for ; Tue, 2 Apr 2019 21:55:42 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id l22so948918uao.8 for ; Tue, 02 Apr 2019 12:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fnl5MqqqppYttUuoZ21HWXgYdx/pC0+YBBMHasJifNs=; b=OTYGODfliMK5/jquyJVU5AbBCvnKZJuViuGzXLPn72wynluUssFyLDkBt4R3EtYE1v TUb+w+3GY2bCrHyXK0g/oq/qtFwHtqQaP6PVrGawkQSN3gh8y0DpgEt4wWYQbVcuVyl1 xof2rGxkLNiiLDXJILAWOi6OHrCj5bROdPesV+n3S/trZNN+F653XwNBUL/S1iGezde9 /3/Nzl4wA4KWa3/cYhwVp4RPO07Z1VCI9my6mH/+I3ScoOzzGFDaZVp0iDHyDa75Uazw CP2R5nyuILosUh7BJ5bU7eFbEmRwVdk8JzYN7UK4Qlvg4ARmxqMMW8nB37UpP5rtVkX+ HAcw== X-Gm-Message-State: APjAAAWkU6V0uoznlPLKfKbFnkkalO60wgu1KjlTgaLOSy2TqmENfs3H zmyIQ1//feZrkO+RTL/iul2TUjOcBxnc6RvW/2Xd4g== X-Google-Smtp-Source: APXvYqyMj/p+RPXUZs0AyDBcN5PxlLrqXhQXaFSZkAVOihTTIbQ+JlWFY4RUZICS5kF236Erf3OpGIY2E6YhN4AvGJY= X-Received: by 2002:ab0:b05:: with SMTP id b5mr2049700uak.73.1554234941648; Tue, 02 Apr 2019 12:55:41 -0700 (PDT) MIME-Version: 1.0 References: <20190401230712.31864-1-thomas@monjalon.net> <20190402193048.27410-1-thomas@monjalon.net> <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> In-Reply-To: <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> From: David Marchand Date: Tue, 2 Apr 2019 21:55:30 +0200 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Bruce Richardson , dev , Anand Rawat Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 19:55:42 -0000 On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit wrote: > On 4/2/2019 8:46 PM, David Marchand wrote: > > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon > wrote: > > > >> Only one header file (rte_kni_common.h) was in the sub-directory > >> include/exec-env/ > >> This file was installed in a sub-directory of the same name > >> in the makefile-based build. > >> Source and install directories are moved as below: > >> > >> lib/librte_eal/linux/eal/include/exec-env/ > >> -> lib/librte_eal/linux/eal/include/ > >> > >> build/include/exec-env/ > >> -> build/include/ > >> > >> The consequence is to have a file hierarchy a bit more flat. > >> > >> Signed-off-by: Thomas Monjalon > >> > > > > Looks good to me. > > Reviewed-by: David Marchand > > Tested-by: David Marchand > > > > > > Bruce, while testing with meson, I noticed this: > > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument > > "console". > > WARNING: This will become a hard error in the future. > > WARNING: Unknown keyword arguments in target rte_kni: console > > I am not seeing this... > Ok, might be my setup: [dmarchan@dmarchan dpdk]$ meson --version 0.47.2 What should I check ? -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EC198A0679 for ; Tue, 2 Apr 2019 21:55:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C5091B1DD; Tue, 2 Apr 2019 21:55:43 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 44DFA1B1CE for ; Tue, 2 Apr 2019 21:55:42 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id l22so948918uao.8 for ; Tue, 02 Apr 2019 12:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fnl5MqqqppYttUuoZ21HWXgYdx/pC0+YBBMHasJifNs=; b=OTYGODfliMK5/jquyJVU5AbBCvnKZJuViuGzXLPn72wynluUssFyLDkBt4R3EtYE1v TUb+w+3GY2bCrHyXK0g/oq/qtFwHtqQaP6PVrGawkQSN3gh8y0DpgEt4wWYQbVcuVyl1 xof2rGxkLNiiLDXJILAWOi6OHrCj5bROdPesV+n3S/trZNN+F653XwNBUL/S1iGezde9 /3/Nzl4wA4KWa3/cYhwVp4RPO07Z1VCI9my6mH/+I3ScoOzzGFDaZVp0iDHyDa75Uazw CP2R5nyuILosUh7BJ5bU7eFbEmRwVdk8JzYN7UK4Qlvg4ARmxqMMW8nB37UpP5rtVkX+ HAcw== X-Gm-Message-State: APjAAAWkU6V0uoznlPLKfKbFnkkalO60wgu1KjlTgaLOSy2TqmENfs3H zmyIQ1//feZrkO+RTL/iul2TUjOcBxnc6RvW/2Xd4g== X-Google-Smtp-Source: APXvYqyMj/p+RPXUZs0AyDBcN5PxlLrqXhQXaFSZkAVOihTTIbQ+JlWFY4RUZICS5kF236Erf3OpGIY2E6YhN4AvGJY= X-Received: by 2002:ab0:b05:: with SMTP id b5mr2049700uak.73.1554234941648; Tue, 02 Apr 2019 12:55:41 -0700 (PDT) MIME-Version: 1.0 References: <20190401230712.31864-1-thomas@monjalon.net> <20190402193048.27410-1-thomas@monjalon.net> <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> In-Reply-To: <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> From: David Marchand Date: Tue, 2 Apr 2019 21:55:30 +0200 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Bruce Richardson , dev , Anand Rawat Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402195530.2tLn0IMK6-2FqErXCCdepbFsReeFK6aFdS175eV4ILg@z> On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit wrote: > On 4/2/2019 8:46 PM, David Marchand wrote: > > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon > wrote: > > > >> Only one header file (rte_kni_common.h) was in the sub-directory > >> include/exec-env/ > >> This file was installed in a sub-directory of the same name > >> in the makefile-based build. > >> Source and install directories are moved as below: > >> > >> lib/librte_eal/linux/eal/include/exec-env/ > >> -> lib/librte_eal/linux/eal/include/ > >> > >> build/include/exec-env/ > >> -> build/include/ > >> > >> The consequence is to have a file hierarchy a bit more flat. > >> > >> Signed-off-by: Thomas Monjalon > >> > > > > Looks good to me. > > Reviewed-by: David Marchand > > Tested-by: David Marchand > > > > > > Bruce, while testing with meson, I noticed this: > > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument > > "console". > > WARNING: This will become a hard error in the future. > > WARNING: Unknown keyword arguments in target rte_kni: console > > I am not seeing this... > Ok, might be my setup: [dmarchan@dmarchan dpdk]$ meson --version 0.47.2 What should I check ? -- David Marchand