From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F37CA04C9; Mon, 14 Sep 2020 10:56:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FC682BAB; Mon, 14 Sep 2020 10:56:49 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id B16B6DE0 for ; Mon, 14 Sep 2020 10:56:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600073807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ed6V6XtK+sik+QA46UCwldOkUHfZkCB6jkNIAfiAAOg=; b=Wf2Fd8OzYalo6OsIJjjM4up3yxWepELegrGQP8KQ30tXBln9vwuMvfENi94rGwnLCPJ02O KpH0b86a5TlUcbWhexbWJggTRJqQ+b32GqcMvOZyXOkj0JLPx5aaJOOatn9fjZXPCM59YS +J21qRGXHhZZNZl9aDrLlWYvRWaPfL8= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-p9J8r075NTW2heD_dwhA6g-1; Mon, 14 Sep 2020 04:56:45 -0400 X-MC-Unique: p9J8r075NTW2heD_dwhA6g-1 Received: by mail-vk1-f197.google.com with SMTP id j134so403732vke.1 for ; Mon, 14 Sep 2020 01:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ed6V6XtK+sik+QA46UCwldOkUHfZkCB6jkNIAfiAAOg=; b=go/vmX4VhZziCIA8I++1KbwMUJ587R51ZmvvjCfX3FDOLnPvBRfA61WtflLx9V3MiC frtxz5C0pkMxQgYfScgNHkI2wOT/ZdOVugasygjxd1cPAN3jFwPmtqYqyMwjdbm4kAAt dCeh3Z7viE9DOXfGyAZBWKLWrGGukQSVM2DVXlXFLRXaAhiFyP+JG4xjVLWqiIf+8NO7 aKq6l3eEdOKlx9cei/e0CChpxLiKluc8Fo6bxPfK6op1zUGL3eQxue2iq+5BUBoy2HSw L3hn3sUNd8uqS1B8cXtNP1iKQ0BqY65+XP7izcL4ZYHg8F7hgcvfRtNldZQvGZNfi8rS +BIw== X-Gm-Message-State: AOAM533N3OwuhWlkFPt2BD50SWDODgAclvs1kvcU7Oqobf3i4dITNWra Ixqhskwfi2Y+7yFHuJzGD0aa35aATkyRWs17vykC+vCC1BmTL9xCzunmdg7Tgpr/K8eZKQIGrbc 95ayvZMUTPXAG21jyo7M= X-Received: by 2002:a1f:a906:: with SMTP id s6mr3460685vke.41.1600073804664; Mon, 14 Sep 2020 01:56:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxRpNySDfh5SjuN7t9bGdmHIR2BDZX6pS/7KzyUgN/4fiwcffmLKrZnVN/MLRHeuqpBm5ge6hAn7HyibaIEhM= X-Received: by 2002:a1f:a906:: with SMTP id s6mr3460683vke.41.1600073804488; Mon, 14 Sep 2020 01:56:44 -0700 (PDT) MIME-Version: 1.0 References: <20190724172037.7776-1-stephen@networkplumber.org> <20200903232822.19167-1-stephen@networkplumber.org> In-Reply-To: <20200903232822.19167-1-stephen@networkplumber.org> From: David Marchand Date: Mon, 14 Sep 2020 10:56:33 +0200 Message-ID: To: Stephen Hemminger Cc: dev , Harman Kalra Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eal/interrupts: add function to allow interruptible epoll X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 4, 2020 at 1:28 AM Stephen Hemminger wrote: > > The existing definition of rte_epoll_wait retries if interrupted > by a signal. This behavior makes it hard to use rte_epoll_wait > for applications that want to use signals do do things like > exit polling loop and shutdown. > > Since changing existing semantic might break applications, add > a new rte_epoll_wait_interruptible() function that does the > same thing as rte_epoll_wait but will return -1 and errno of EINTR > if it receives a signal. > > Signed-off-by: Stephen Hemminger > Reviewed-by: Harman Kalra You will certainly argue that the existing function had no unit test but we want to fix this at some point. Can a unit test be added? Thanks. -- David Marchand