From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA0C5A0C41; Sun, 24 Oct 2021 12:39:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B6694003E; Sun, 24 Oct 2021 12:39:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0B2E94003C for ; Sun, 24 Oct 2021 12:39:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635071962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9J86VA7BFZnA3MHHI9stjvcnyAzOWJ+PsuFkotSclzI=; b=QoTF3U3taP0ttqGhGJILJi1ZszLW6ForjNatH4xEi7AaiR+iDJzrAUnaS751y5PRIEwrnQ HVPZhgiUQHHfo/l6djAowKDF87AjcMgxXvMpFUd2hgU4aWkNojK5hTBpGeUWcKm64mD6jg SX22uUBE6FtoTE2t+GcSDOQjbXZijLU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-j__I7byIPhWnN0BHGBY4Vw-1; Sun, 24 Oct 2021 06:39:19 -0400 X-MC-Unique: j__I7byIPhWnN0BHGBY4Vw-1 Received: by mail-lf1-f71.google.com with SMTP id x17-20020a0565123f9100b003ff593b7c65so4162184lfa.12 for ; Sun, 24 Oct 2021 03:39:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9J86VA7BFZnA3MHHI9stjvcnyAzOWJ+PsuFkotSclzI=; b=Xbdgog11tLLmkRLkugA48K2groGwXMLdKaw5F40SG2oMTA44aztuzDHDZUPhMNLMG8 Y3TRPyIN2QsRuWNHk3WNRRdhmwBmpxrLSwkqiqMui+ZfOPx6tTqPJV6k3w5w/Ksheohc aGrNXHUSEnW21GBbp5zN5Bkp4qXHWgV/bbYurxm+mA8B02hfNseA90hfjOkJbryTvFBz FstKaGFkpVJP3ffvTYfqk5tKMl7n6YwBhf7Q78BVsasW0dqnbtf0nlOqvNWJ9MQwUT4f bGtyPxPJDRU7T+4yXeulOVYhp4I9u8mETtkMSK7EErI6bKkQB4oR1zvQ/D8owuBmgI9I Ma8A== X-Gm-Message-State: AOAM530Wzm8zXNw89P3LT9g//icGd0KTSFJhRWnfJp06+19mMdjPU6rf OIe4ibLodzU7TLAS7uFtobfaokh8KOzsZjgqZP71oeoX30UAsw5sQLeHOw46Ffezrg9FsgKB9/J +m2exStQuyHcMSGy4bmo= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr10621943lfu.575.1635071957752; Sun, 24 Oct 2021 03:39:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwe4kVl5FpHRUA9ok5mRj4oZoXmr9QeiTQQkAE4VckvzVDbZZ1EAD5rsoB2Mo/ZjsM1AkP+IGEgmoVBgFKwdIk= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr10621927lfu.575.1635071957496; Sun, 24 Oct 2021 03:39:17 -0700 (PDT) MIME-Version: 1.0 References: <20211022132642.30669-1-konstantin.ananyev@intel.com> In-Reply-To: <20211022132642.30669-1-konstantin.ananyev@intel.com> From: David Marchand Date: Sun, 24 Oct 2021 12:39:06 +0200 Message-ID: To: Konstantin Ananyev , "Yigit, Ferruh" , Thomas Monjalon Cc: dev , Chas Williams , "humin (Q)" , leweix.yang@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello guys, On Fri, Oct 22, 2021 at 3:27 PM Konstantin Ananyev wrote: > > link bounding auto-test internally creates emulated ethdev. > Some tests change Rx/Tx functions of this emulated device on the fly: > by directly modifying rte_eth_dev fields and without doing stop/start > for these devices. > As now ethdev uses rte_eth_fp_ops[] for fast-path functions, these > direct changes doesn't make expected effect. > Fix the problem by guarding fast-path functions changes with > rte_eth_dev_stop()/rte_eth_dev_start(). > > Fixes: 7a0935239b9e ("ethdev: make fast-path functions to use new flat array") > > Reported-by: Lewei Yang > Signed-off-by: Konstantin Ananyev I suspect there is something broken in (bitratestats_autotest|latencystats_autotest|pdump_autotest) tests that make use of app/test/sample_packet_forward.* code. This code creates a portid from a ring, but I guess this port is not properly setup wrt to API. It goes unnoticed in CI atm, with tests returning ok. Looking at main branch test in UNH, testlog.txt files are millions of lines filled with: test_packet_forward() line 104: Error sending packet to port 0 send pkts Failed or: tx_pkt_burst for not ready port There may be more issues, the files are just too huge. Example: https://lab.dpdk.org/results/dashboard/results/results-uploads/test_runs/1dd418abe77644c18417dcb589e994aa/log_upload_file/2021/10/dpdk_2e437f1cd65e_2021-10-23_22-04-34_NA.zip -- David Marchand