From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D066CA052A; Tue, 26 Jan 2021 15:40:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC543140CF9; Tue, 26 Jan 2021 15:40:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A1092140CE6 for ; Tue, 26 Jan 2021 15:40:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611672046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=45i4KcZ2RcDz+6qqZ+hxkIPcfwfckQlFrJnIMRJO1Wo=; b=MCDri1eCkbRIAyVYmTqhxPunz+2TsuNRZV9a5VE4+rHxmPAy4T8ViVB5VfEgR/YnDwZbHS X9ZAZLQ1m2C359r/38zOdH6je+T34B/e1vCkjyEggDRUNUV7DGYVHe5fUDqdjV7M2CaqPs +fxaQJ3MFemPE7lrOzp/XXDHdehhdk8= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-detsrnjKOOGImJdxV1WWiQ-1; Tue, 26 Jan 2021 09:40:45 -0500 X-MC-Unique: detsrnjKOOGImJdxV1WWiQ-1 Received: by mail-vk1-f198.google.com with SMTP id j67so2086373vkh.15 for ; Tue, 26 Jan 2021 06:40:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=45i4KcZ2RcDz+6qqZ+hxkIPcfwfckQlFrJnIMRJO1Wo=; b=lkbKE2h/9NzOv2mTmdztiSfBOI2G+N5vni7drwDQABsGAUTfpq7VvNToueBkMgRkNB 9kmzkZJPsFt90RXvr0lu5kaAkByDngXqCXEBbcmMP6/fFYnZX6/GaA902LujmFxQba0F +CnpUVucp4qO/wQsCLnGZEbwbO7/4VBwWkdpv5+aGhZpEPXbBtiBP0qCE7ZbgVk9PVoL VIbtMXXN+2k/D7Ijc3hMT7n3+M/E4bSrnjCu2UQ7S+u4rp7OUwa9aWUNifo18t7kkSV9 +HYwNjEUpdWjsQl9c65j1cP15la409lBCIEjNYNsxWg8yyNcWJHk7TJTxZ+Jcc5pFPuk 1wcg== X-Gm-Message-State: AOAM532I8cfzR3qLfxMWHnZnZplyUiillzLrQ8A2rs2XOHPHat02Dr0F YtTu1kOqiGY0+oa02cWsIb2Jj5LaWjJGArP5wofG2FU0pJTpK2MWZg5yghrSkuiWu/ivQcMuglk 9NNsrvFZGN/5LBVud444= X-Received: by 2002:a67:ecd5:: with SMTP id i21mr4706430vsp.18.1611672044514; Tue, 26 Jan 2021 06:40:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjUNBohGsWlDezPkYzS/5i3pqU5nMDbX8DNRGIyoJFPxNSUTNrMVTLH3BGbbo+eFlGZxhGwWi5ssSL4lcD+2s= X-Received: by 2002:a67:ecd5:: with SMTP id i21mr4706414vsp.18.1611672044303; Tue, 26 Jan 2021 06:40:44 -0800 (PST) MIME-Version: 1.0 References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <20210126101639.250481-3-maxime.coquelin@redhat.com> <39585a4d-e937-b186-c482-b0dc0a48f762@ashroe.eu> In-Reply-To: <39585a4d-e937-b186-c482-b0dc0a48f762@ashroe.eu> From: David Marchand Date: Tue, 26 Jan 2021 15:40:33 +0100 Message-ID: To: "Kinsella, Ray" Cc: Maxime Coquelin , dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 26, 2021 at 2:23 PM Kinsella, Ray wrote: > >> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > >> index 1dc84fa74b..170304c876 100644 > >> --- a/devtools/libabigail.abignore > >> +++ b/devtools/libabigail.abignore > >> @@ -11,6 +11,8 @@ > >> ; Explicit ignore for driver-only ABI > >> [suppress_type] > >> name = eth_dev_ops > >> +[suppress_function] > >> + name_regexp = rte_vdev_(|un)register > >> > >> ; Ignore fields inserted in cacheline boundary of rte_cryptodev > >> [suppress_type] > > > > Ray, > > Are you okay with this exception? > > Ask a perhaps silly question, > shouldn't rte_vdev_register & rte_vdev_unregister have been INTERNAL in any case? I discussed with Thomas earlier. The INTERNAL exception rule we have suppresses changes on symbols already versioned INTERNAL. If we mark these two symbols INTERNAL now, they are part of the stable v21 ABI in any case. libabigail will still complain about them disappearing. $ abidiff --suppr /home/dmarchan/dpdk/devtools/../devtools/libabigail.abignore --no-added-syms --headers-dir1 /home/dmarchan/abi/v20.11/build-gcc-shared/usr/local/include --headers-dir2 /home/dmarchan/builds/build-gcc-shared/install/usr/local/include /home/dmarchan/abi/v20.11/build-gcc-shared/dump/librte_bus_vdev.dump /home/dmarchan/builds/build-gcc-shared/install/dump/librte_bus_vdev.dump Functions changes summary: 2 Removed, 0 Changed, 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 2 Removed functions: [D] 'function void rte_vdev_register(rte_vdev_driver*)' {rte_vdev_register@@DPDK_21} [D] 'function void rte_vdev_unregister(rte_vdev_driver*)' {rte_vdev_unregister@@DPDK_21} We will need an exception in any case for them. -- David Marchand