From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CDB7A0A04; Fri, 15 Jan 2021 16:56:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFA981411A9; Fri, 15 Jan 2021 16:56:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 15ADB1411A7 for ; Fri, 15 Jan 2021 16:56:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610726169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hDnGjd1WWAQE7x3VtIRkY6lVUcaijwXoeuda7mV/sMQ=; b=YNOmI+DxqpDBgWxe1hF9jDluDS3to50OyU07MpqCEG0PBykpSWLFuEGiugcgYONelFLr62 FW7YHUB45D9CSg3IL7RHW+mFa7W1RRJZVsH5bZyLLUUpW5nQ018O9BFltIGrVeKvvtobxg vwZKShbNSFdhX6kYTDrtPuQWgKB1qrU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-A9sEhhrpONK2Wsc2u-jEKA-1; Fri, 15 Jan 2021 10:56:05 -0500 X-MC-Unique: A9sEhhrpONK2Wsc2u-jEKA-1 Received: by mail-vs1-f70.google.com with SMTP id x16so1648266vsx.6 for ; Fri, 15 Jan 2021 07:56:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hDnGjd1WWAQE7x3VtIRkY6lVUcaijwXoeuda7mV/sMQ=; b=HwnJFd1OP0p1J4KLMkjwuejAR+/OWVLYkHyfZialZWiKeovQdGefJVo6kV1zazE5sy GVYlahXPDBjszK7SqAijPkgbiRAvmRviwRVOp/NM0AhjiuZ1RBQT13V5Yfp+JzeioEWa RN0aA26vgcElAW33rmblyex3xqAPzvh3+ydkvIjmAfdpRce54V3WV06bAYyCYs4Gxfe5 Y2bA2tPoNcoa54ZEnn5XakaFVUNCZH4unQihMB0IRLS4BH0bdcIgSmSppw08hy6UhpD5 LdCHBmHtcRXYrPv/4WRiotlhOdK3dv/HjTRyFG4Ez28C2y7nuZxNAfucMIRphS79ULF9 FpIg== X-Gm-Message-State: AOAM531Gnzwi8RNW8M0VZAx4rFs2MCkhdDdFSFR2KbvkfpcK40nXPLOg jbVnJZKl1BMpurWzp5xXUTijQVSd/QIFlvaL0Us56UxJPaivs31d5Vgfw4Uz4ZKLzUBiVZZAUcb B2xOZEVYIAFq9Bi8cfOI= X-Received: by 2002:a67:3093:: with SMTP id w141mr5806949vsw.27.1610726165489; Fri, 15 Jan 2021 07:56:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxaeoZi86ofHAtdE+VafC25VTEjR921OODlzu0vFFZNj14HX8SrNoGwv4xTdtkQAuAUIH2QESnft2jxfvKHmcg= X-Received: by 2002:a67:3093:: with SMTP id w141mr5806936vsw.27.1610726165316; Fri, 15 Jan 2021 07:56:05 -0800 (PST) MIME-Version: 1.0 References: <20210115095821.42721-1-joyce.kong@arm.com> In-Reply-To: <20210115095821.42721-1-joyce.kong@arm.com> From: David Marchand Date: Fri, 15 Jan 2021 16:55:54 +0100 Message-ID: To: Joyce Kong Cc: Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , Honnappa Nagarahalli , dev , nd , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 15, 2021 at 10:58 AM Joyce Kong wrote: > > Compiling with "meson build -Dbuildtype=3Ddebug --cross-file > config/arm/arm64_thunderx2_linux_gcc" shows the warnings > "function returns an aggregate [-Waggregate-return]": > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In > function =E2=80=98__cas_128_relaxed=E2=80=99: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20: > error: function returns an aggregate [-Werror=3Daggregate-return] > __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp") > ^~~~~~~~~~~~~~~~~ > > Fix the compiling issue by defining __ATOMIC128_CAS_OP as a void > function and passing the address pointer into it. > > Fixes: 7e2c3e17fe2c ("eal/arm64: add 128-bit atomic compare exchange") > Cc: stable@dpdk.org > > Signed-off-by: Joyce Kong >From my tests, the trigger is when switching to debug. The thunderx2 target builds fine for me with debugoptimized. I can reproduce the issue too with octeontx2. What is the common point? --=20 David Marchand