From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3969A32A2 for ; Thu, 24 Oct 2019 21:31:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 998671EC02; Thu, 24 Oct 2019 21:31:46 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 593501EBF5 for ; Thu, 24 Oct 2019 21:31:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571945504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8iG3Be4eatOUVqq+UEUvnf1wsYZ2YsMKNfYzQ6CMoAA=; b=X7+8AL6WCMpo4jheyyp3qhcE2PKPBHugeYz/EmiKlELgGC9RMxKooOfvyNQ8ZgqH0Duy8i +LQAD7BYJf62Q9+cYzypXWO0WFCTEyjYI5vVYJRo+rSvvSOp2mD7QLXlMEH1J5O3xlE8c2 0QOYmI2I9t8C9Qkg5MgokClu77A8CR4= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-Gol1_MIcNH-xF-2Hot9Yfw-1; Thu, 24 Oct 2019 15:31:43 -0400 Received: by mail-ua1-f69.google.com with SMTP id r39so3405674uad.3 for ; Thu, 24 Oct 2019 12:31:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rynAk/FHi/+o5SFzFZS6nWVzpxVNADRNT2hQ3Cu8bDk=; b=Txj+SCkvWwaeJABfEp4xsZF+TUZpldQr8vp0Ec2m0H4TE7u+aba+qW58jcEWbqzeoS cUrZ8QKvQ04OZ61f7QyUJUmYJQPIwteZ9zMfe7EC4TAu7kPzHRgFtsg0HKxQvo0+oifo n7blEJDa0cdCu1JKtUGXZCcn1mIA3vhHst64pBSa0w5h+bnbQoVdlurg2jvvHBTCF1XM A+cqldUKuMrKYjFf1xUkjNXxsnS1uEU9wpOXXsvRC1CMzIA0XEKUQOTAZymp+pSygvHq Oge3VH8682wch0/X09zP0GoXrLJJbKl/DNU64/1yveHryV3ujlP7z6RlGYnOG2Vr0/z1 Gq8Q== X-Gm-Message-State: APjAAAUBUXM0FHYTqWBTjCgdYsyul08LFR0wj8JVeyLuFfb+qJDNIWOY pJLiXjxxxPHC/dB9LylJEnrXAMEQPkffkFF52g0RriYEjJg8El1E0krwftsmPhj4hsm9oKggPNy P1aDbYVuxj6gx6l7wWD0= X-Received: by 2002:a67:e88b:: with SMTP id x11mr9849033vsn.180.1571945502688; Thu, 24 Oct 2019 12:31:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKPSq66gmNFDGyo3eD7JlagtYRHtx7WhIROqpjn3LVNaMCTtTq1i41TFzcY4tcq4RufxyKYIcGmIuIczClph4= X-Received: by 2002:a67:e88b:: with SMTP id x11mr9849007vsn.180.1571945502353; Thu, 24 Oct 2019 12:31:42 -0700 (PDT) MIME-Version: 1.0 References: <20191008095524.1585-1-ruifeng.wang@arm.com> <20191015092826.13002-1-ruifeng.wang@arm.com> In-Reply-To: <20191015092826.13002-1-ruifeng.wang@arm.com> From: David Marchand Date: Thu, 24 Oct 2019 21:31:31 +0200 Message-ID: To: David Hunt Cc: dev , Harman Kalra , Gavin Hu , Honnappa Nagarahalli , nd , Ruifeng Wang X-MC-Unique: Gol1_MIcNH-xF-2Hot9Yfw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix distributor unit test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang wrote: > > Bug 342 reported distributor_autotest execution suspension > on aarch64 platform. > Issue was due to lack of synchronization among threads. Distributor > thread and worker thread may get deadlocked. > Fixed synchronization issue by adding barriers. > > Another issue identified was in test case. Non-atomic operation on > stat value could cause value reset not been observed by worker thread > and mess counters. The issue was fixed by using atomic operations. > > --- > v3: > Added comments for using of C11 acquire/release semantics. (Honnappa) > > v2: > Fixed intermittent packet count incorrect failure. (Aaron, David) > Fixed Clang build on 32bit systems. > Additional patch to fix non-atomic operation in unit test. David, Can you review this series? Thanks. --=20 David Marchand