From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99A2941C30; Tue, 7 Feb 2023 14:34:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3695D40ED9; Tue, 7 Feb 2023 14:34:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D87094021F for ; Tue, 7 Feb 2023 14:34:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675776872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WAHCYoSHLWA4cKGvuisjd01Xy8KTzuWv/AVo+7arDlA=; b=XK8EEIg1+eiswvQz+OjMF+HZ0WQr+nFd12N7we5TBcqwwQP0n9bLHnGzLjHGGHsfatB0kT fhMdBnXt/2V6C84qKN7hGe/i9U8IgVzH7rJd8/2Nof078S3S6fVwApIwU0qlUYJgrWB0uV 4/5hieODOIjvIAl3JVgLgM3aBHRmfrk= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-378-Q_2CyFbJOcWJR-JrOM_DvQ-1; Tue, 07 Feb 2023 08:34:31 -0500 X-MC-Unique: Q_2CyFbJOcWJR-JrOM_DvQ-1 Received: by mail-pl1-f200.google.com with SMTP id j18-20020a170903029200b00198aa765a9dso8022334plr.6 for ; Tue, 07 Feb 2023 05:34:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WAHCYoSHLWA4cKGvuisjd01Xy8KTzuWv/AVo+7arDlA=; b=fEP0tvR8lrMzba5veDCa2sHrT7IQ3YNgS7DPyJxRKAdXsygw/7J5kiAK0L4hdNw01x O0+rPCfVgXwNnvI/BdUJMHtwGKmImNnIewV42uDWbt9GJ67JFU0nL1OqowwY8OFJdsK+ HADQcUh8Bzyp3OJ2cn6Yky95uuX5LkwG6GV4e3Ijr2vHsmRzbF/FNZ28JyG3vGBnXYnb Ap9Cl8yOB4VnlDPPh2R9k1+fhXCACn5CsTkmaBGyWQkyHPcTv1qDiSHuPeRMlD+aCqbD U4auhPL9dHUTbX87FLkx4P2mbgprX5NSUjiw5qScjy5tXPXMOR58dIpsfn7PRZPQe8lt 4zWg== X-Gm-Message-State: AO0yUKVJ8AAidAZ4YfOKTPQFoRK7aSeX7Q0KrJFxZ4lBEI4GEg3BwDbs +BkuDGrErm9RZgH0jUVb+y4S7tFp3dYfnLSpFrvgt2Zs0PJuEn3N3gATYObClBHQGGg9IbxdaPx dRX7pd5/DfRgF9blURTc= X-Received: by 2002:a17:90a:9f98:b0:230:fd8a:de61 with SMTP id o24-20020a17090a9f9800b00230fd8ade61mr158504pjp.83.1675776870542; Tue, 07 Feb 2023 05:34:30 -0800 (PST) X-Google-Smtp-Source: AK7set8rovAb/mFrYTdiw7uYKWxQg6T/GOD0YgkYA/9kb47h70jjXQfezVuxRKeHJtFw4fE+uWunOTMZ8CQ5jX2+9ME= X-Received: by 2002:a17:90a:9f98:b0:230:fd8a:de61 with SMTP id o24-20020a17090a9f9800b00230fd8ade61mr158496pjp.83.1675776870279; Tue, 07 Feb 2023 05:34:30 -0800 (PST) MIME-Version: 1.0 References: <20230203084804.2235611-1-amitprakashs@marvell.com> In-Reply-To: <20230203084804.2235611-1-amitprakashs@marvell.com> From: David Marchand Date: Tue, 7 Feb 2023 14:34:19 +0100 Message-ID: Subject: Re: [PATCH] test/graph: initialize graph param variable To: Amit Prakash Shukla Cc: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 3, 2023 at 9:49 AM Amit Prakash Shukla wrote: > > Initializing rte_graph_param variable with 0 to avoid any > garbage value in structure elements which are not populated > as part of this function. Something looks strange to me. I fail to see which part of this object is not initialised by the test code. app/test/test_graph_perf.c: struct rte_graph_param gconf; app/test/test_graph_perf.c: gconf.socket_id = SOCKET_ID_ANY; app/test/test_graph_perf.c: gconf.nb_node_patterns = graph_data->nb_nodes; app/test/test_graph_perf.c: gconf.node_patterns = (const char **)(uintptr_t)node_patterns; app/test/test_graph_perf.c: graph_id = rte_graph_create(gname, &gconf); With this struct defined as: struct rte_graph_param { int socket_id; /**< Socket id where memory is allocated. */ uint16_t nb_node_patterns; /**< Number of node patterns. */ const char **node_patterns; /**< Array of node patterns based on shell pattern. */ }; Is this perhaps related to the following series? https://patchwork.dpdk.org/project/dpdk/list/?series=26783&state=%2A&archive=both If this is the case, then this fix should be squashed as part of the rte_graph_param struct extension. Thanks. -- David Marchand