* [PATCH] test/graph: initialize graph param variable
@ 2023-02-03 8:48 Amit Prakash Shukla
2023-02-07 6:47 ` Jerin Jacob
2023-02-07 13:34 ` David Marchand
0 siblings, 2 replies; 3+ messages in thread
From: Amit Prakash Shukla @ 2023-02-03 8:48 UTC (permalink / raw)
To: Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram; +Cc: dev, Amit Prakash Shukla
Initializing rte_graph_param variable with 0 to avoid any
garbage value in structure elements which are not populated
as part of this function.
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
app/test/test_graph_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_graph_perf.c b/app/test/test_graph_perf.c
index 1d065438a6..c5b463f700 100644
--- a/app/test/test_graph_perf.c
+++ b/app/test/test_graph_perf.c
@@ -324,7 +324,7 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks,
char nname[RTE_NODE_NAMESIZE / 2];
struct test_node_data *node_data;
char *ename[nodes_per_stage];
- struct rte_graph_param gconf;
+ struct rte_graph_param gconf = {0};
const struct rte_memzone *mz;
uint8_t total_percent = 0;
rte_node_t *src_nodes;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test/graph: initialize graph param variable
2023-02-03 8:48 [PATCH] test/graph: initialize graph param variable Amit Prakash Shukla
@ 2023-02-07 6:47 ` Jerin Jacob
2023-02-07 13:34 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2023-02-07 6:47 UTC (permalink / raw)
To: Amit Prakash Shukla; +Cc: Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram, dev
On Fri, Feb 3, 2023 at 2:19 PM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> Initializing rte_graph_param variable with 0 to avoid any
> garbage value in structure elements which are not populated
> as part of this function.
>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> app/test/test_graph_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_graph_perf.c b/app/test/test_graph_perf.c
> index 1d065438a6..c5b463f700 100644
> --- a/app/test/test_graph_perf.c
> +++ b/app/test/test_graph_perf.c
> @@ -324,7 +324,7 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks,
> char nname[RTE_NODE_NAMESIZE / 2];
> struct test_node_data *node_data;
> char *ename[nodes_per_stage];
> - struct rte_graph_param gconf;
> + struct rte_graph_param gconf = {0};
> const struct rte_memzone *mz;
> uint8_t total_percent = 0;
> rte_node_t *src_nodes;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test/graph: initialize graph param variable
2023-02-03 8:48 [PATCH] test/graph: initialize graph param variable Amit Prakash Shukla
2023-02-07 6:47 ` Jerin Jacob
@ 2023-02-07 13:34 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2023-02-07 13:34 UTC (permalink / raw)
To: Amit Prakash Shukla; +Cc: Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram, dev
On Fri, Feb 3, 2023 at 9:49 AM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> Initializing rte_graph_param variable with 0 to avoid any
> garbage value in structure elements which are not populated
> as part of this function.
Something looks strange to me.
I fail to see which part of this object is not initialised by the test code.
app/test/test_graph_perf.c: struct rte_graph_param gconf;
app/test/test_graph_perf.c: gconf.socket_id = SOCKET_ID_ANY;
app/test/test_graph_perf.c: gconf.nb_node_patterns = graph_data->nb_nodes;
app/test/test_graph_perf.c: gconf.node_patterns = (const char
**)(uintptr_t)node_patterns;
app/test/test_graph_perf.c: graph_id = rte_graph_create(gname, &gconf);
With this struct defined as:
struct rte_graph_param {
int socket_id; /**< Socket id where memory is allocated. */
uint16_t nb_node_patterns; /**< Number of node patterns. */
const char **node_patterns;
/**< Array of node patterns based on shell pattern. */
};
Is this perhaps related to the following series?
https://patchwork.dpdk.org/project/dpdk/list/?series=26783&state=%2A&archive=both
If this is the case, then this fix should be squashed as part of the
rte_graph_param struct extension.
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-07 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 8:48 [PATCH] test/graph: initialize graph param variable Amit Prakash Shukla
2023-02-07 6:47 ` Jerin Jacob
2023-02-07 13:34 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).