From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F9E2A00C2; Wed, 17 Mar 2021 16:36:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6514140E9D; Wed, 17 Mar 2021 16:36:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D62B0140E9D for ; Wed, 17 Mar 2021 16:36:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615995390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=meCrGDLK89f6Er6WbPeUSTB0vHuCQ8d1W3SCVx0IZKA=; b=VazGo0eY5UfXduFWWcuyx7qqpwk+/zZXm7serCqitc/bzr9gCw6BdqbJLxJcPuaCgHAD8R kTIbXxThUsrhX0iavY3Li+5TYbvDj3x2Ed5CHzjyZ5SGWRrKgHOZ2ynj3U8cWVANWZDE5t 3wic6uiMy7CFkWnGLHF8wD2E8R4K804= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-uJpDp9xyOmmvb8QtFHEcRA-1; Wed, 17 Mar 2021 11:36:27 -0400 X-MC-Unique: uJpDp9xyOmmvb8QtFHEcRA-1 Received: by mail-ua1-f71.google.com with SMTP id h13so186434uaj.6 for ; Wed, 17 Mar 2021 08:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=meCrGDLK89f6Er6WbPeUSTB0vHuCQ8d1W3SCVx0IZKA=; b=TTz4y9QgKLUN3wD34cfvJlnTgM7w/gM4H2/h26IFl8FHhl+2T7T+sa90KqtUXmn2sM zdXA1UTP07AU2O15i3qcoMF+tESwsuRyjvCbo/oVUFykVZjwAkLnPNNpu6iFgccCW+0f U4TzwkxOJ3oB1URUzrDw7npj1KBPd5y5HGTiU4ZDKRhWpbwFo9mMFofS/BfCa0iwkrZg r3gDSKFTnDoBI+lrguN1PfD62SIF8SImPBlIgQWaTPYZzTGBcga/Qy//AhbZzzweHRZX 8zOWhILrf1KlBEU2fKfyA9FOfWL0mDCVsLYUrflETkQdxkZXFtf7Y2fzpSBrQOr1SBVl 6UZQ== X-Gm-Message-State: AOAM530DX4eb82mgW63jjtkjzAKYexFB1ys1dy8NCuFHqSA+JP7GKJ4R P9yQH1FAc6hKyTO/ZOjrp2WSDZQgO4kJRqc/sFIqM49ObdO7OVYNf9tXnI0A8NXTWxXLaT/tgY+ j2IqEktL32TAYcBQNo2o= X-Received: by 2002:a1f:d283:: with SMTP id j125mr3673044vkg.9.1615995386512; Wed, 17 Mar 2021 08:36:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLSL8SrXYfh0gHktKIEvjKFnT78Z9svgbOvTYREeNjsan3u73X0t0NlgqSqAJmVktkwDwymNTMNYNmVPJZQRI= X-Received: by 2002:a1f:d283:: with SMTP id j125mr3673031vkg.9.1615995386323; Wed, 17 Mar 2021 08:36:26 -0700 (PDT) MIME-Version: 1.0 References: <20210317093124.965624-1-thomas@monjalon.net> In-Reply-To: <20210317093124.965624-1-thomas@monjalon.net> From: David Marchand Date: Wed, 17 Mar 2021 16:36:15 +0100 Message-ID: To: Thomas Monjalon Cc: dev , dpdk stable , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix version macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > The macro RTE_VERSION is broken since updated with function calls. > It is a build-time version number, and must be built with macros. > For a run-time version number, there is the function rte_version(). > > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") > Cc: stable@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Thomas Monjalon Acked-by: David Marchand Let's discuss the versioning of the new symbols in the other thread. Thanks. -- David Marchand